[Pkg-octave-devel] r1537 - octave-pkg-dev/trunk

[Rafael Laboissiere]

* Thomas Weber <thomas.weber.mail at gmail.com> [2008-04-01 10:10]:

> Yes, but the top-level PKG_ADD file is not included. In the
> combinatorics package, it tells Octave where to find the function
> partcnt, so:
> 
> ==========================================================================
> octave-combinatorics as installed by octave-pkg-dev (0.5.2):
> 
> octave:1> help partcnt
> 
> help: `partcnt' not found
> ==========================================================================
> 
> 
> ==========================================================================
> combinatorics as installed by pkg.m natively:
> 
> octave:3> help partcnt
>  -- Loadable Function: P = partcnt(N)
> 
> ==========================================================================

Yes, you are right, I think I will have to revert the change in
octve-pkg.mk.in.

However, I think that this behavior of pkg.m is quite bogus, because PKG_ADD
are associated with the files contained in a directory.  In this case, where
should the topdir PKG_ADD go?

If you look at the PKG_ADD file from combinatorics, you will see that the
line there could have been put in partint.cc, like this:

// PKG_ADD: autoload ("partcnt", fullfile (fileparts (mfilename ("fullpath")), "partint.oct"));

Furthermore, I noticed a bug regarding the topdir PKG_ADD in the
octave-fixed package.  This package has "PKG_ADD:" directives in both
inst/*.m and src/*.cc files.  The pkg command generates then PKG_ADD files
automatically in both installed directories but completely ignores the
topdir PKG_ADD.  I already sent a patch to David Bateman fixing this.

-- 
Rafael