[Pkg-octave-devel] Bug#502110: octave3.0: errorbar fails because of bug, with patch

[Francesco Potorti`]

Package: octave3.0
Version: 1:3.0.1-6lenny1
Severity: normal
Tags: upstream

errobar fails on some inputs because of a bug in __errplot__.m, where an
if statement makes string comparison checks using ==.  I corrected that
by using a switch statement instead.  I am sending this to the Debian
bug report system because the correction is simple to backport.

# HG changeset patch
# User Francesco Potortì <pot at gnu.org>
# Date 1223914569 -7200
# Node ID 93719333471e3bbca9212f42d045a2fce0e35472
# Parent  231100de1d58cdbedab4afe363b7ed67111e1bbf
Wrong if statement substituted with a switch

diff -r 231100de1d58 -r 93719333471e scripts/ChangeLog
--- a/scripts/ChangeLog	Sat Oct 11 08:48:21 2008 +0200
+++ b/scripts/ChangeLog	Mon Oct 13 18:16:09 2008 +0200
@@ -1,3 +1,8 @@ 2008-10-10  David Bateman  <dbateman at fre
+2008-10-13  Francesco Potortì  <pot at gnu.org>
+
+	* plot/__errplot__.m: Wrong if switch compared strings using ==.
+	Subsituted with a switch statement.
+
 2008-10-10  David Bateman  <dbateman at free.fr>
 
 	* image/__img__.m: Manually set the limits of th eimage
diff -r 231100de1d58 -r 93719333471e scripts/plot/__errplot__.m
--- a/scripts/plot/__errplot__.m	Sat Oct 11 08:48:21 2008 +0200
+++ b/scripts/plot/__errplot__.m	Mon Oct 13 18:16:09 2008 +0200
@@ -35,21 +35,22 @@ function h = __errplot__ (fstr, p, a1, a
 
   for i = 1:nplots
     ## Set the plot type based on linestyle.
-    if (fmt.linestyle == "~")
-      ifmt = "yerr";
-    elseif (fmt.linestyle == ">")
-      ifmt = "xerr";
-    elseif (fmt.linestyle == "~>")
-      ifmt = "xyerr";
-    elseif (fmt.linestyle == "#")
-      ifmt = "box";
-    elseif (fmt.linestyle == "#~")
-      ifmt = "boxy";
-    elseif (fmt.linestyle == "#~>")
-      ifmt = "boxxy";
-    else
-      print_usage ();
-    endif
+    switch (fmt.linestyle)
+      case "~"
+	ifmt = "yerr";
+      case ">"
+	ifmt = "xerr";
+      case "~>"
+	ifmt = "xyerr";
+      case "#"
+	ifmt = "box";
+      case "#~"
+	ifmt = "boxy";
+      case "#~>"
+	ifmt = "boxxy";
+      otherwise
+	print_usage ();
+    endswitch
 
     h = __line__ (p);
 



-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'testing-proposed-updates')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.26-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=it_IT at euro (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)
Shell: /bin/sh linked to /bin/bash

Versions of packages octave3.0 depends on:
ii  libatlas3gf-base [libl 3.6.0-22          Automatically Tuned Linear Algebra
ii  libblas3gf [libblas.so 1.2-2             Basic Linear Algebra Subroutines 3
ii  libc6                  2.7-13            GNU C Library: Shared libraries
ii  libcurl3-gnutls        7.18.2-5          Multi-protocol file transfer libra
ii  libfftw3-3             3.1.2-3.1         library for computing Fast Fourier
ii  libgcc1                1:4.3.2-1         GCC support library
ii  libgfortran3           4.3.2-1           Runtime library for GNU Fortran ap
ii  libglpk0               4.29-2            linear programming kit with intege
ii  libhdf5-serial-1.6.6-0 1.6.6-4           Hierarchical Data Format 5 (HDF5) 
ii  liblapack3gf [liblapac 3.1.1-1           library of linear algebra routines
ii  libncurses5            5.6+20080830-1    shared libraries for terminal hand
ii  libpcre3               7.6-2.1           Perl 5 Compatible Regular Expressi
ii  libqhull5              2003.1-9lenny1    calculate convex hulls and related
ii  libreadline5           5.2-3             GNU readline and history libraries
ii  libstdc++6             4.3.2-1           The GNU Standard C++ Library v3
ii  libsuitesparse-3.1.0   3.1.0-3           collection of libraries for comput
ii  texinfo                4.11.dfsg.1-4     Documentation system for on-line i
ii  zlib1g                 1:1.2.3.3.dfsg-12 compression library - runtime

Versions of packages octave3.0 recommends:
ii  gnuplot                       4.2.3-1    A command-line driven interactive 
ii  libatlas3gf-base              3.6.0-22   Automatically Tuned Linear Algebra

Versions of packages octave3.0 suggests:
ii  octave3.0-doc            1:3.0.2-3       PDF documentation on the GNU Octav
ii  octave3.0-emacsen        1:3.0.2-3       Emacs support for the GNU Octave l
pn  octave3.0-headers        <none>          (no description available)
ii  octave3.0-htmldoc        1:3.0.1-6lenny1 HTML documentation on the GNU Octa
ii  octave3.0-info           1:3.0.2-3       GNU Info documentation on the GNU 

-- no debconf information