[Pkg-octave-devel] Dynare

[Rafael Laboissiere]

* Sébastien Villemot <sebastien.villemot at ens.fr> [2009-03-24 12:36]:

> Please let me know if you spot something that should be modified in  
> the package before upload.

I quickly reviewed your work.  It is nearly perfect, thanks for that.  I
fixed some minor issues, most of them detected by Lintian.  Here are some
further points that should be addressed:

1) Lintian gives the warning arch-dep-package-has-big-usr-share.  I think
   that we could put the documentation files in a separate dynare-doc
   file.  Adding doc-base support would be a plus.
   
2) The *.m scripts and the *.mex, currently installed in
   /usr/lib/dynare/matlab/ and /usr/lib/dynare/mex/octave/, respectively,
   should be put in the Octave's path.  I will take a look at this later.
   
3) Are the empty directories /usr/lib/dynare/mex/2007a/ and 2007b/ really
   needed?

4) Some bashisms in the upstream Makefiles should be fixed. For instance,
   in doc/preprocessor/Makefile, I see:

       clean:  
               rm -f preprocessor.{pdf,toc,aux,log,nav,snm,vrb,out} *~
   
   When using a POSIX-compliant shell like dash (this is what I use in my
   sid chroot), the package does not clean properly and is not
   idempotent. Please, fix.

4) Is there a test suite that can be exercised during the package build?
   It is always good to have one, such that we can detect problems before
   uploading the package.

Cheers,

-- 
Rafael