[Pkg-octave-devel] Bug#684930: unblock (pre-approval): octave/3.6.2-5

[Sébastien Villemot]

Rafael Laboissiere <rafael at laboissiere.net> writes:

> [Cc:ing to the DOG mailing list.]
>
> * Adam D. Barratt <adam at adam-barratt.org.uk> [2012-08-16 22:13]:
>
>> Control: tags -1 + moreinfo
>> 
>> [snip]
>>
>> +--- a/src/mkoctfile.in
>> ++++ b/src/mkoctfile.in
>> +@@ -77,7 +77,7 @@
>> [...]
>> +-: ${XTRA_CXXFLAGS=%OCTAVE_CONF_XTRA_CXXFLAGS%}
>> ++: ${XTRA_CXXFLAGS=-I/usr/include/mpi %OCTAVE_CONF_XTRA_CXXFLAGS%}
>> 
>> Does this have any side-effects in the case where the MPI variant wasn't
>> installed?

AFAIK, it does not. mkoctfile being essentially a wrapper around gcc,
this change results in an additional -I flag on GCC command line. When
/usr/include/mpi does not exists, this has no effect. If
/usr/include/mpi exists but libhdf5-{openmpi,mpich2}-dev is not
installed, it should not have any effect either, because Octave files
don't include MPI headers.

Also note that a similar changeset was accepted by the RT during the
development cycle of Squeeze, and it had no bad consequence:

 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=598227#29

As explained in that message, our initial intention was to support only
the serial version of HDF5 for Wheezy, but we finally changed our mind
because of user complaints and impossibility of packaging some Octave
add-ons.

Thanks for your review,

-- 
 .''`.    Sébastien Villemot
: :' :    Debian Maintainer
`. `'     http://www.dynare.org/sebastien
  `-      GPG Key: 4096R/381A7594
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-octave-devel/attachments/20120818/22b85a50/attachment.pgp>