[Pkg-octave-devel] Bug#746924: octave FTBFS on alpha: invalid argument -mieee passed to moc-qt4

[Michael Cree]

Source: octave
Version: 3.8.1-2
Severity: important
User: debian-alpha at lists.debian.org
Usertags: alpha
Justification: Fails to build from source but built in the past.

octave FTBFS on alpha, with the following:

( echo '#ifdef HAVE_CONFIG_H'; echo '#include <config.h>'; echo '#endif'; moc-qt4 -DHAVE_CONFIG_H -I. -I..   -D_FORTIFY_SOURCE=2 -mieee   src/m-editor/file-editor-interface.h ) > src/m-editor/moc-file-editor-interface.cc-t
moc: Invalid argument

The argument -mieee passed to moc-qt4 is not a valid argument thus causes
moc-qt4 to exit.

Full build log at:
http://buildd.debian-ports.org/status/fetch.php?pkg=octave&arch=alpha&ver=3.8.1-2&stamp=1399010673

The above occurs when building in the directory libgui.  It occurs because
the octave configure script adds -mieee to CPPFLAGS when building on Alpha.
Presumably this is done to save adding -mieee to each of CFLAGS, CXXFLAGS,
etc., individually, nevertheless it is not correct: -mieee is not a
preprocessor flag.

In the Makefile in the libgui directory, CPPFLAGS is added to the call of
moc-qt4.  But CPPFLAGS has -mieee which causes moc-qt4 to barf.

In a test build I removed CPPFLAGS from the call of moc-qt4, i.e., the
following:

--- octave-3.8.1/libgui/Makefile.am	2014-03-07 08:37:51.000000000 +1300
+++ octave-3.8.1-new/libgui/Makefile.am	2014-05-03 15:34:20.756281143 +1200
@@ -90,7 +90,7 @@ define moc-command
 ( echo '#ifdef HAVE_CONFIG_H'; \
   echo '#include <config.h>'; \
   echo '#endif'; \
-  $(MOC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(MOC_CPPFLAGS) $(liboctgui_la_CPPFLAGS) $< ) > $@-t
+  $(MOC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(MOC_CPPFLAGS) $(liboctgui_la_CPPFLAGS) $< ) > $@-t
 mv $@-t $@
 endef
 
diff -up octave-3.8.1/libgui/Makefile.in octave-3.8.1-new/libgui/Makefile.in
--- octave-3.8.1/libgui/Makefile.in	2014-03-07 08:42:51.000000000 +1300
+++ octave-3.8.1-new/libgui/Makefile.in	2014-05-03 15:34:51.611908637 +1200
@@ -3982,7 +3982,7 @@ define moc-command
 ( echo '#ifdef HAVE_CONFIG_H'; \
   echo '#include <config.h>'; \
   echo '#endif'; \
-  $(MOC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(MOC_CPPFLAGS) $(liboctgui_la_CPPFLAGS) $< ) > $@-t
+  $(MOC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(MOC_CPPFLAGS) $(liboctgui_la_CPPFLAGS) $< ) > $@-t
 mv $@-t $@
 endef

which resulted with octave building to completion.  However it may not be
an acceptable solution as CPPFLAGS also has -D_FORTIFY_SOURCE=2 and that
did not get passed to moc-qt4.  I have no idea whether that matters.

Cheers
Michael.