[Pkg-octave-devel] Bug#847974: xmds2: FTBFS in stretch

[Gilles Filippini]

Control: reassign -1 liboctave-dev
Control: tag -1 + patch

On Sat, 14 Jan 2017 09:57:42 +0100 Gilles Filippini <pini at debian.org> wrote:
> Control: reassign 847974 octave
> Control: retitle 847974 octave: wrong size for octave_hdf5_id wrt hdf5 1.10
> Control: affects 847974 + src:xmds2
> 
> Adrian Bunk a écrit le 13/01/2017 à 21:48 :
> > On Mon, Dec 12, 2016 at 05:42:37PM +0000, Santiago Vila wrote:
> >> Package: src:xmds2
> >> Version: 2.2.2+dfsg-2
> >> Severity: serious
> >>
> >> Dear maintainer:
> >>
> >> I tried to build this package in stretch with "dpkg-buildpackage -A"
> >> (which is what the "Arch: all" autobuilder would do to build it)
> >> but it failed:
> >> ...
> >> warning: the size of octave_hdf5_id is smaller than the size of HDF5 hid_t
> >> warning: called from
> >>     lorenz.m at line 2 column 3
> >> HDF5-DIAG: Error detected in HDF5 (1.10.0-patch1) thread 140615878277440:
> >>   #000: ../../../src/H5G.c line 464 in H5Gopen2(): not a location
> >>     major: Invalid arguments to routine
> >>     minor: Inappropriate type
> >>   #001: ../../../src/H5Gloc.c line 253 in H5G_loc(): invalid object ID
> >>     major: Invalid arguments to routine
> >>     minor: Bad value
> >> ...
> [snip]
> > What happened was the hdf5 transition.
> > 
> > Gilles, you seem to have somehow missed xmds2 in your transition 
> > planning?
> 
> Indeed; xmds2 wasn't reported by ben with my hdf5 transition config file. Sorry about that.
> Actually the problem lies in octave where type octave_hdf5_id must be adapted to the new hid_t size (int64_t).
> 
> Patch proposal coming soon.

Attached.

Raphaël, it has to be fixed before 2016-01-18 to prevent removal of
xmds2 from testing. I can NMU if needed.

Thanks,

_g.
-------------- next part --------------
diff -Nru octave-4.0.3/debian/changelog octave-4.0.3/debian/changelog
--- octave-4.0.3/debian/changelog	2016-08-18 23:32:15.000000000 +0200
+++ octave-4.0.3/debian/changelog	2017-01-14 09:34:36.000000000 +0100
@@ -1,3 +1,11 @@
+octave (4.0.3-2.1) unstable; urgency=medium
+
+  * Non-maintainer upload
+  * New patch octave_hdf5_id.patch to fix octave_hdf5_id type: it should
+    be int64_t when building against hdf5 1.10 (closes: #847974)
+
+ -- Gilles Filippini <pini at debian.org>  Sat, 14 Jan 2017 09:34:36 +0100
+
 octave (4.0.3-2) unstable; urgency=medium
 
   [ Rafael Laboissiere ]
diff -Nru octave-4.0.3/debian/patches/octave_hdf5_id.patch octave-4.0.3/debian/patches/octave_hdf5_id.patch
--- octave-4.0.3/debian/patches/octave_hdf5_id.patch	1970-01-01 01:00:00.000000000 +0100
+++ octave-4.0.3/debian/patches/octave_hdf5_id.patch	2017-01-13 23:00:43.000000000 +0100
@@ -0,0 +1,13 @@
+Index: octave-4.0.3/libinterp/corefcn/oct-hdf5-id.h
+===================================================================
+--- octave-4.0.3.orig/libinterp/corefcn/oct-hdf5-id.h
++++ octave-4.0.3/libinterp/corefcn/oct-hdf5-id.h
+@@ -23,7 +23,7 @@ along with Octave; see the file COPYING.
+ #if !defined (octave_oct_hdf5_id_h)
+ #define octave_oct_hdf5_id_h 1
+ 
+-typedef int octave_hdf5_id;
++typedef int64_t octave_hdf5_id;
+ 
+ extern bool check_hdf5_id_type (bool warn = true);
+ 
diff -Nru octave-4.0.3/debian/patches/series octave-4.0.3/debian/patches/series
--- octave-4.0.3/debian/patches/series	2016-08-18 23:31:10.000000000 +0200
+++ octave-4.0.3/debian/patches/series	2017-01-13 22:59:38.000000000 +0100
@@ -9,3 +9,4 @@
 hdf5-mkoctfile.patch
 gcc-6-abs-overload.patch
 gcc-6-include-math-stdlib.patch
+octave_hdf5_id.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 508 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-octave-devel/attachments/20170114/41884b1e/attachment-0001.sig>