[Pkg-octave-devel] Bug#867212: octave: Octave function strncmp is case insensitive

[Thierry Rascle]

Package: octave
Version: 4.2.1-2
Severity: normal
Tags: patch upstream

Dear Maintainer,

Octave function strncmp performs a case insensitive string comparison,
like strncmpi. strncmp should do a case sensitive string comparison.

This issue seems to affect recent versions of Octave. The version in
Debian Stable is not affected.

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages octave depends on:
ii  libamd2                            1:4.5.5-1
ii  libarpack2                         3.5.0-1
ii  libasound2                         1.1.3-5
ii  libblas3 [libblas.so.3]            3.7.0-2
ii  libbz2-1.0                         1.0.6-8.1
ii  libc6                              2.24-12
ii  libcamd2                           1:4.5.5-1
ii  libccolamd2                        1:4.5.5-1
ii  libcholmod3                        1:4.5.5-1
ii  libcolamd2                         1:4.5.5-1
ii  libcxsparse3                       1:4.5.5-1
ii  libfftw3-double3                   3.3.6p2-1
ii  libfftw3-single3                   3.3.6p2-1
ii  libfltk-gl1.3                      1.3.4-4
ii  libfltk1.3                         1.3.4-4
ii  libfreetype6                       2.8-0.2
ii  libgcc1                            1:7.1.0-8
ii  libgl1-mesa-glx [libgl1]           17.1.3-2
ii  libglpk40                          4.62-1
ii  libglu1-mesa [libglu1]             9.0.0-2.1
ii  libgomp1                           7.1.0-8
ii  liblapack3 [liblapack.so.3]        3.7.0-2
ii  liboctave4                         4.2.1-2
ii  libopenblas-base [liblapack.so.3]  0.2.19-3
ii  libosmesa6                         17.1.3-2
ii  libportaudio2                      19.6.0-1
ii  libqhull7                          2015.2-2
ii  libqrupdate1                       1.1.2-2
ii  libqscintilla2-12v5                2.9.3+dfsg-4+b1
ii  libqt4-network                     4:4.8.7+dfsg-11
ii  libqt4-opengl                      4:4.8.7+dfsg-11
ii  libqtcore4                         4:4.8.7+dfsg-11
ii  libqtgui4                          4:4.8.7+dfsg-11
ii  libsndfile1                        1.0.28-2
ii  libstdc++6                         7.1.0-8
ii  libsuitesparseconfig4              1:4.5.5-1
ii  libumfpack5                        1:4.5.5-1
ii  libx11-6                           2:1.6.4-3
ii  octave-common                      4.2.1-2
ii  texinfo                            6.4.0.dfsg.1-1
ii  zlib1g                             1:1.2.8.dfsg-5

Versions of packages octave recommends:
ii  default-jre-headless  2:1.8-59
ii  gnuplot-x11           5.0.5+dfsg1-7
ii  libopenblas-base      0.2.19-3
ii  octave-info           4.2.1-2
ii  pstoedit              3.70-3+b2

Versions of packages octave suggests:
pn  octave-doc      <none>
pn  octave-htmldoc  <none>

-- no debconf information
-------------- next part --------------
--- a/liboctave/util/oct-string.cc
+++ b/liboctave/util/oct-string.cc
@@ -147,7 +147,7 @@
                          const typename T::size_type n)
 {
   return (numel (str_a) >= n && numel (str_b) >= n
-          && str_data_cmpi<T> (str_a.data (), str_b.data (), n));
+          && str_data_cmp<T> (str_a.data (), str_b.data (), n));
 }
 
 template<typename T>
@@ -156,7 +156,7 @@
                          const typename T::size_type n)
 {
   return (numel (str_a) >= n && strlen<T> (str_b) >= n
-          && str_data_cmpi<T> (str_a.data (), str_b, n));
+          && str_data_cmp<T> (str_a.data (), str_b, n));
 }