[Pkg-ofed-devel] Bug#581113: infiniband-diags: bashism in /bin/sh script

[Raphael Geissert]

Package: infiniband-diags
Severity: important
Version: 1.4.4-20090314-1
User: debian-release at lists.debian.org
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' package)
check I've found your package containing a /bin/sh script making use
of a bashism.

checkbashisms' output:
> possible bashism in ./usr/sbin/set_nodedesc line 8 ($HOST(TYPE|NAME)):
> newname="$HOSTNAME"
> possible bashism in ./usr/sbin/set_nodedesc line 11 ('function' is
> useless):
> function usage
> possible bashism in ./usr/sbin/set_nodedesc line 18 ($HOST(TYPE|NAME)):
>	  echo "      Default is to use the hostname: \"$HOSTNAME\""
> possible bashism in ./usr/sbin/set_nodedesc line 22 ('function' is
> useless):
> function viewall


Not using bash (or a Debian Policy compliant shell interpreter that doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours. Please be aware that dash is now the default /bin/sh.

Hints about how to fix bashisms can be found at:
https://wiki.ubuntu.com/DashAsBinSh

If you still don't know how to fix the bashisms don't hesitate to reply to
this email, or tag the bug as 'help'.

Thank you,
Raphael Geissert