[Pkg-ofed-devel] Bug#778016: mstflint: ftbfs with GCC-5

[Matthias Klose]

Package: src:mstflint
Version: 3.7.0+1.18.gcdb9f80-3
Severity: normal
Tags: sid stretch
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-5

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-5/g++-5, but succeeds to build with gcc-4.9/g++-4.9. The
severity of this report may be raised before the stretch release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc5-20150205/mstflint_3.7.0+1.18.gcdb9f80-3_unstable_gcc5.log
The last lines of the build log are at the end of this report.

To build with GCC 5, either set CC=gcc-5 CXX=g++-5 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t experimental install g++ 

Common build failures are C11 as the default C mode, new warnings
resulting in build failures with -Werror turned on, or new/dropped
symbols in Debian symbols files.  For other C/C++ related build failures
see the porting guide at http://gcc.gnu.org/gcc-5/porting_to.html

[...]
make[3]: Leaving directory '/«BUILDDIR»/mstflint-3.7.0+1.18.gcdb9f80/mlxconfig'
Making all in mlxfwops
make[3]: Entering directory '/«BUILDDIR»/mstflint-3.7.0+1.18.gcdb9f80/mlxfwops'
Making all in lib
make[4]: Entering directory '/«BUILDDIR»/mstflint-3.7.0+1.18.gcdb9f80/mlxfwops/lib'
g++ -DHAVE_CONFIG_H -I. -I../.. -I. -I../../include/mtcr_ul -I../../mflash -I../../ext_libs/json -I../../ext_libs/minixz -I../../common -I/zlib -I ../../tools_layouts -I../../common -I../../mft_utils  -D_FORTIFY_SOURCE=2 -Wall -W -g -MP -MD -pipe -DNO_MFA_SUPPORT -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -DHAVE_TERMIOS_H -Werror -DMST_UL -c -o flint_base.o flint_base.cpp
g++ -DHAVE_CONFIG_H -I. -I../.. -I. -I../../include/mtcr_ul -I../../mflash -I../../ext_libs/json -I../../ext_libs/minixz -I../../common -I/zlib -I ../../tools_layouts -I../../common -I../../mft_utils  -D_FORTIFY_SOURCE=2 -Wall -W -g -MP -MD -pipe -DNO_MFA_SUPPORT -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -DHAVE_TERMIOS_H -Werror -DMST_UL -c -o flint_io.o flint_io.cpp
g++ -DHAVE_CONFIG_H -I. -I../.. -I. -I../../include/mtcr_ul -I../../mflash -I../../ext_libs/json -I../../ext_libs/minixz -I../../common -I/zlib -I ../../tools_layouts -I../../common -I../../mft_utils  -D_FORTIFY_SOURCE=2 -Wall -W -g -MP -MD -pipe -DNO_MFA_SUPPORT -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -DHAVE_TERMIOS_H -Werror -DMST_UL -c -o fw_ops.o fw_ops.cpp
g++ -DHAVE_CONFIG_H -I. -I../.. -I. -I../../include/mtcr_ul -I../../mflash -I../../ext_libs/json -I../../ext_libs/minixz -I../../common -I/zlib -I ../../tools_layouts -I../../common -I../../mft_utils  -D_FORTIFY_SOURCE=2 -Wall -W -g -MP -MD -pipe -DNO_MFA_SUPPORT -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -DHAVE_TERMIOS_H -Werror -DMST_UL -c -o fs2_ops.o fs2_ops.cpp
g++ -DHAVE_CONFIG_H -I. -I../.. -I. -I../../include/mtcr_ul -I../../mflash -I../../ext_libs/json -I../../ext_libs/minixz -I../../common -I/zlib -I ../../tools_layouts -I../../common -I../../mft_utils  -D_FORTIFY_SOURCE=2 -Wall -W -g -MP -MD -pipe -DNO_MFA_SUPPORT -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -DHAVE_TERMIOS_H -Werror -DMST_UL -c -o fs3_ops.o fs3_ops.cpp
fs3_ops.cpp: In member function 'bool Fs3Operations::GetModifiedSectionInfo(fs3_section_t, fs3_section_t, u_int32_t&, fs3_section_t&, u_int32_t&)':
fs3_ops.cpp:982:43: error: 'curr_itoc' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         SectToPut = (curr_itoc->toc_entry.type == sectionType) ? sectionType :  nextSectionType;
                                           ^
fs3_ops.cpp: In member function 'bool Fs3Operations::UpdateItocAfterInsert(fs3_section_t, u_int32_t, fs3_section_t, bool, u_int32_t*, u_int32_t, Fs3Operations::toc_info*, u_int32_t&)':
fs3_ops.cpp:1030:45: error: 'curr_itoc' may be used uninitialized in this function [-Werror=maybe-uninitialized]
             sectSize = curr_itoc->toc_entry.size * 4;
                                             ^
fs3_ops.cpp: In member function 'bool Fs3Operations::Fs3UpdateSection(void*, fs3_section_t, bool, CommandType, PrintCallBack)':
fs3_ops.cpp:1461:27: error: 'curr_toc' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     if (!Fs3UpdateItocInfo(curr_toc, newSectionAddr, curr_toc->toc_entry.size, newUidSection)) {
                           ^
fs3_ops.cpp: In member function 'bool Fs3Operations::Fs3Burn(Fs3Operations&, FwOperations::ExtBurnParams&)':
fs3_ops.cpp:776:30: error: 'imageInfoToc' may be used uninitialized in this function [-Werror=maybe-uninitialized]
             struct toc_info *imageInfoToc;
                              ^
fs3_ops.cpp: In member function 'virtual bool Fs3Operations::FwShiftDevData(PrintCallBack)':
fs3_ops.cpp:1525:28: error: 'mfgToc' may be used uninitialized in this function [-Werror=maybe-uninitialized]
   return ((toc ->toc_entry.flash_addr << 2) + _fwImgInfo.imgStart);
                            ^
fs3_ops.cpp:1661:19: note: 'mfgToc' was declared here
  struct toc_info* mfgToc;
                   ^
cc1plus: all warnings being treated as errors
make[4]: *** [fs3_ops.o] Error 1
Makefile:300: recipe for target 'fs3_ops.o' failed
make[4]: Leaving directory '/«BUILDDIR»/mstflint-3.7.0+1.18.gcdb9f80/mlxfwops/lib'
make[3]: *** [all-recursive] Error 1
Makefile:247: recipe for target 'all-recursive' failed
make[3]: Leaving directory '/«BUILDDIR»/mstflint-3.7.0+1.18.gcdb9f80/mlxfwops'
make[2]: *** [all-recursive] Error 1
Makefile:345: recipe for target 'all-recursive' failed
make[2]: Leaving directory '/«BUILDDIR»/mstflint-3.7.0+1.18.gcdb9f80'
make[1]: *** [all] Error 2
Makefile:228: recipe for target 'all' failed
make[1]: Leaving directory '/«BUILDDIR»/mstflint-3.7.0+1.18.gcdb9f80'
dh_auto_build: make -j1 returned exit code 2
make: *** [build-arch] Error 2
debian/rules:4: recipe for target 'build-arch' failed
dpkg-buildpackage: error: debian/rules build-arch gave error exit status 2