[Pkg-openmpi-maintainers] [Fwd: Re: debian/patches/99autoconf]

[Sylvestre Ledru]

Le lundi 25 juin 2007 à 16:32 -0500, Dirk Eddelbuettel a écrit :
> Hi Manuel,
> 
> Nice to hear from you, but very sorry about the circumstances. Are you ok?
> 
> On 25 June 2007 at 22:01, Manuel Prinz wrote:
> | Am Sonntag, den 24.06.2007, 10:09 -0500 schrieb Dirk Eddelbuettel:
> | > As you and both don't seem to know, why don't we stop conjecturing and wait
> | > for Manuel to sort this out, ok ;-) ?
> | 
> | Sorry for causing confusion! One of the patches [1] modified one or more
> | of the Makefile.am files. So all I did was applying all patches, run
> | "autoreconf" to apply the changes in the Makefiles and running dpatch,
> | saving the changes as 99*.
> | 
> | At least that was what I thought Steve did: He modified some autotools
> | input files, saved the patch as a single patch and saved the
> | modfications done by invoking autoreconf as 99* dpatch. So one doesn't
> | really need to care about the modifications done in the autogenerated
> | files, having the "real" changes in a seperate patch.
> | 
> | Maybe I heavily misunderstood this technique. I guess running automake
> | as part of the build process after applying the patches might work, but
> | you won't get back to pristine sources afterwards because those can't be
> | deapplied again. Or did I get something wrong here?
> 
> That's a fair point. We surely want it to be reversible. 
> 
> But let me just try to think out loud here:
> 
> 1)  debian/patches/99* modifies some .am/.ac files
I don't know if you are talking about what you want or what we have now
but the 99* is only touching the configure
( http://svn.debian.org/wsvn/pkg-openmpi/openmpi/trunk/debian/patches/99autoconf.dpatch?op=file&rev=5&sc=0 )
I updated this patch since for the new version of openmpi (just a more
recent autoconf)

The patch which is altering a Makefile.am file is
10opal_noexecstack.dpatch but as we don't launch automake (AFAIK) and
there is no patch about updated Makefile and it is not related at all to
the 99 patch.

Sylvestre