[Pkg-opennebula-devel] opennebula-4.12.3

[Olivier Berger]

Hi.

Dmitry Smirnov <onlyjob at debian.org> writes:

> On Tuesday 04 August 2015 16:35:48 Olivier Berger wrote:
>> > I'll try and manage to rebuild anyway.
>> 
>> Hmmm... actually that wasn't as easy as it seemed.
>
> Actually it is easy... See my previous email...
>
>
>> The d/changelog mentions a 4.12.3+dfsg-1 version, which suggests that
>> the upstream tarball won't suit.
>
> `uscan` is a standard way of getting upstream traballs in Debian. Lately it 
> got support for "Files-Excluded" field of "debian/copyright" and it removes 
> non-DFSG files from tarball automatically (and renames repacked tarball as 
> instructed in the "debian/watch" file). It is all in the uscan(1) man page.
> See also
>
>     https://wiki.debian.org/UscanEnhancements
>
>

OK, I see.

I hadn't checked precisely the uscan output, and this is much obvious
now. Thanks.

However, I have a doubt.

I've checked :
$ tardiff release-4.12.3.tar.gz opennebula_4.12.3+dfsg.orig.tar.gz
- src/oca/java/lib/ws-commons-util-1.0.2.jar
- src/oca/java/lib/xmlrpc-client-3.1.2.jar
- src/oca/java/lib/xmlrpc-common-3.1.2.jar
- src/sunstone/public/bower_components/datatables/media/images/Sorting icons.psd
- src/sunstone/public/bower_components/foundation/js/vendor
- src/sunstone/public/bower_components/foundation/js/vendor/fastclick.js
- src/sunstone/public/bower_components/foundation/js/vendor/jquery.cookie.js
- src/sunstone/public/bower_components/foundation/js/vendor/jquery.js
- src/sunstone/public/bower_components/foundation/js/vendor/modernizr.js
- src/sunstone/public/bower_components/foundation/js/vendor/placeholder.js
- src/sunstone/public/bower_components/no-vnc/docs/rfbproto-3.3.pdf
- src/sunstone/public/bower_components/no-vnc/docs/rfbproto-3.7.pdf
- src/sunstone/public/bower_components/no-vnc/docs/rfbproto-3.8.pdf
- src/sunstone/public/bower_components/no-vnc/include/web-socket-js/WebSocketMain.swf
- src/sunstone/public/bower_components/no-vnc/include/web-socket-js/swfobject.js

It looks to me that the Java XMLRPC stuff is DFSG free, so I'm not sure
that should be excluded from the .orig. Of course, getting rid of it at
the build first stages could help, but no before. Removing from the
.orig is only mandated in case of non-freeness.

I'm doubtful also about the rest, the "bower_components" stuff. Can you
enlighten me (I'll habe a look at the OpenNebula release file to try and
have more hints) ?

>> I can override that by changing to 4.12.3-1, but I'd like to be sure
>> whether you needed to repackage upstream's tarball because of non-free
>> elements... and for reproducibility's sake, I think it may be better to
>> have explicit rules somewhere, then (and maybe a README.source to
>> explain ?).
>
> Please go ahead if you feel it is something that needs documenting.
> However it seems that you will be describing basics of how to use `uscan` 
> which I believe do not belong to "README.source"... Maybe you could consider 
> improving wiki page about uscan?
>

That won't be necessary I think, but I'll feel more comfortable adding
some details in the README.source about the repackaging of the
Files-Excluded directive, so that there are some hints for future
(co-)maintainers.

>
>> Anyway, after that, I have another issue, with the scons scripts :-/
>> Maybe something's missing ?
>
> You need to check what you're doing (or what GBP is trying to do).
>
> I built package so many times with "pbuilder" and "debuild" that I'm quite 
> confident that Build-Depends are correct. I'm not sure what is wrong.
> It may be that "debian" directory is misplaced relative to contents of 
> extracted tarball?
>

I'll try and see how that works with pbuilder, which I don't use by
default.

Thanks for your help.

Best regards,
-- 
Olivier BERGER 
http://www-public.telecom-sudparis.eu/~berger_o/ - OpenPGP-Id: 2048R/5819D7E8
Ingenieur Recherche - Dept INF
Institut Mines-Telecom, Telecom SudParis, Evry (France)