[pkg-opensc-commit] [libp11] 60/67: Comments corrected

Eric Dorland eric at moszumanska.debian.org
Sat Jan 30 05:34:17 UTC 2016


This is an automated email from the git hooks/post-receive script.

eric pushed a commit to branch master
in repository libp11.

commit 7aca6563d59c7487e4117be6537897b8771b236d
Author: Michał Trojnara <Michal.Trojnara at stunnel.org>
Date:   Fri Jan 22 10:57:51 2016 +0100

    Comments corrected
---
 src/p11_ec.c  | 4 ++--
 src/p11_rsa.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/p11_ec.c b/src/p11_ec.c
index 7ff8159..96b1f14 100644
--- a/src/p11_ec.c
+++ b/src/p11_ec.c
@@ -173,8 +173,8 @@ static EVP_PKEY *pkcs11_get_evp_key_ec(PKCS11_KEY * key)
 
 	if (key->isPrivate)
 		ECDSA_set_method(ec, PKCS11_get_ecdsa_method());
-	/* TODO: Extract the ECDSA private key instead, if the key
-	 * is marked as extractable (and not private?) */
+	/* TODO: Retrieve the ECDSA private key object attributes instead,
+	 * unless the key has the "sensitive" attribute set */
 
 	ECDSA_set_ex_data(ec, ecdsa_ex_index, key);
 	EC_KEY_free(ec); /* drops our reference to it */
diff --git a/src/p11_rsa.c b/src/p11_rsa.c
index 32e4871..734c345 100644
--- a/src/p11_rsa.c
+++ b/src/p11_rsa.c
@@ -103,8 +103,8 @@ static EVP_PKEY *pkcs11_get_evp_key_rsa(PKCS11_KEY * key)
 
 	if (key->isPrivate)
 		RSA_set_method(rsa, PKCS11_get_rsa_method());
-	/* TODO: Extract the RSA private key instead, if the key
-	 * is marked as extractable (and not private?) */
+	/* TODO: Retrieve the RSA private key object attributes instead,
+	 * unless the key has the "sensitive" attribute set */
 
 	rsa->flags |= RSA_FLAG_SIGN_VER;
 	RSA_set_ex_data(rsa, rsa_ex_index, key);

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-opensc/libp11.git



More information about the pkg-opensc-commit mailing list