[pkg-opensc-commit] [opensc] 69/295: OpenPGP card doesn't support raw RSA so don't set such algo flag

[Eric Dorland]

This is an automated email from the git hooks/post-receive script.

eric pushed a commit to branch master
in repository opensc.

commit 3e3528bb687500a071e8c2b9bf53328b491e6467
Author: Maciej S. Szmigiero <mail at maciej.szmigiero.name>
Date:   Thu Aug 11 18:38:40 2016 +0200

    OpenPGP card doesn't support raw RSA so don't set such algo flag
    
    According to descriptions of commands "PSO: COMPUTE DIGITAL SIGNATURE",
    "PSO: DECIPHER" and "INTERNAL AUTHENTICATE" in OpenPGP card spec (versions
    1.1 and 2.1.1) the card adds / strips and checks PKCS#1 padding
    automatically.
    There is no documented way to perform raw RSA operations on this card so
    SC_ALGORITHM_RSA_RAW flag shouldn't be set.
    
    Signed-off-by: Maciej S. Szmigiero <mail at maciej.szmigiero.name>
---
 src/libopensc/card-openpgp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/libopensc/card-openpgp.c b/src/libopensc/card-openpgp.c
index ba05ac8..916b38c 100644
--- a/src/libopensc/card-openpgp.c
+++ b/src/libopensc/card-openpgp.c
@@ -569,10 +569,8 @@ pgp_get_card_features(sc_card_t *card)
 			unsigned long flags;
 
 			/* Is this correct? */
-			/* OpenPGP card spec 1.1 & 2.0, section 2.1 */
-			flags = SC_ALGORITHM_RSA_RAW;
 			/* OpenPGP card spec 1.1 & 2.0, section 7.2.9 & 7.2.10 */
-			flags |= SC_ALGORITHM_RSA_PAD_PKCS1;
+			flags = SC_ALGORITHM_RSA_PAD_PKCS1;
 			flags |= SC_ALGORITHM_RSA_HASH_NONE;
 			/* Can be generated in card */
 			flags |= SC_ALGORITHM_ONBOARD_KEY_GEN;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-opensc/opensc.git