[pkg-opensc-commit] [opensc] 170/295: pkcs11: remove redundant validation of PIN length

Eric Dorland eric at moszumanska.debian.org
Sat Jun 24 21:11:28 UTC 2017


This is an automated email from the git hooks/post-receive script.

eric pushed a commit to branch master
in repository opensc.

commit 3635dbe78a687dba032c7cccb760b6d243f08255
Author: Nuno Goncalves <nunojpg at gmail.com>
Date:   Tue Jan 31 17:37:02 2017 +0100

    pkcs11: remove redundant validation of PIN length
    
    PIN length validation is done at pkcs15 layer and shall be done only there.
    
    Signed-off-by: Nuno Goncalves <nunojpg at gmail.com>
---
 src/pkcs11/framework-pkcs15.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/pkcs11/framework-pkcs15.c b/src/pkcs11/framework-pkcs15.c
index 0c0af88..0c89d47 100644
--- a/src/pkcs11/framework-pkcs15.c
+++ b/src/pkcs11/framework-pkcs15.c
@@ -1486,10 +1486,6 @@ pkcs15_login(struct sc_pkcs11_slot *slot, CK_USER_TYPE userType,
 		if (ulPinLen == 0)
 			pPin = NULL;
 	}
-	else if (ulPinLen > pin_info->attrs.pin.max_length)   {
-		return CKR_ARGUMENTS_BAD;
-	}
-
 
 	/* By default, we make the reader resource manager keep other
 	 * processes from accessing the card while we're logged in.

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-opensc/opensc.git



More information about the pkg-opensc-commit mailing list