[Pkg-osg-devel] openscenegraph-3.3.1-1 for debian

[Alberto Luaces]

Markus Wanner writes:

> Alberto,
>
> On 05/22/2014 02:03 PM, Alberto Luaces wrote:
>> That developer release is not so far away from the stable, as you have
>> experienced
>
> I just started flightgear and checked the plain appears on the runway. I
> didn't even take off.
>

Ok, thanks for the info :)

[...]

>
>> in order to
>> see how it fits with the reverse dependencies and ease the transition
>> process, although I am fairly sure that there will be no problems with
>> that.
>
> With osg 3.3.1, simgear failed to compile with one error:
>

[...]

>
> I "solved" that by simply patching away the first constructor invocation:
>
> --- a/simgear/scene/material/EffectCullVisitor.cxx
> +++ b/simgear/scene/material/EffectCullVisitor.cxx
> @@ -40,7 +40,6 @@
>  }
>
>  EffectCullVisitor::EffectCullVisitor(const EffectCullVisitor& rhs) :
> -    osg::Referenced(rhs),
>      CullVisitor(rhs)
>  {
>  }
>
>
> This one-line-fix made simgear compile against osg 3.3.1.
>
> I'm kind of surprised this compiled, before. The documentation [0] for
> 3.2.0 states that osg::Referenced is a parent of CullVisitor. And the
> sources of current osg seem to indicate the same. Calling both
> constructors seems weird to me...
>
> From current 3.2.0~rc1 sources, the copy constructor for CullVisitor reads:
>
> CullVisitor::CullVisitor(const CullVisitor& rhs):
>     Referenced(true),
>     NodeVisitor(rhs),
>     ...
>
> I.e. it also calls *two* super-class constructors (one being the super
> class of the other). However, I didn't find a copy constructor for
> NodeVisitor at all... so maybe I'm somehow looking at the wrong files.
>
> In 3.3.1, NodeVisitor well has a copy constructor defined.
>
> Comments?

I think you are right, and both simgear and osg-3.2.1 have the same bug.
Maybe osg's one induced the other.  As you say, this is corrected on the
osg side in 3.3.1 and also on trunk.

Yesterday-released 3.2.1-rc3 is unmodified in that regard, so for now
simgear should not find any additional problems when building.

Regards,

Alberto