[Pkg-osm-maint] packaging leaflet

[David Paleino]

On Sat, 17 Sep 2011 16:53:59 +1000, Andrew Harvey wrote:

> Hi,

Hello Andrew,

> I've uploaded my attempt at packaging leaflet for Debian and created a
> bug against WNPP.
> 
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=641883

You should've filed an ITP, not an RFP. You can fix that by running:

 $ bts retitle 641883 ITP: libjs-leaflet -- JavaScript library [..]

> http://mentors.debian.net/package/leaflet

- You should add yourself to Uploaders in debian/control

- You Build-Depend on debhelper >= 8, but debian/compat is 7. Please fix this :)

- Vcs-* fields are for Debian packaging, not the upstream repositories. Both
  should read something like this, when you'll push the repo to pkg-osm:

    Vcs-Git: git://git.debian.org/pkg-osm/leaflet.git
    Vcs-Browser: http://git.debian.org/?p=pkg-osm/leaflet.git

- debian/copyright: it should be cleaner if you state a common "License: BSD-2"
  stanza with the whole text, so that you don't repeat it twice :). But it's a
  minor problem, it's fine also this way.

- why is debian/rules under GPL-2+, if the debian packaging is BSD-2 ? This is
  a bit confusing. If you're sure you want debian/rules to be under that
  license, please state it in debian/copyright.


Other than this, the package seems fine. Please fix the above issues, and I'll
recheck it.

Next time, you can create a git repository on vasks, and point to that repo --
no need to use mentors. Here's how to:

  $ ssh vasks.debian.org
  $ cd /git/pkg-osm/
  $ ./setup-repository leaflet.git "Short description found in debian/control"

Kindly,
David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-osm-maint/attachments/20110924/9b4c801e/attachment.pgp>