[pkg-otr-team] [irssi-plugin-otr] 140/167: Clean up some unused variables and a memory leak

Holger Levsen holger at moszumanska.debian.org
Mon Mar 3 21:55:39 UTC 2014


This is an automated email from the git hooks/post-receive script.

holger pushed a commit to tag 4.0.0
in repository irssi-plugin-otr.

commit f3ad0dfa2f14606e9ff763dce975b2db18702064
Author: Ian Goldberg <iang at cs.uwaterloo.ca>
Date:   Thu Jul 19 09:14:02 2012 -0400

    Clean up some unused variables and a memory leak
    
    Thanks to Paul Wouters <paul at cypherpunks.ca> for the report.
---
 gtk-dialog.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/gtk-dialog.c b/gtk-dialog.c
index dd40bcd..9047102 100644
--- a/gtk-dialog.c
+++ b/gtk-dialog.c
@@ -1436,7 +1436,6 @@ static void otrg_gtk_dialog_verify_fingerprint(Fingerprint *fprint)
 static void otrg_gtk_dialog_socialist_millionaires(ConnContext *context,
 	char *question, gboolean responder)
 {
-    GtkWidget *dialog;
     char *primary;
     PurplePlugin *p;
     char *proto_name;
@@ -1455,7 +1454,7 @@ static void otrg_gtk_dialog_socialist_millionaires(ConnContext *context,
     proto_name = (p && p->info->name) ? p->info->name : _("Unknown");
 
 
-    dialog = create_smp_dialog(_("Authenticate Buddy"),
+    create_smp_dialog(_("Authenticate Buddy"),
 	    primary, context, responder, question);
 
     g_free(primary);
@@ -2010,8 +2009,6 @@ static void build_otr_menu(ConvOrContext *convctx, GtkWidget *menu,
 	TrustLevel level)
 {
     PurpleConversation *conv;
-    PidginConversation *gtkconv;
-    PidginWindow *win;
 
     if (convctx->convctx_type == convctx_conv) {
 	conv = convctx->conv;
@@ -2021,9 +2018,6 @@ static void build_otr_menu(ConvOrContext *convctx, GtkWidget *menu,
 	return;
     }
 
-    gtkconv = PIDGIN_CONVERSATION ( conv );
-    win = pidgin_conv_get_window ( gtkconv );
-
     GtkWidget *buddymenuquery = gtk_menu_item_new_with_mnemonic(
 	    _("Start _private conversation"));
     GtkWidget *buddymenuend = gtk_menu_item_new_with_mnemonic(
@@ -2329,8 +2323,6 @@ static void otr_add_buddy_instances_top_menu(PidginConversation *gtkconv,
     ConvOrContext convctx;
     GList * menu_list;
 
-    menu = gtk_menu_new();
-
     conv = otrg_plugin_context_to_conv(context, 0);
     selection_exists = g_hash_table_lookup_extended(conv->data,
 	    "otr-ui_selected_ctx", NULL, &gp_instance);

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-otr/packages/irssi-plugin-otr.git



More information about the Pkg-otr-team mailing list