[Pkg-owncloud-commits] [owncloud] 09/75: improve mimetype detection

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to annotated tag v3.0.1
in repository owncloud.

commit e2d3585014ed757c1665c2cde8ce8d4ab7f4d948
Author: Robin Appelman <icewind1991 at gmail.com>
Date:   Sun Oct 23 11:26:54 2011 +0200

    improve mimetype detection
---
 lib/filestorage/local.php |   21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/lib/filestorage/local.php b/lib/filestorage/local.php
index 180b056..f0961c1 100644
--- a/lib/filestorage/local.php
+++ b/lib/filestorage/local.php
@@ -126,18 +126,21 @@ class OC_Filestorage_Local extends OC_Filestorage{
 
 	public function getMimeType($fspath){
 		if($this->is_readable($fspath)){
+			$mimeType='application/octet-stream';
 			if (@is_dir($this->datadir.$fspath)) {
 				// directories are easy
 				return "httpd/unix-directory";
-			}elseif (function_exists('finfo_open') and function_exists('finfo_file') and $finfo=finfo_open(FILEINFO_MIME)){
+			}
+			if($mimeType=='application/octet-stream' and function_exists('finfo_open') and function_exists('finfo_file') and $finfo=finfo_open(FILEINFO_MIME)){
 				$mimeType =strtolower(finfo_file($finfo,$this->datadir.$fspath));
 				$mimeType=substr($mimeType,0,strpos($mimeType,';'));
 				finfo_close($finfo);
-				return $mimeType;
-			} else if (function_exists("mime_content_type")) {
+			}
+			if ($mimeType=='application/octet-stream' && function_exists("mime_content_type")) {
 				// use mime magic extension if available
-				$mime_type = mime_content_type($this->datadir.$fspath);
-			} else if (OC_Helper::canExecute("file")) {
+				$mimeType = mime_content_type($this->datadir.$fspath);
+			}
+			if ($mimeType=='application/octet-stream' && OC_Helper::canExecute("file")) {
 				// it looks like we have a 'file' command,
 				// lets see it it does have mime support
 				$fp = popen("file -i -b '{$this->datadir}$fspath' 2>/dev/null", "r");
@@ -145,18 +148,18 @@ class OC_Filestorage_Local extends OC_Filestorage{
 				pclose($fp);
 
 				//trim the character set from the end of the response
-				$mime_type=substr($reply,0,strrpos($reply,' '));
+				$mimeType=substr($reply,0,strrpos($reply,' '));
 			}
-			if (empty($mime_type)) {
+			if ($mimeType=='application/octet-stream') {
 				// Fallback solution: (try to guess the type by the file extension
 				if(!self::$mimetypes){
 					self::$mimetypes=include('mimetypes.list.php');
 				}
 				$extention=strtolower(strrchr(basename($fspath), "."));
 				$extention=substr($extention,1);//remove leading .
-				$mime_type=(isset(self::$mimetypes[$extention]))?self::$mimetypes[$extention]:'application/octet-stream';
+				$mimeType=(isset(self::$mimetypes[$extention]))?self::$mimetypes[$extention]:'application/octet-stream';
 			}
-			return $mime_type;
+			return $mimeType;
 		}
 	}
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/owncloud.git