[Pkg-owncloud-commits] [owncloud] 108/239: handle duplicate slashes in case of reverse proxy configuration

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository owncloud.

commit a0a665ea459fe96a0006766cc0d0b25e5cd258df
Author: Thomas Müller <thomas.mueller at tmit.eu>
Date:   Mon Nov 25 14:21:51 2013 +0100

    handle duplicate slashes in case of reverse proxy configuration
---
 lib/private/request.php |  5 ++++-
 tests/lib/request.php   | 20 ++++++++++++++++++++
 2 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/lib/private/request.php b/lib/private/request.php
index d11e5b1..9cf09ac 100755
--- a/lib/private/request.php
+++ b/lib/private/request.php
@@ -136,7 +136,10 @@ class OC_Request {
 	 * @returns string Path info or false when not found
 	 */
 	public static function getRawPathInfo() {
-		$path_info = substr($_SERVER['REQUEST_URI'], strlen($_SERVER['SCRIPT_NAME']));
+		$requestUri = $_SERVER['REQUEST_URI'];
+		// remove too many leading slashes - can be caused by reverse proxy configuration
+		$requestUri = '/' . ltrim($requestUri, '/');
+		$path_info = substr($requestUri, strlen($_SERVER['SCRIPT_NAME']));
 		// Remove the query string from REQUEST_URI
 		if ($pos = strpos($path_info, '?')) {
 			$path_info = substr($path_info, 0, $pos);
diff --git a/tests/lib/request.php b/tests/lib/request.php
index 2b2094a..d7ccb21 100644
--- a/tests/lib/request.php
+++ b/tests/lib/request.php
@@ -23,4 +23,24 @@ class Test_Request extends PHPUnit_Framework_TestCase {
 		$scriptName = OC_Request::scriptName();
 		$this->assertEquals('/domain.tld/ownCloud/tests/lib/request.php', $scriptName);
 	}
+
+	/**
+	 * @dataProvider rawPathInfoProvider
+	 * @param $expected
+	 * @param $requestUri
+	 * @param $scriptName
+	 */
+	public function testRawPathInfo($expected, $requestUri, $scriptName) {
+		$_SERVER['REQUEST_URI'] = $requestUri;
+		$_SERVER['SCRIPT_NAME'] = $scriptName;
+		$rawPathInfo = OC_Request::getRawPathInfo();
+		$this->assertEquals($expected, $rawPathInfo);
+	}
+
+	function rawPathInfoProvider() {
+		return array(
+			array('/core/ajax/translations.php', '/index.php/core/ajax/translations.php', '/index.php'),
+			array('/core/ajax/translations.php', '//index.php/core/ajax/translations.php', '/index.php'),
+		);
+	}
 }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/owncloud.git