[Pkg-owncloud-commits] [php-sabre-vobject] 36/128: Improvements for hhvm.

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository php-sabre-vobject.

commit 2f8f96f1e6084674837f8657e9b9c4fe4517bba5
Author: Evert Pot <evert at rooftopsolutions.nl>
Date:   Wed Jan 22 00:57:07 2014 -0500

    Improvements for hhvm.
---
 lib/Sabre/VObject/Cli.php                                         | 6 +++---
 tests/Sabre/VObject/RecurrenceIteratorFifthTuesdayProblemTest.php | 6 ++++++
 tests/Sabre/VObject/RecurrenceIteratorTest.php                    | 4 ++++
 tests/Sabre/VObject/StringUtilTest.php                            | 4 ----
 4 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/lib/Sabre/VObject/Cli.php b/lib/Sabre/VObject/Cli.php
index eacc98f..9118988 100644
--- a/lib/Sabre/VObject/Cli.php
+++ b/lib/Sabre/VObject/Cli.php
@@ -102,13 +102,13 @@ class Cli {
         // We cannot easily test this, so we'll skip it. Pretty basic anyway.
 
         if (!$this->stderr) {
-            $this->stderr = STDERR;
+            $this->stderr = fopen('php://stderr','w');
         }
         if (!$this->stdout) {
-            $this->stdout = STDOUT;
+            $this->stdout = fopen('php://stdout','w');
         }
         if (!$this->stdin) {
-            $this->stdin = STDIN;
+            $this->stdin = fopen('php://stdin','r');
         }
 
         // @codeCoverageIgnoreEnd
diff --git a/tests/Sabre/VObject/RecurrenceIteratorFifthTuesdayProblemTest.php b/tests/Sabre/VObject/RecurrenceIteratorFifthTuesdayProblemTest.php
index d6bee34..f55814e 100644
--- a/tests/Sabre/VObject/RecurrenceIteratorFifthTuesdayProblemTest.php
+++ b/tests/Sabre/VObject/RecurrenceIteratorFifthTuesdayProblemTest.php
@@ -4,6 +4,12 @@ namespace Sabre\VObject;
 
 class RecurrenceIteratorFifthTuesdayProblemTest extends \PHPUnit_Framework_TestCase {
 
+    /**
+     * A pretty slow test. Had to be marked as 'medium' for phpunit to not die
+     * after 1 second. Would be good to optimize later.
+     *
+     * @medium
+     */
     function testGetDTEnd() {
 
         $ics = <<<ICS
diff --git a/tests/Sabre/VObject/RecurrenceIteratorTest.php b/tests/Sabre/VObject/RecurrenceIteratorTest.php
index 54d8ca0..8e841c3 100644
--- a/tests/Sabre/VObject/RecurrenceIteratorTest.php
+++ b/tests/Sabre/VObject/RecurrenceIteratorTest.php
@@ -792,7 +792,11 @@ class RecurrenceIteratorTest extends \PHPUnit_Framework_TestCase {
     }
 
     /**
+     * A pretty slow test. Had to be marked as 'medium' for phpunit to not die
+     * after 1 second. Would be good to optimize later.
+     *
      * @depends testValues
+     * @medium
      */
     function testMonthlyByDay() {
 
diff --git a/tests/Sabre/VObject/StringUtilTest.php b/tests/Sabre/VObject/StringUtilTest.php
index 7d062ac..8e0bc48 100644
--- a/tests/Sabre/VObject/StringUtilTest.php
+++ b/tests/Sabre/VObject/StringUtilTest.php
@@ -52,8 +52,4 @@ class StringUtilTest extends \PHPUnit_Framework_TestCase {
 
     }
 
-      
-
-
-
 }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/php-sabre-vobject.git