[Pkg-owncloud-commits] [owncloud-client] 14/70: Shib: remove slotLoadFinished() from webview dtor

Sandro Knauß hefee-guest at moszumanska.debian.org
Tue Jul 1 10:21:18 UTC 2014


This is an automated email from the git hooks/post-receive script.

hefee-guest pushed a commit to branch master
in repository owncloud-client.

commit b2966fecc7a610ea4df81cd9eaed4bf234c5587a
Author: Daniel Molkentin <danimo at owncloud.com>
Date:   Sat Jun 14 02:56:12 2014 +0200

    Shib: remove slotLoadFinished() from webview dtor
    
    This is a relict from when the webview was reused.
    It is now pointless, since it's now destruct-on-close.
---
 src/creds/shibboleth/shibbolethwebview.cpp | 1 -
 src/creds/shibboleth/shibbolethwebview.h   | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/creds/shibboleth/shibbolethwebview.cpp b/src/creds/shibboleth/shibbolethwebview.cpp
index f4948b0..c641d22 100644
--- a/src/creds/shibboleth/shibbolethwebview.cpp
+++ b/src/creds/shibboleth/shibbolethwebview.cpp
@@ -65,7 +65,6 @@ ShibbolethWebView::ShibbolethWebView(Account* account, QWidget* parent)
 
 ShibbolethWebView::~ShibbolethWebView()
 {
-    slotLoadFinished();
 }
 
 void ShibbolethWebView::onNewCookiesForUrl (const QList<QNetworkCookie>& cookieList, const QUrl& url)
diff --git a/src/creds/shibboleth/shibbolethwebview.h b/src/creds/shibboleth/shibbolethwebview.h
index c002e7e..1999dfd 100644
--- a/src/creds/shibboleth/shibbolethwebview.h
+++ b/src/creds/shibboleth/shibbolethwebview.h
@@ -46,7 +46,7 @@ Q_SIGNALS:
 private Q_SLOTS:
   void onNewCookiesForUrl(const QList<QNetworkCookie>& cookieList, const QUrl& url);
   void slotLoadStarted();
-  void slotLoadFinished(bool success = true);
+  void slotLoadFinished(bool success);
   void slotHandleAuthentication(QNetworkReply*,QAuthenticator*);
 
 protected:

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/owncloud-client.git



More information about the Pkg-owncloud-commits mailing list