[Pkg-owncloud-commits] [owncloud-client] 31/70: csync_owncloud_recursive_propfind: "fix" possible memory leak

[Sandro Knauß]

This is an automated email from the git hooks/post-receive script.

hefee-guest pushed a commit to branch master
in repository owncloud-client.

commit 5225fe07e0dff8c48e3707f3046fc37ab7c74ae7
Author: Olivier Goffart <ogoffart at woboq.com>
Date:   Fri Jun 20 11:10:55 2014 +0200

    csync_owncloud_recursive_propfind: "fix" possible memory leak
    
    This was only leaking memory if ne_path_parent returns 0, which
    should never happen
    
    This fixes coverity issue 12897
---
 csync/src/csync_owncloud_recursive_propfind.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/csync/src/csync_owncloud_recursive_propfind.c b/csync/src/csync_owncloud_recursive_propfind.c
index 29abd19..f7319d5 100644
--- a/csync/src/csync_owncloud_recursive_propfind.c
+++ b/csync/src/csync_owncloud_recursive_propfind.c
@@ -236,13 +236,12 @@ static void propfind_results_recursive(void *userdata,
             }
 
             /* DEBUG_WEBDAV("results_recursive Added child %s to collection %s", newres->uri, element->self->uri); */
-        } else {
-            /* DEBUG_WEBDAV("results_recursive No parent %s found for child %s", parentPath, newres->uri); */
-            resource_free(newres);
-            newres = NULL;
+            return;
         }
     }
 
+    resource_free(newres);
+    newres = NULL;
 }
 
 void fetch_resource_list_recursive(const char *uri, const char *curi)

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/owncloud-client.git