[Pkg-owncloud-commits] [owncloud-client] 39/70: accountsettings: silent coverity warning 12884

Sandro Knauß hefee-guest at moszumanska.debian.org
Tue Jul 1 10:21:21 UTC 2014


This is an automated email from the git hooks/post-receive script.

hefee-guest pushed a commit to branch master
in repository owncloud-client.

commit 61ad376bf44723892a9ac659c83b7f43e6e00c60
Author: Olivier Goffart <ogoffart at woboq.com>
Date:   Fri Jun 20 11:39:48 2014 +0200

    accountsettings: silent coverity warning 12884
    
    We use f anyway, so if we are going to test if it's null we can as
    well return
---
 src/mirall/accountsettings.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/mirall/accountsettings.cpp b/src/mirall/accountsettings.cpp
index 6ab4044..e0e60d1 100644
--- a/src/mirall/accountsettings.cpp
+++ b/src/mirall/accountsettings.cpp
@@ -432,7 +432,11 @@ void AccountSettings::slotEnableCurrentFolder()
 
             // this sets the folder status to disabled but does not interrupt it.
             Folder *f = folderMan->folder( alias );
-            if( f && folderEnabled ) {
+            if (!f) {
+                return;
+            }
+
+            if( folderEnabled ) {
                 // check if a sync is still running and if so, ask if we should terminate.
                 if( f->isBusy() ) { // its still running
 #if defined(Q_OS_MAC)

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/owncloud-client.git



More information about the Pkg-owncloud-commits mailing list