[Pkg-owncloud-commits] [owncloud] 03/14: Remove uneeded `strip_tags`

David Prévot taffit at moszumanska.debian.org
Wed Jul 23 16:23:07 UTC 2014


This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository owncloud.

commit a393670f7d4bf6cc31356e0023554133266a823d
Author: Lukas Reschke <lukas at statuscode.ch>
Date:   Sat Jul 19 10:17:24 2014 +0200

    Remove uneeded `strip_tags`
    
    This `strip_tags` seems to be completely unneeded and will cause problems with passwords containing stripped characters. (e.g. `<` or `>`)
    
    Needs https://github.com/owncloud/core/pull/9735 to be merged first.
---
 lib/base.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/base.php b/lib/base.php
index 2438161..730cee5 100644
--- a/lib/base.php
+++ b/lib/base.php
@@ -807,8 +807,8 @@ class OC {
 		foreach ($vars as $var) {
 			if (isset($_SERVER[$var]) && preg_match('/Basic\s+(.*)$/i', $_SERVER[$var], $matches)) {
 				list($name, $password) = explode(':', base64_decode($matches[1]), 2);
-				$_SERVER['PHP_AUTH_USER'] = strip_tags($name);
-				$_SERVER['PHP_AUTH_PW'] = strip_tags($password);
+				$_SERVER['PHP_AUTH_USER'] = $name;
+				$_SERVER['PHP_AUTH_PW'] = $password;
 				break;
 			}
 		}

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/owncloud.git



More information about the Pkg-owncloud-commits mailing list