[Pkg-owncloud-commits] [owncloud] 74/258: Remove passing by reference to allow for proper GC

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository owncloud.

commit 7f1416e62aab248c6c69f72bafc91cb39d835fa5
Author: Vincent Petry <pvince81 at owncloud.com>
Date:   Fri Sep 12 19:51:47 2014 +0200

    Remove passing by reference to allow for proper GC
    
    The garbage collector in PHP 5.3.10 does not properly release the file
    handle when calling fclose() due to the fact that it is passed by
    reference.
    This has the side-effect of preventing file locks to be released as well
    when the files_locking app is enabled.
    
    This fix removes the useless passing by reference and now the file
    handle and file lock are freed properly.
---
 apps/files_encryption/lib/proxy.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/files_encryption/lib/proxy.php b/apps/files_encryption/lib/proxy.php
index b1af467..62621f3 100644
--- a/apps/files_encryption/lib/proxy.php
+++ b/apps/files_encryption/lib/proxy.php
@@ -262,7 +262,7 @@ class Proxy extends \OC_FileProxy {
 	 * @param resource $result
 	 * @return resource
 	 */
-	public function postFopen($path, &$result) {
+	public function postFopen($path, $result) {
 
 		$path = \OC\Files\Filesystem::normalizePath($path);
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/owncloud.git