[Pkg-owncloud-commits] [owncloud-client] 66/164: Remove mention of allprop #2865

[Sandro Knauß]

This is an automated email from the git hooks/post-receive script.

hefee-guest pushed a commit to branch master
in repository owncloud-client.

commit c8167b77c9a27910135ae143d2074371e353a98f
Author: Christian Kamm <kamm at incasoftware.de>
Date:   Thu Feb 26 12:36:11 2015 +0100

    Remove mention of allprop #2865
---
 src/gui/socketapi.h         |  1 -
 src/libsync/networkjobs.cpp |  2 +-
 src/libsync/networkjobs.h   | 11 +++++++++++
 3 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/gui/socketapi.h b/src/gui/socketapi.h
index 8bc21ca..45fdb8a 100644
--- a/src/gui/socketapi.h
+++ b/src/gui/socketapi.h
@@ -70,7 +70,6 @@ private slots:
 private:
     SyncFileStatus fileStatus(Folder *folder, const QString& systemFileName, c_strlist_t *excludes );
     SyncJournalFileRecord dbFileRecord_capi( Folder *folder, QString fileName );
-    SyncFileStatus recursiveFolderStatus(Folder *folder, const QString& fileName, c_strlist_t *excludes  );
     SqlQuery *getSqlQuery( Folder *folder );
 
     void sendMessage(SocketType* socket, const QString& message, bool doWait = false);
diff --git a/src/libsync/networkjobs.cpp b/src/libsync/networkjobs.cpp
index 876926e..c8bab2c 100644
--- a/src/libsync/networkjobs.cpp
+++ b/src/libsync/networkjobs.cpp
@@ -575,7 +575,7 @@ void PropfindJob::start()
     QList<QByteArray> properties = _properties;
 
     if (properties.isEmpty()) {
-        properties << "allprop";
+        qWarning() << "Propfind with no properties!";
     }
     QNetworkRequest req;
     req.setRawHeader("Depth", "0");
diff --git a/src/libsync/networkjobs.h b/src/libsync/networkjobs.h
index 8c7fa56..73ee08b 100644
--- a/src/libsync/networkjobs.h
+++ b/src/libsync/networkjobs.h
@@ -148,12 +148,23 @@ private slots:
 
 /**
  * @brief The PropfindJob class
+ *
+ * Setting the desired properties with setProperties() is mandatory.
  */
 class PropfindJob : public AbstractNetworkJob {
     Q_OBJECT
 public:
     explicit PropfindJob(AccountPtr account, const QString &path, QObject *parent = 0);
     void start() Q_DECL_OVERRIDE;
+
+    /**
+     * Used to specify which properties shall be retrieved.
+     *
+     * The properties can
+     *  - contain no colon: they refer to a property in the DAV: namespace
+     *  - contain a colon: and thus specify an explicit namespace,
+     *    e.g. "ns:with:colons:bar", which is "bar" in the "ns:with:colons" namespace
+     */
     void setProperties(QList<QByteArray> properties);
     QList<QByteArray> properties() const;
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/owncloud-client.git