[Pkg-owncloud-commits] [owncloud] 93/165: Deprecate unused `\OCP\Response::sendFile`

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch stable8
in repository owncloud.

commit f672e120fc7423aacca2f2ae285eb202974646a6
Author: Lukas Reschke <lukas at owncloud.com>
Date:   Wed Apr 15 10:25:07 2015 +0200

    Deprecate unused `\OCP\Response::sendFile`
    
    This function is unused in our own code and can be better achieved using the AppFramework. Also very easy to do grave mistaked using this function.
---
 lib/private/response.php | 7 ++++---
 lib/public/response.php  | 2 ++
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/lib/private/response.php b/lib/private/response.php
index 018c44d..b75f11e 100644
--- a/lib/private/response.php
+++ b/lib/private/response.php
@@ -212,9 +212,10 @@ class OC_Response {
 	}
 
 	/**
-	* Send file as response, checking and setting caching headers
-	* @param string $filepath of file to send
-	*/
+	 * Send file as response, checking and setting caching headers
+	 * @param string $filepath of file to send
+	 * @deprecated Use \OCP\AppFramework\Http\StreamResponse or another AppFramework controller instead
+	 */
 	static public function sendFile($filepath) {
 		$fp = fopen($filepath, 'rb');
 		if ($fp) {
diff --git a/lib/public/response.php b/lib/public/response.php
index 1942c1e..ac27f3e 100644
--- a/lib/public/response.php
+++ b/lib/public/response.php
@@ -37,6 +37,7 @@ namespace OCP;
 /**
  * This class provides convenient functions to send the correct http response headers
  * @since 4.0.0
+ * @deprecated Use AppFramework controllers instead and modify the response object
  */
 class Response {
 	/**
@@ -103,6 +104,7 @@ class Response {
 	 * Send file as response, checking and setting caching headers
 	 * @param string $filepath of file to send
 	 * @since 4.0.0
+	 * @deprecated Use \OCP\AppFramework\Http\StreamResponse or another AppFramework controller instead
 	 */
 	static public function sendFile( $filepath ) {
 		\OC_Response::sendFile( $filepath );

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/owncloud.git