[Pkg-owncloud-commits] [owncloud-client] 226/498: Propagation: Make 503 a fatal error.

[Sandro Knauß]

This is an automated email from the git hooks/post-receive script.

hefee-guest pushed a commit to branch master
in repository owncloud-client.

commit 2d08e02dda6fe5eb014a4505958dfcfce6030833
Author: Christian Kamm <kamm at incasoftware.de>
Date:   Wed Jul 1 13:57:34 2015 +0200

    Propagation: Make 503 a fatal error.
    
    Running further propagation jobs when the server is likely to be
    503 for a time does not seem very useful.
---
 src/libsync/owncloudpropagator_p.h | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/libsync/owncloudpropagator_p.h b/src/libsync/owncloudpropagator_p.h
index 14e8f17..4fb0953 100644
--- a/src/libsync/owncloudpropagator_p.h
+++ b/src/libsync/owncloudpropagator_p.h
@@ -52,11 +52,17 @@ inline QByteArray getEtagFromReply(QNetworkReply *reply)
 inline SyncFileItem::Status classifyError(QNetworkReply::NetworkError nerror, int httpCode) {
     Q_ASSERT (nerror != QNetworkReply::NoError); // we should only be called when there is an error
 
-    if (nerror > QNetworkReply::NoError &&  nerror <= QNetworkReply::UnknownProxyError) {
+    if (nerror > QNetworkReply::NoError && nerror <= QNetworkReply::UnknownProxyError) {
         // network error or proxy error -> fatal
         return SyncFileItem::FatalError;
     }
 
+    if (httpCode == 503) {
+        // "Service unavailable"
+        // Happens for maintenance mode and other temporary outages
+        return SyncFileItem::FatalError;
+    }
+
     if (httpCode == 412) {
         // "Precondition Failed"
         // Happens when the e-tag has changed

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/owncloud-client.git