[Pkg-owncloud-commits] [owncloud-client] 237/470: Cleanup after the SyncFileStatusTracker change

[Sandro Knauß]

This is an automated email from the git hooks/post-receive script.

hefee-guest pushed a commit to branch master
in repository owncloud-client.

commit fbf23b6abbedc32ab99792ac96f44065990a1258
Author: Jocelyn Turcotte <jturcotte at woboq.com>
Date:   Tue Mar 29 17:39:30 2016 +0200

    Cleanup after the SyncFileStatusTracker change
    
    - Add missing explicit keywords
    - Add doc
    - Comment out verbose and partly redundant qDebug statements
---
 src/gui/socketapi.h                   | 2 +-
 src/libsync/syncfilestatustracker.cpp | 6 +++---
 src/libsync/syncfilestatustracker.h   | 7 ++++++-
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/gui/socketapi.h b/src/gui/socketapi.h
index e3f1e48..763ca26 100644
--- a/src/gui/socketapi.h
+++ b/src/gui/socketapi.h
@@ -45,7 +45,7 @@ class SocketApi : public QObject
 Q_OBJECT
 
 public:
-    SocketApi(QObject* parent = 0);
+    explicit SocketApi(QObject* parent = 0);
     virtual ~SocketApi();
 
 public slots:
diff --git a/src/libsync/syncfilestatustracker.cpp b/src/libsync/syncfilestatustracker.cpp
index 79dbf16..dd59a59 100644
--- a/src/libsync/syncfilestatustracker.cpp
+++ b/src/libsync/syncfilestatustracker.cpp
@@ -25,7 +25,7 @@ static SyncFileStatus::SyncFileStatusTag lookupProblem(const QString &pathToMatc
     for (auto it = lower; it != problemMap.cend(); ++it) {
         const QString &problemPath = it->first;
         SyncFileStatus::SyncFileStatusTag severity = it->second;
-        qDebug() << Q_FUNC_INFO << pathToMatch << severity << problemPath;
+        // qDebug() << Q_FUNC_INFO << pathToMatch << severity << problemPath;
         if (problemPath == pathToMatch)
             return severity;
         else if (severity == SyncFileStatus::StatusError && problemPath.startsWith(pathToMatch))
@@ -103,7 +103,7 @@ void SyncFileStatusTracker::slotAboutToPropagate(SyncFileItemVector& items)
     std::swap(_syncProblems, oldProblems);
 
     foreach (const SyncFileItemPtr &item, items) {
-        qDebug() << Q_FUNC_INFO << "Investigating" << item->destination() << item->_status;
+        // qDebug() << Q_FUNC_INFO << "Investigating" << item->destination() << item->_status;
 
         if (showErrorInSocketApi(*item))
             _syncProblems[item->_file] = SyncFileStatus::StatusError;
@@ -134,7 +134,7 @@ void SyncFileStatusTracker::slotAboutToPropagate(SyncFileItemVector& items)
 
 void SyncFileStatusTracker::slotItemCompleted(const SyncFileItem &item)
 {
-    qDebug() << Q_FUNC_INFO << item.destination() << item._status;
+    // qDebug() << Q_FUNC_INFO << item.destination() << item._status;
 
     if (showErrorInSocketApi(item)) {
         _syncProblems[item._file] = SyncFileStatus::StatusError;
diff --git a/src/libsync/syncfilestatustracker.h b/src/libsync/syncfilestatustracker.h
index cdf6133..a6ae1b3 100644
--- a/src/libsync/syncfilestatustracker.h
+++ b/src/libsync/syncfilestatustracker.h
@@ -24,11 +24,16 @@ namespace OCC {
 
 class SyncEngine;
 
+/**
+ * @brief Takes care of tracking the status of individual files as they
+ *        go through the SyncEngine, to be reported as overlay icons in the shell.
+ * @ingroup libsync
+ */
 class OWNCLOUDSYNC_EXPORT SyncFileStatusTracker : public QObject
 {
     Q_OBJECT
 public:
-    SyncFileStatusTracker(SyncEngine* syncEngine);
+    explicit SyncFileStatusTracker(SyncEngine* syncEngine);
     SyncFileStatus fileStatus(const QString& systemFileName);
 
 signals:

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/owncloud-client.git