[Pkg-owncloud-commits] [owncloud-client] 257/470: Fix invalid read on account removal

[Sandro Knauß]

This is an automated email from the git hooks/post-receive script.

hefee-guest pushed a commit to branch master
in repository owncloud-client.

commit e05819370b9e42c8e12674e532cae5f71eb7751e
Author: Christian Kamm <mail at ckamm.de>
Date:   Thu Mar 31 08:56:26 2016 +0200

    Fix invalid read on account removal
---
 src/gui/settingsdialog.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/gui/settingsdialog.cpp b/src/gui/settingsdialog.cpp
index abe9c92..8da902c 100644
--- a/src/gui/settingsdialog.cpp
+++ b/src/gui/settingsdialog.cpp
@@ -222,13 +222,13 @@ void SettingsDialog::accountRemoved(AccountState *s)
         if (as->accountsState() == s) {
             _toolBar->removeAction(it.key());
 
-            it.key()->deleteLater();
-            it.value()->deleteLater();
-            _actionGroupWidgets.erase(it);
-
             if (_ui->stack->currentWidget() == it.value()) {
                 showFirstPage();
             }
+
+            it.key()->deleteLater();
+            it.value()->deleteLater();
+            _actionGroupWidgets.erase(it);
             break;
         }
     }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/owncloud-client.git