[Pkg-owncloud-commits] [owncloud-client] 26/94: Fix potential crash in Composite job destruction

[Sandro Knauß]

This is an automated email from the git hooks/post-receive script.

hefee pushed a commit to branch upstream
in repository owncloud-client.

commit 883deb1c5d404c37bb70ecd562e847fc32cdcf53
Author: Christian Kamm <mail at ckamm.de>
Date:   Tue Jan 9 12:28:06 2018 +0100

    Fix potential crash in Composite job destruction
    
    Sentry:
    https://sentry.io/owncloud/desktop-win-and-mac/issues/427476987/
---
 src/libsync/owncloudpropagator.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/libsync/owncloudpropagator.h b/src/libsync/owncloudpropagator.h
index 9655e1a..1ab653d 100644
--- a/src/libsync/owncloudpropagator.h
+++ b/src/libsync/owncloudpropagator.h
@@ -210,8 +210,9 @@ public:
 
     virtual ~PropagatorCompositeJob()
     {
-        qDeleteAll(_jobsToDo);
-        qDeleteAll(_runningJobs);
+        // Don't delete jobs in _jobsToDo and _runningJobs: they have parents
+        // that will be responsible for cleanup. Deleting them here would risk
+        // deleting something that has already been deleted by a shared parent.
     }
 
     void appendJob(PropagatorJob *job)

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/owncloud-client.git