[Pkg-pdns-maintainers] Bug#798773: postinst script handles comments in config file incorrectly

[Stephen Frost]

Christian,

Thanks for the quick reply!

* Christian Hofstaedtler (zeha at debian.org) wrote:
> * Stephen Frost <sfrost at snowman.net> [151005 22:57]:
> > Any chance we could get this bug fixed?  Looks like a pretty
> > straight-forward change.
> 
> Only on the surface it's a straight-forward change. When you look
> closer at the postinst code, I'm quite sure the code only works when
> the config var hasn't been changed from the default.
> (Or it does work, but you end up with ucf hijacking files the
> package doesn't ship.)

Looking at the postinst code, I think I see what you mean.

That said, I do think it's worthwhile to see about fixing these
particular install failures, and the proposed change looks like it would
at least do that.

> > Is there anything I can do to help?
> 
> I'm thinking of deleting most of the code in the postinst for
> stretch.

Are you thinking about simply assuming that /etc/powerdns/pdns.d is the
PDNSDIR and anything else is up to the user to address?

> Not sure what to do about jessie. Given that this bug has existed
> since 2006, maybe it's not terribly important to fix in jessie.

I disagree.  Perhaps I'm being naive, but having the relatively simple
case, where /etc/powerdns/pdns.d is the directory and the configuration
has been only mildly tweaked, failure during upgrades is not a good
position for us to be in.

I have to admit that I'm not up to speed on current policy, but I'm
happy to try and implement whatever the correct solution is.  I'm sure
there are other packages which have include directories, is there a
clear "right way" to handle this?

Thanks!

Stephen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-pdns-maintainers/attachments/20151005/88a5cd95/attachment.sig>