[Pkg-pdns-maintainers] Bug#798773: postinst script handles comments in config file incorrectly

[Christian Hofstaedtler]

Control: severity -1 serious

* Stephen Frost <sfrost at snowman.net> [151006 15:06]:
> > I was going to write which users are affected by this bug, but now
> > that I think more about it, I'm not sure which users are affected.
> > As you have some interest, I assume you have run into the bug? How
> > did your configuration look like?
> 
> Yes, I did run into this bug while upgrading the hidden PowerDNS master
> for postgresql.org.  The configuration we have is relatively simple.  My
> recollection of how it happened is:
> 
> Installed an older version (3.4.1?), modified /etc/powerdns/pdns.conf
> with a few simple changes- allow-axfr-ips, master=yes, slave=yes, etc.
> 
> Then at some point down the road, attempted to upgrade to 3.4.6 (in
> jessie backports), and it blew up on that error.  To fix it, I recall
> modifying pdns.conf *and* pdns.conf.ucf-dist.  It's possible I didn't
> have to change both, but I think I tried changing pdns.conf first and it
> didn't help, so I changed pdns.conf.ucf-dist also and that got me past
> the issue.  Apologies for not having more detailed notes, I was a bit
> anxious to get it fixed. :)

I think the multiple upgrades are what causes this really.

pdns.conf as installed by the wheezy version will only have a single
line matching "include=...", where 3.4.x will have multiple lines,
like this:

# include-dir   Include *.conf files from this directory
# include-dir=/etc/powerdns/pdns.conf.d

$ grep include foo.conf | awk -F '=' '{print $2}'

/etc/powerdns/pdns.conf.d
$

Therefore I think most users doing the wheezy -> jessie upgrade are
off fine.

(Security) Updates in jessie and updates jessie -> stretch will fail.

> I'll see about building a test jessie VM, installing the version in
> jessie, modifying the config, and then doing an upgrade, and see if I
> can reproduce the error.

Appreciated.

-- 
 ,''`.  Christian Hofstaedtler <zeha at debian.org>
: :' :  Debian Developer
`. `'   7D1A CFFA D9E0 806C 9C4C  D392 5C13 D6DB 9305 2E03
  `-

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-pdns-maintainers/attachments/20151006/b61691d6/attachment.sig>