r2407 - in packages/libspreadsheet-parseexcel-perl/trunk/debian: . patches

[Niko Tyni]

Author: ntyni-guest
Date: 2006-03-17 21:31:30 +0000 (Fri, 17 Mar 2006)
New Revision: 2407

Removed:
   packages/libspreadsheet-parseexcel-perl/trunk/debian/README.Debian
   packages/libspreadsheet-parseexcel-perl/trunk/debian/patches/40numeric.dpatch
Modified:
   packages/libspreadsheet-parseexcel-perl/trunk/debian/changelog
   packages/libspreadsheet-parseexcel-perl/trunk/debian/patches/00list
Log:
Revert the 'annoying numeric overload' patch, it's a 'wontfix'.


Deleted: packages/libspreadsheet-parseexcel-perl/trunk/debian/README.Debian
===================================================================
--- packages/libspreadsheet-parseexcel-perl/trunk/debian/README.Debian	2006-03-17 20:49:57 UTC (rev 2406)
+++ packages/libspreadsheet-parseexcel-perl/trunk/debian/README.Debian	2006-03-17 21:31:30 UTC (rev 2407)
@@ -1,24 +0,0 @@
-Spreadsheet::ParseExcel for Debian
-
-This version of Spreadsheet::ParseExcel has a minor API
-incompatibility with the CPAN version. Originally an object of the
-'Spreadsheet::ParseExcel::Worksheet' class would evaluate to the sheet
-index when used in a numeric context.
-
-This feature was undocumented and unintuitive, since it broke
-eg. the common Perl idiom 
-
-  my $sheet = $book->Worksheet(0) or die ...;
-
-and made the statements
-
-  if($book->Worksheet($name)) 
-  if(defined $book->Worksheet($name))
-
-not equivalent.
-
-For these reasons, the numeric overload has been dropped in the
-Debian version of this module. The issue is described in the
-CPAN bug tracker, bug 14278.
-
-Thu, 19 Jan 2006 23:07:47 +0200 Niko Tyni <ntyni at iki.fi>

Modified: packages/libspreadsheet-parseexcel-perl/trunk/debian/changelog
===================================================================
--- packages/libspreadsheet-parseexcel-perl/trunk/debian/changelog	2006-03-17 20:49:57 UTC (rev 2406)
+++ packages/libspreadsheet-parseexcel-perl/trunk/debian/changelog	2006-03-17 21:31:30 UTC (rev 2407)
@@ -8,9 +8,6 @@
   * debian/patches:
     + 30rstring.dpatch: handle UTF16-encoded strings in the 'RSTRING' 
       opcode, just like in 'STRING'. (Closes: #299870)
-    + 40numeric.dpatch: API change: remove the numeric overload in 
-      Spreadsheet::ParseExcel::Worksheet. See README.Debian.
-      (Closes: #213231)
 
  -- Niko Tyni <ntyni at iki.fi>  Thu, 19 Jan 2006 22:43:32 +0200
 

Modified: packages/libspreadsheet-parseexcel-perl/trunk/debian/patches/00list
===================================================================
--- packages/libspreadsheet-parseexcel-perl/trunk/debian/patches/00list	2006-03-17 20:49:57 UTC (rev 2406)
+++ packages/libspreadsheet-parseexcel-perl/trunk/debian/patches/00list	2006-03-17 21:31:30 UTC (rev 2407)
@@ -1,4 +1,3 @@
 10objref.dpatch
 20general.dpatch
 30rstring.dpatch
-40numeric.dpatch

Deleted: packages/libspreadsheet-parseexcel-perl/trunk/debian/patches/40numeric.dpatch
===================================================================
--- packages/libspreadsheet-parseexcel-perl/trunk/debian/patches/40numeric.dpatch	2006-03-17 20:49:57 UTC (rev 2406)
+++ packages/libspreadsheet-parseexcel-perl/trunk/debian/patches/40numeric.dpatch	2006-03-17 21:31:30 UTC (rev 2407)
@@ -1,51 +0,0 @@
-#! /bin/sh /usr/share/dpatch/dpatch-run
-## 40numeric.dpatch by Niko Tyni <ntyni at iki.fi>
-##
-## All lines beginning with `## DP:' are a description of the patch.
-## DP: Remove the unintuitive numeric overload in 
-## DP: Spreadsheet::ParseExcel::Worksheet. Note that this is an API
-## DP: change. (#231231)
-
- at DPATCH@
-diff -urNad trunk~/ParseExcel.pm trunk/ParseExcel.pm
---- trunk~/ParseExcel.pm	2006-01-19 22:55:39.221432044 +0200
-+++ trunk/ParseExcel.pm	2006-01-19 23:02:48.337801950 +0200
-@@ -57,10 +57,6 @@
- require Exporter;
- use strict;
- sub sheetNo($);
--use overload 
--    '0+'        => \&sheetNo,
--    'fallback'  => 1,
--;
- use vars qw($VERSION @ISA);
- @ISA = qw(Exporter);
- sub new($%) {
-@@ -2177,6 +2173,14 @@
- 
- I<Spreadsheet::ParseExcel::Worksheet>
- 
-+Debian-specific note: in the original CPAN version
-+this class has a numeric overload so that evaluating a
-+I<Spreadsheet::ParseExcel::Worksheet> object in numeric
-+context results in its index value (I<SheetNo>). This overload
-+has been removed in the Debian version of this module. See
-+/usr/share/doc/libspreadsheet-parseexcel-perl/README.Debian for more
-+information.
-+
- Worksheet class has these methods:
- 
- =over 4
-@@ -2617,6 +2621,12 @@
- (maybe [Tool]-[Option]-[Calculation] or something)
- You will see the same result.
- 
-+=head1 NOTE
-+
-+The Debian version of this module has a minor API incompatibility with
-+the CPAN version. See the I<Spreadsheet::ParseExcel::Worksheet> class
-+documentation above.
-+
- =head1 AUTHOR
- 
- Kawai Takanori (Hippo2000) kwitknr at cpan.org