r3934 - in /packages/libvorbis-perl/trunk: Vorbis.xs debian/changelog debian/rules

[ntyni-guest at users.alioth.debian.org]

Author: ntyni-guest
Date: Tue Sep 26 18:30:34 2006
New Revision: 3934

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=3934
Log:
Add fix for double frees (#389571)

Modified:
    packages/libvorbis-perl/trunk/Vorbis.xs
    packages/libvorbis-perl/trunk/debian/changelog
    packages/libvorbis-perl/trunk/debian/rules

Modified: packages/libvorbis-perl/trunk/Vorbis.xs
URL: http://svn.debian.org/wsvn/pkg-perl/packages/libvorbis-perl/trunk/Vorbis.xs?rev=3934&op=diff
==============================================================================
--- packages/libvorbis-perl/trunk/Vorbis.xs (original)
+++ packages/libvorbis-perl/trunk/Vorbis.xs Tue Sep 26 18:30:34 2006
@@ -62,8 +62,13 @@
         char *initial
         long ibytes
         CODE:
+	FILE *dupfile;
+	/* dup the file so that ov_clear() can close it behind 
+	   Perl's back (Debian bug #389571) */ 
+	dupfile = fdopen(dup(fileno(file)), "r");
+
         /* we swapped file and self for an OO interface */
-        RETVAL = ov_open(file, self, initial, ibytes);
+        RETVAL = ov_open(dupfile, self, initial, ibytes);
         OUTPUT:
         RETVAL
 

Modified: packages/libvorbis-perl/trunk/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/packages/libvorbis-perl/trunk/debian/changelog?rev=3934&op=diff
==============================================================================
--- packages/libvorbis-perl/trunk/debian/changelog (original)
+++ packages/libvorbis-perl/trunk/debian/changelog Tue Sep 26 18:30:34 2006
@@ -7,8 +7,11 @@
     + support DEB_BUILD_OPTIONS=nostrip,noopt
     + don't ignore the result code of 'make clean'.
     + install the manual page with the .3pm extension, as per policy.
+    + run 'make test' at build time.
+  * Duplicate the ogg file handle before passing it to libvorbisfile,
+    to avoid double frees at close time. (Closes: #389571)
 
- -- Niko Tyni <ntyni at iki.fi>  Tue, 26 Sep 2006 14:07:39 +0300
+ -- Niko Tyni <ntyni at iki.fi>  Tue, 26 Sep 2006 21:28:44 +0300
 
 libvorbis-perl (0.05-2) unstable; urgency=low
 

Modified: packages/libvorbis-perl/trunk/debian/rules
URL: http://svn.debian.org/wsvn/pkg-perl/packages/libvorbis-perl/trunk/debian/rules?rev=3934&op=diff
==============================================================================
--- packages/libvorbis-perl/trunk/debian/rules (original)
+++ packages/libvorbis-perl/trunk/debian/rules Tue Sep 26 18:30:34 2006
@@ -46,8 +46,9 @@
 	dh_clean -k
 	dh_installdirs
 
-	# Commands to install the package into debian/libvorbis-perl.
-	# some cleanup of manpage names
+	$(MAKE) test
+
+	# Install the package into debian/libvorbis-perl.
 	$(MAKE) install PREFIX=$(TMP)/usr
 
 	# This module includes a program that depends on the Ao module, which