r11736 - in /trunk/libcurses-ui-perl/debian: changelog control patches/ patches/checkbox-hierarchy-doc patches/checkbox-toggle-boolean patches/series rules
rra at users.alioth.debian.org
rra at users.alioth.debian.org
Wed Dec 26 23:22:46 UTC 2007
Author: rra
Date: Wed Dec 26 23:22:45 2007
New Revision: 11736
URL: http://svn.debian.org/wsvn/?sc=1&rev=11736
Log:
* Ensure the toggle() method of Curses::UI::Checkbox always returns 0
or 1 to match the documentation. (Closes: #434646)
* Use the correct class name in Curses::UI::Checkbox class hierarchy
documentation. (Closes: #434990)
Added:
trunk/libcurses-ui-perl/debian/patches/
trunk/libcurses-ui-perl/debian/patches/checkbox-hierarchy-doc
trunk/libcurses-ui-perl/debian/patches/checkbox-toggle-boolean
trunk/libcurses-ui-perl/debian/patches/series
Modified:
trunk/libcurses-ui-perl/debian/changelog
trunk/libcurses-ui-perl/debian/control
trunk/libcurses-ui-perl/debian/rules
Modified: trunk/libcurses-ui-perl/debian/changelog
URL: http://svn.debian.org/wsvn/trunk/libcurses-ui-perl/debian/changelog?rev=11736&op=diff
==============================================================================
--- trunk/libcurses-ui-perl/debian/changelog (original)
+++ trunk/libcurses-ui-perl/debian/changelog Wed Dec 26 23:22:45 2007
@@ -6,13 +6,17 @@
Vcs-Svn fields.
[ Russ Allbery ]
+ * Ensure the toggle() method of Curses::UI::Checkbox always returns 0
+ or 1 to match the documentation. (Closes: #434646)
+ * Use the correct class name in Curses::UI::Checkbox class hierarchy
+ documentation. (Closes: #434990)
* Update debhelper compatibility level to V5 (no changes required).
* Update standards version to 3.7.3 (no changes required).
* Wrap Build-Depends-Indep for readability.
* Remove specific language names from the long description per recent
debian-devel discussion about searching.
- -- Russ Allbery <rra at debian.org> Wed, 26 Dec 2007 15:07:36 -0800
+ -- Russ Allbery <rra at debian.org> Wed, 26 Dec 2007 15:20:59 -0800
libcurses-ui-perl (0.95-6) unstable; urgency=low
Modified: trunk/libcurses-ui-perl/debian/control
URL: http://svn.debian.org/wsvn/trunk/libcurses-ui-perl/debian/control?rev=11736&op=diff
==============================================================================
--- trunk/libcurses-ui-perl/debian/control (original)
+++ trunk/libcurses-ui-perl/debian/control Wed Dec 26 23:22:45 2007
@@ -3,7 +3,7 @@
Priority: optional
Build-Depends: debhelper (>= 5)
Build-Depends-Indep: perl (>= 5.8.0-7), libtest-pod-perl, libcurses-perl,
- libterm-readkey-perl
+ libterm-readkey-perl, quilt
Maintainer: Debian Perl Group <pkg-perl-maintainers at lists.alioth.debian.org>
Uploaders: Russ Allbery <rra at debian.org>
Standards-Version: 3.7.3
Added: trunk/libcurses-ui-perl/debian/patches/checkbox-hierarchy-doc
URL: http://svn.debian.org/wsvn/trunk/libcurses-ui-perl/debian/patches/checkbox-hierarchy-doc?rev=11736&op=file
==============================================================================
--- trunk/libcurses-ui-perl/debian/patches/checkbox-hierarchy-doc (added)
+++ trunk/libcurses-ui-perl/debian/patches/checkbox-hierarchy-doc Wed Dec 26 23:22:45 2007
@@ -1,0 +1,15 @@
+Use the correct module name in the CLASS HIERARCHY section of the
+documentation.
+
+Debian Bug#434990
+--- libcurses-ui-perl.orig/lib/Curses/UI/Checkbox.pm
++++ libcurses-ui-perl/lib/Curses/UI/Checkbox.pm
+@@ -237,7 +237,7 @@
+ |
+ +----Curses::UI::Container
+ |
+- +----Curses::UI::Buttonbox
++ +----Curses::UI::Checkbox
+
+
+
Added: trunk/libcurses-ui-perl/debian/patches/checkbox-toggle-boolean
URL: http://svn.debian.org/wsvn/trunk/libcurses-ui-perl/debian/patches/checkbox-toggle-boolean?rev=11736&op=file
==============================================================================
--- trunk/libcurses-ui-perl/debian/patches/checkbox-toggle-boolean (added)
+++ trunk/libcurses-ui-perl/debian/patches/checkbox-toggle-boolean Wed Dec 26 23:22:45 2007
@@ -1,0 +1,17 @@
+Ensure toggle returns 0 or 1, matching the documentation. Without this
+patch, it would return the empty string if the previous value were 1.
+This is still a boolean false, but it doesn't match the documentation.
+
+Debian Bug#434646
+
+--- libcurses-ui-perl.orig/lib/Curses/UI/Checkbox.pm
++++ libcurses-ui-perl/lib/Curses/UI/Checkbox.pm
+@@ -198,7 +198,7 @@
+ sub toggle()
+ {
+ my $this = shift;
+- $this->{-checked} = !$this->{-checked};
++ $this->{-checked} = ($this->{-checked} ? 0 : 1);
+ $this->run_event('-onchange');
+ $this->schedule_draw(1);
+ }
Added: trunk/libcurses-ui-perl/debian/patches/series
URL: http://svn.debian.org/wsvn/trunk/libcurses-ui-perl/debian/patches/series?rev=11736&op=file
==============================================================================
--- trunk/libcurses-ui-perl/debian/patches/series (added)
+++ trunk/libcurses-ui-perl/debian/patches/series Wed Dec 26 23:22:45 2007
@@ -1,0 +1,2 @@
+checkbox-toggle-boolean
+checkbox-hierarchy-doc
Modified: trunk/libcurses-ui-perl/debian/rules
URL: http://svn.debian.org/wsvn/trunk/libcurses-ui-perl/debian/rules?rev=11736&op=diff
==============================================================================
--- trunk/libcurses-ui-perl/debian/rules (original)
+++ trunk/libcurses-ui-perl/debian/rules Wed Dec 26 23:22:45 2007
@@ -6,6 +6,9 @@
# packages. It was created by Marc Brockschmidt <marc at dch-faq.de> for
# the Debian Perl Group (http://pkg-perl.alioth.debian.org/) but may
# be used freely wherever it is useful.
+
+# Use quilt to manage patches.
+include /usr/share/quilt/quilt.make
# Uncomment this to turn on verbose mode.
# export DH_VERBOSE=1
@@ -21,14 +24,14 @@
build: build-arch build-indep
build-arch:
build-indep: build-stamp
-build-stamp:
+build-stamp: patch
dh_testdir
chmod 755 examples/demo-buttonbox
$(PERL) Makefile.PL INSTALLDIRS=vendor
$(MAKE)
touch build-stamp
-clean:
+clean: unpatch
dh_testdir
dh_testroot
rm -f build-stamp install-stamp
More information about the Pkg-perl-cvs-commits
mailing list