r11878 - /scripts/qa/templates/by_category

Mon Dec 31 07:39:57 UTC 2007

Author: tincho-guest
Date: Mon Dec 31 07:39:56 2007
New Revision: 11878

URL: http://svn.debian.org/wsvn/?sc=1&rev=11878
Log:
Correctly quote javascript code to avoid xml problems.
Added a loading indicator to the ajax thingy.

Modified:
    scripts/qa/templates/by_category

Modified: scripts/qa/templates/by_category
URL: http://svn.debian.org/wsvn/scripts/qa/templates/by_category?rev=11878&op=diff
==============================================================================

--- scripts/qa/templates/by_category (original)
+++ scripts/qa/templates/by_category Mon Dec 31 07:39:56 2007
@@ -211,6 +211,8 @@
         #w3org { clear: both; }
     </style>
     <script type="text/javascript">
+        //<![CDATA[
+        <!--
         function toggle_visibility(id)
         {
             var el = document.getElementById(id);
@@ -228,35 +230,44 @@
                 return false;
             }
 
+            xml.open('GET', 'qareport-chlog.cgi?pkg='+pkg+';rel='+rel);
+
             xml.onreadystatechange = function() {
                 ajaxStateChanged(xml, pkg, rel);
             };
 
-            xml.open('GET', 'qareport-chlog.cgi?pkg='+pkg+';rel='+rel);
             xml.send('');
         }
         function ajaxStateChanged(xml, pkg, rel)
         {
+            var el = document.getElementById(pkg+'_'+rel+'_chlog_baloon');
+            if( !el )
+            {
+                alert('Element "'+pkg+'_'+rel+'_chlog_baloon'+'" not found');
+                return false;
+            }
+            if( xml.readyState <= 1 )
+            {
+                el.innerHTML = el.innerHTML + "<br/>Loading...";
+            }
+            if( xml.readyState == 3 )
+            {
+                el.innerHTML = el.innerHTML + ".";
+            }
             if( xml.readyState == 4 )
             {
-                var el = document.getElementById(pkg+'_'+rel+'_chlog_baloon');
-                if( !el )
+                if( xml.status == 200 )
                 {
-                    alert('Element "'+pkg+'_'+rel+'_chlog_baloon'+'" not found');
+                    el.innerHTML = xml.responseText;
                 }
                 else
                 {
-                    if( xml.status == 200 )
-                    {
-                        el.innerHTML = xml.responseText;
-                    }
-                    else
-                    {
-                        el.innerHTML = xml.status+': '+xml.StatusText;
-                    }
+                    el.innerHTML = xml.status+': '+xml.StatusText;
                 }
             }
         }
+        //-->
+        //]]>
     </script>
 </head>
 <body>


