r14081 - in /trunk/libxml-rss-perl: debian/changelog lib/XML/RSS.pm t/2.0-permalink.t

[joeyh at users.alioth.debian.org]

Author: joeyh
Date: Sun Feb  3 09:13:57 2008
New Revision: 14081

URL: http://svn.debian.org/wsvn/?sc=1&rev=14081
Log:
* Fix handling of guid's isPermaLink attribute -- if it's not set,
  it's false, not true. Closes: #463774

Modified:
    trunk/libxml-rss-perl/debian/changelog
    trunk/libxml-rss-perl/lib/XML/RSS.pm
    trunk/libxml-rss-perl/t/2.0-permalink.t

Modified: trunk/libxml-rss-perl/debian/changelog
URL: http://svn.debian.org/wsvn/trunk/libxml-rss-perl/debian/changelog?rev=14081&op=diff
==============================================================================
--- trunk/libxml-rss-perl/debian/changelog (original)
+++ trunk/libxml-rss-perl/debian/changelog Sun Feb  3 09:13:57 2008
@@ -1,6 +1,11 @@
 libxml-rss-perl (1.31-4) UNRELEASED; urgency=low
 
+  [ gregor herrmann ]
   * debian/rules: delete /usr/lib/perl5 only if it exists.
+
+  [ Joey Hess ]
+  * Fix handling of guid's isPermaLink attribute -- if it's not set,
+    it's false, not true. Closes: #463774
 
  -- gregor herrmann <gregor+debian at comodo.priv.at>  Wed, 09 Jan 2008 21:19:29 +0100
 

Modified: trunk/libxml-rss-perl/lib/XML/RSS.pm
URL: http://svn.debian.org/wsvn/trunk/libxml-rss-perl/lib/XML/RSS.pm?rev=14081&op=diff
==============================================================================
--- trunk/libxml-rss-perl/lib/XML/RSS.pm (original)
+++ trunk/libxml-rss-perl/lib/XML/RSS.pm Sun Feb  3 09:13:57 2008
@@ -786,11 +786,12 @@
             }
         }
 
-        # guid element is a permanent link unless isPermaLink attribute is set to false
+        # guid element is a permanent link IFF isPermaLink attribute is set
+        # to true
     }
     elsif ($el eq 'guid') {
         $self->{'items'}->[$self->{num_items} - 1]->{'isPermaLink'} =
-          !(exists($attribs{'isPermaLink'}) && ($attribs{'isPermaLink'} eq 'false'));
+           (exists($attribs{'isPermaLink'}) && (lc($attribs{'isPermaLink'}) eq 'true'));
 
         # beginning of taxo li element in item element
         #'http://purl.org/rss/1.0/modules/taxonomy/' => 'taxo'

Modified: trunk/libxml-rss-perl/t/2.0-permalink.t
URL: http://svn.debian.org/wsvn/trunk/libxml-rss-perl/t/2.0-permalink.t?rev=14081&op=diff
==============================================================================
--- trunk/libxml-rss-perl/t/2.0-permalink.t (original)
+++ trunk/libxml-rss-perl/t/2.0-permalink.t Sun Feb  3 09:13:57 2008
@@ -21,9 +21,8 @@
 );
 
 # TEST
-is ($item_with_guid_missing->{"permaLink"}, 
-    "http://community.livejournal.com/lj_dev/713810.html",
-    "guid's isPermaLink is missing, so the item permalink property should be set to the value of the guid tag"
+ok ((!$item_with_guid_missing->{"permaLink"}),
+    "guid's isPermaLink is missing (implicitly false), so the item permalink property should not be set"
 );
 
 # TEST