r22930 - in /branches/upstream/libcgi-session-perl/current: ./ lib/CGI/ lib/CGI/Session/ lib/CGI/Session/Driver/ lib/CGI/Session/ID/ lib/CGI/Session/Serialize/ lib/CGI/Session/Test/ t/
rmayorga-guest at users.alioth.debian.org
rmayorga-guest at users.alioth.debian.org
Tue Jul 8 18:02:34 UTC 2008
Author: rmayorga-guest
Date: Tue Jul 8 18:02:33 2008
New Revision: 22930
URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=22930
Log:
[svn-upgrade] Integrating new upstream version, libcgi-session-perl (4.33)
Removed:
branches/upstream/libcgi-session-perl/current/t/load_with_undef.t
branches/upstream/libcgi-session-perl/current/t/new_with_undef.t
Modified:
branches/upstream/libcgi-session-perl/current/Changes
branches/upstream/libcgi-session-perl/current/MANIFEST
branches/upstream/libcgi-session-perl/current/META.yml
branches/upstream/libcgi-session-perl/current/lib/CGI/Session.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/DBI.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/db_file.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/file.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/mysql.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/postgresql.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/sqlite.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ErrorHandler.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/incr.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/md5.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/static.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/default.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/storable.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Test/Default.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Tutorial.pm
branches/upstream/libcgi-session-perl/current/t/g4_mysql.t
Modified: branches/upstream/libcgi-session-perl/current/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/Changes?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/Changes (original)
+++ branches/upstream/libcgi-session-perl/current/Changes Tue Jul 8 18:02:33 2008
@@ -1,23 +1,37 @@
CGI::Session Change Log
=====================================================================
+4.33 - Monday, July 7, 2008
+ * FIX: Patch CGI::Session::Driver::mysql to replace 'REPLACE INTO ...' with
+ 'INSERT INTO ... ON DUPLICATE KEY UPDATE ...'. See RT#37069.
+ Thanks to Steve Kirkup for the patch. I (Ron) installed MySQL V 5.0.51a for testing.
+ Note: http://dev.mysql.com/doc/refman/5.0/en/releasenotes-cs-5-0-45.html and similar docs
+ list various MySQL errors fixed recently for the above new syntax. Also, the new version
+ is now much more like the Postgres code, which is another reason it has been adopted.
+ * FIX: t/mysql.t used to test setting the global variable $CGI::Session::MySQL::TABLE_NAME.
+ The test for this (in t/mysql.t) was introduced in V 4.00_09.
+ However, since V 4.29_1, changes to CGI::Session::Driver's new() method mean
+ this way of setting the session table's name no longer works, and so the variable
+ $CGI::Session::MySQL::TABLE_NAME is now not used. Hence it has been removed.
+ Code in CGI::Session::Driver::DBI used to set $class::TABLE_NAME for all database drivers.
+ This code has also been removed. Moral: Don't use global variables.
+ Call $session = CGI::Session -> new(..., ..., (TableName => 'new_name'}) or,
+ after creating the object, call $session -> table_name('new_name').
+ To retrieve the name, call $name = $session -> table_name().
+
4.32 - Tuesday, June 17, 2008
* FIX: Packaging of 4.31 release was botched.
4.31 - Tuesday, June 10, 2008
- * FIX: Patch CGI::Session::Driver::DBI to check that the DBI handle still
- exists before trying to ping it. This handles the case where the DBI
- object is destroyed before the session object. See RT#35925.
-
- * FIX: Patch CGI::Session::Driver::DBI's remove() which still hard-coded
- the column name 'id' instead of using the new feature which allows
- the user to specify the name of the column. See RT#36235.
-
- * FIX: Patch POD yet again to emphasize that an explicit call to destroy()
- should be followed by explicit call to flush(), in particular in the
- case where the program is not exiting and hence auto-flushing is not
- activated. Sections patched are 'A Warning about Auto-flushing' and
- the docs for delete(). See RT#34668.
+ * FIX: Patch CGI::Session::Driver::DBI to check that the DBI handle still exists before trying
+ to ping it. This handles the case where the DBI object is destroyed before the session object.
+ See RT#35925.
+ * FIX: Patch CGI::Session::Driver::DBI's remove() which still hard-coded the column name 'id' instead
+ of using the new feature which allows the user to specify the name of the column. See RT#36235.
+ * FIX: Patch POD yet again to emphasize that an explicit call to destroy() should be followed by
+ explicit call to flush(), in particular in the case where the program is not exiting and
+ hence auto-flushing is not activated. Sections patched are 'A Warning about Auto-flushing'
+ and the docs for delete(). See RT#34668.
4.30 - Friday, April 25, 2008
@@ -338,4 +352,4 @@
* Bug in POD documentation is fixed (thanks to Graham Barr)
-$Id: Changes 413 2008-06-09 02:13:27Z ron $
+$Id: Changes 420 2008-07-08 01:23:06Z markstos $
Modified: branches/upstream/libcgi-session-perl/current/MANIFEST
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/MANIFEST?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/MANIFEST (original)
+++ branches/upstream/libcgi-session-perl/current/MANIFEST Tue Jul 8 18:02:33 2008
@@ -23,7 +23,6 @@
Makefile.PL
MANIFEST This list of files
MANIFEST.SKIP
-META.yml
README
t/api3_db_file.t
t/api3_db_file_freezethaw.t
@@ -65,11 +64,10 @@
t/ip_matches.t
t/is_new.t
t/load.t
-t/load_with_undef.t
t/name.t
-t/new_with_undef.t
t/parse_dsn.t
t/remote_addr.t
t/str2seconds.t
t/symlink_db_file.t
t/symlink_file.t
+META.yml Module meta-data (added by MakeMaker)
Modified: branches/upstream/libcgi-session-perl/current/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/META.yml?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/META.yml (original)
+++ branches/upstream/libcgi-session-perl/current/META.yml Tue Jul 8 18:02:33 2008
@@ -1,7 +1,7 @@
# http://module-build.sourceforge.net/META-spec.html
#XXXXXXX This is a prototype!!! It will change in the future!!! XXXXX#
name: CGI-Session
-version: 4.32
+version: 4.33
version_from: lib/CGI/Session.pm
installdirs: site
requires:
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/lib/CGI/Session.pm?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session.pm Tue Jul 8 18:02:33 2008
@@ -1,13 +1,13 @@
package CGI::Session;
-# $Id: Session.pm 415 2008-06-16 14:40:45Z markstos $
+# $Id: Session.pm 420 2008-07-08 01:23:06Z markstos $
use strict;
use Carp;
use CGI::Session::ErrorHandler;
@CGI::Session::ISA = qw( CGI::Session::ErrorHandler );
-$CGI::Session::VERSION = '4.32';
+$CGI::Session::VERSION = '4.33';
$CGI::Session::NAME = 'CGISESSID';
$CGI::Session::IP_MATCH = 0;
@@ -447,7 +447,7 @@
return 1;
}
-# $Id: Session.pm 415 2008-06-16 14:40:45Z markstos $
+# $Id: Session.pm 420 2008-07-08 01:23:06Z markstos $
=pod
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver.pm?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver.pm Tue Jul 8 18:02:33 2008
@@ -1,6 +1,6 @@
package CGI::Session::Driver;
-# $Id: Driver.pm 415 2008-06-16 14:40:45Z markstos $
+# $Id: Driver.pm 420 2008-07-08 01:23:06Z markstos $
use strict;
#use diagnostics;
@@ -8,7 +8,7 @@
use Carp;
use CGI::Session::ErrorHandler;
-$CGI::Session::Driver::VERSION = '4.31';
+$CGI::Session::Driver::VERSION = '4.33';
@CGI::Session::Driver::ISA = qw(CGI::Session::ErrorHandler);
sub new {
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/DBI.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/DBI.pm?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/DBI.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/DBI.pm Tue Jul 8 18:02:33 2008
@@ -1,6 +1,6 @@
package CGI::Session::Driver::DBI;
-# $Id: DBI.pm 415 2008-06-16 14:40:45Z markstos $
+# $Id: DBI.pm 420 2008-07-08 01:23:06Z markstos $
use strict;
@@ -9,7 +9,7 @@
use CGI::Session::Driver;
@CGI::Session::Driver::DBI::ISA = ( "CGI::Session::Driver" );
-$CGI::Session::Driver::DBI::VERSION = '4.31';
+$CGI::Session::Driver::DBI::VERSION = '4.33';
sub init {
@@ -47,9 +47,7 @@
no strict 'refs';
if ( @_ ) {
- my $new_name = shift;
- $self->{TableName} = $new_name;
- ${ $class . "::TABLE_NAME" } = $new_name;
+ $self->{TableName} = shift;
}
unless (defined $self->{TableName}) {
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/db_file.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/db_file.pm?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/db_file.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/db_file.pm Tue Jul 8 18:02:33 2008
@@ -1,6 +1,6 @@
package CGI::Session::Driver::db_file;
-# $Id: db_file.pm 415 2008-06-16 14:40:45Z markstos $
+# $Id: db_file.pm 420 2008-07-08 01:23:06Z markstos $
use strict;
@@ -13,7 +13,7 @@
use vars qw( @ISA $VERSION $FILE_NAME $UMask $NO_FOLLOW );
@ISA = ( "CGI::Session::Driver" );
-$VERSION = '4.31';
+$VERSION = '4.33';
$FILE_NAME = "cgisess.db";
$UMask = 0660;
$NO_FOLLOW = eval { O_NOFOLLOW } || 0;
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/file.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/file.pm?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/file.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/file.pm Tue Jul 8 18:02:33 2008
@@ -1,6 +1,6 @@
package CGI::Session::Driver::file;
-# $Id: file.pm 415 2008-06-16 14:40:45Z markstos $
+# $Id: file.pm 420 2008-07-08 01:23:06Z markstos $
use strict;
@@ -19,7 +19,7 @@
}
@CGI::Session::Driver::file::ISA = ( "CGI::Session::Driver" );
-$CGI::Session::Driver::file::VERSION = '4.31';
+$CGI::Session::Driver::file::VERSION = '4.33';
$FileName = "cgisess_%s";
$NoFlock = 0;
$UMask = 0660;
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/mysql.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/mysql.pm?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/mysql.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/mysql.pm Tue Jul 8 18:02:33 2008
@@ -1,13 +1,13 @@
package CGI::Session::Driver::mysql;
-# $Id: mysql.pm 415 2008-06-16 14:40:45Z markstos $
+# $Id: mysql.pm 420 2008-07-08 01:23:06Z markstos $
use strict;
use Carp;
use CGI::Session::Driver::DBI;
@CGI::Session::Driver::mysql::ISA = qw( CGI::Session::Driver::DBI );
-$CGI::Session::Driver::mysql::VERSION = '4.31';
+$CGI::Session::Driver::mysql::VERSION = '4.33';
sub _mk_dsnstr {
my ($class, $dsn) = @_;
@@ -47,18 +47,17 @@
croak "store(): usage error" unless $sid && $datastr;
my $dbh = $self->{Handle};
- $dbh->do("REPLACE INTO " . $self->table_name . " ($self->{IdColName}, $self->{DataColName}) VALUES(?, ?)", undef, $sid, $datastr)
+ $dbh->do("INSERT INTO " . $self->table_name .
+ " ($self->{IdColName}, $self->{DataColName}) VALUES(?, ?) ON DUPLICATE KEY UPDATE $self->{DataColName} = ?",
+ undef, $sid, $datastr, $datastr)
or return $self->set_error( "store(): \$dbh->do failed " . $dbh->errstr );
return 1;
}
-# If the table name hasn't been defined yet, check this location for 3.x compatibility
sub table_name {
my $self = shift;
- unless (defined $self->{TableName}) {
- $self->{TableName} = $CGI::Session::MySQL::TABLE_NAME;
- }
+
return $self->SUPER::table_name(@_);
}
@@ -122,9 +121,19 @@
=head2 BACKWARDS COMPATIBILITY
-For backwards compatibility, you can also set the table like this before calling C<new()>. However, it is not recommended because it can cause conflicts in a persistent environment.
+As of V 4.30, the global variable $CGI::Session::MySQL::TABLE_NAME cannot be used to set the session
+table's name.
- $CGI::Session::MySQL::TABLE_NAME = 'my_sessions';
+This is due to changes in CGI::Session::Driver's new() method, which now allows the table's name to be
+changed (as well as allowing both the 'id' column name and the 'a_session' column name to be changed).
+
+See the documentation for CGI::Session::Driver::DBI for details.
+
+In particular, the new syntax for C<new()> applies to all database drivers, whereas the old - and bad -
+global variable method only applied to MySQL.
+
+Alternately, call $session -> table_name('new_name') just after creating the session object if you wish to
+change the session table's name.
=head1 LICENSING
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/postgresql.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/postgresql.pm?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/postgresql.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/postgresql.pm Tue Jul 8 18:02:33 2008
@@ -1,6 +1,6 @@
package CGI::Session::Driver::postgresql;
-# $Id: postgresql.pm 415 2008-06-16 14:40:45Z markstos $
+# $Id: postgresql.pm 420 2008-07-08 01:23:06Z markstos $
# CGI::Session::Driver::postgresql - PostgreSQL driver for CGI::Session
#
@@ -15,7 +15,7 @@
use CGI::Session::Driver::DBI;
use DBD::Pg qw(PG_BYTEA PG_TEXT);
-$CGI::Session::Driver::postgresql::VERSION = '4.31';
+$CGI::Session::Driver::postgresql::VERSION = '4.33';
@CGI::Session::Driver::postgresql::ISA = qw( CGI::Session::Driver::DBI );
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/sqlite.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/sqlite.pm?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/sqlite.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/sqlite.pm Tue Jul 8 18:02:33 2008
@@ -1,6 +1,6 @@
package CGI::Session::Driver::sqlite;
-# $Id: sqlite.pm 415 2008-06-16 14:40:45Z markstos $
+# $Id: sqlite.pm 420 2008-07-08 01:23:06Z markstos $
use strict;
@@ -9,7 +9,7 @@
use DBI qw(SQL_BLOB);
use Fcntl;
-$CGI::Session::Driver::sqlite::VERSION = '4.31';
+$CGI::Session::Driver::sqlite::VERSION = '4.33';
sub init {
my $self = shift;
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ErrorHandler.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ErrorHandler.pm?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ErrorHandler.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ErrorHandler.pm Tue Jul 8 18:02:33 2008
@@ -1,9 +1,9 @@
package CGI::Session::ErrorHandler;
-# $Id: ErrorHandler.pm 415 2008-06-16 14:40:45Z markstos $
+# $Id: ErrorHandler.pm 420 2008-07-08 01:23:06Z markstos $
use strict;
-$CGI::Session::ErrorHandler::VERSION = '4.31';
+$CGI::Session::ErrorHandler::VERSION = '4.33';
=pod
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/incr.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/incr.pm?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/incr.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/incr.pm Tue Jul 8 18:02:33 2008
@@ -1,6 +1,6 @@
package CGI::Session::ID::incr;
-# $Id: incr.pm 415 2008-06-16 14:40:45Z markstos $
+# $Id: incr.pm 420 2008-07-08 01:23:06Z markstos $
use strict;
use File::Spec;
@@ -8,7 +8,7 @@
use Fcntl qw( :DEFAULT :flock );
use CGI::Session::ErrorHandler;
-$CGI::Session::ID::incr::VERSION = '4.31';
+$CGI::Session::ID::incr::VERSION = '4.33';
@CGI::Session::ID::incr::ISA = qw( CGI::Session::ErrorHandler );
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/md5.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/md5.pm?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/md5.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/md5.pm Tue Jul 8 18:02:33 2008
@@ -1,12 +1,12 @@
package CGI::Session::ID::md5;
-# $Id: md5.pm 415 2008-06-16 14:40:45Z markstos $
+# $Id: md5.pm 420 2008-07-08 01:23:06Z markstos $
use strict;
use Digest::MD5;
use CGI::Session::ErrorHandler;
-$CGI::Session::ID::md5::VERSION = '4.31';
+$CGI::Session::ID::md5::VERSION = '4.33';
@CGI::Session::ID::md5::ISA = qw( CGI::Session::ErrorHandler );
*generate = \&generate_id;
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/static.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/static.pm?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/static.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/static.pm Tue Jul 8 18:02:33 2008
@@ -1,12 +1,12 @@
package CGI::Session::ID::static;
-# $Id: static.pm 415 2008-06-16 14:40:45Z markstos $
+# $Id: static.pm 420 2008-07-08 01:23:06Z markstos $
use strict;
use Carp ("croak");
use CGI::Session::ErrorHandler;
-$CGI::Session::ID::static::VERSION = '4.31';
+$CGI::Session::ID::static::VERSION = '4.33';
@::CGI::Session::ID::static::ISA = qw( CGI::Session::ErrorHandler );
sub generate_id {
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/default.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/default.pm?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/default.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/default.pm Tue Jul 8 18:02:33 2008
@@ -1,6 +1,6 @@
package CGI::Session::Serialize::default;
-# $Id: default.pm 415 2008-06-16 14:40:45Z markstos $
+# $Id: default.pm 420 2008-07-08 01:23:06Z markstos $
use strict;
use Safe;
@@ -12,7 +12,7 @@
require overload;
@CGI::Session::Serialize::default::ISA = ( "CGI::Session::ErrorHandler" );
-$CGI::Session::Serialize::default::VERSION = '4.31';
+$CGI::Session::Serialize::default::VERSION = '4.33';
sub freeze {
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/storable.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/storable.pm?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/storable.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/storable.pm Tue Jul 8 18:02:33 2008
@@ -1,12 +1,12 @@
package CGI::Session::Serialize::storable;
-# $Id: storable.pm 415 2008-06-16 14:40:45Z markstos $
+# $Id: storable.pm 420 2008-07-08 01:23:06Z markstos $
use strict;
use Storable;
require CGI::Session::ErrorHandler;
-$CGI::Session::Serialize::storable::VERSION = '4.31';
+$CGI::Session::Serialize::storable::VERSION = '4.33';
@CGI::Session::Serialize::ISA = ( "CGI::Session::ErrorHandler" );
=pod
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Test/Default.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Test/Default.pm?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Test/Default.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Test/Default.pm Tue Jul 8 18:02:33 2008
@@ -11,7 +11,7 @@
sub ok_later (&;$);
-$CGI::Session::Test::Default::VERSION = '4.31';
+$CGI::Session::Test::Default::VERSION = '4.33';
=head1 CGI::Session::Test::Default
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Tutorial.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Tutorial.pm?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Tutorial.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Tutorial.pm Tue Jul 8 18:02:33 2008
@@ -1,8 +1,8 @@
package CGI::Session::Tutorial;
-# $Id: Tutorial.pm 415 2008-06-16 14:40:45Z markstos $
-
-$CGI::Session::Tutorial::VERSION = '4.31';
+# $Id: Tutorial.pm 420 2008-07-08 01:23:06Z markstos $
+
+$CGI::Session::Tutorial::VERSION = '4.33';
=pod
Modified: branches/upstream/libcgi-session-perl/current/t/g4_mysql.t
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libcgi-session-perl/current/t/g4_mysql.t?rev=22930&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/t/g4_mysql.t (original)
+++ branches/upstream/libcgi-session-perl/current/t/g4_mysql.t Tue Jul 8 18:02:33 2008
@@ -1,4 +1,4 @@
-# $Id: g4_mysql.t 338 2006-10-26 04:32:03Z sherzodr $
+# $Id: g4_mysql.t 419 2008-06-29 01:58:12Z ron $
use strict;
use diagnostics;
@@ -70,17 +70,21 @@
$t->run();
{
- # This was documented to work in 3.95 and should be supported for compatibility
+ # This used to test setting the global variable $CGI::Session::MySQL::TABLE_NAME.
+ # However, since V 4.29_1, changes to CGI::Session::Driver's new() method mean
+ # the unless test in CGI::Session::Driver::mysql's table_name() method was not executed,
+ # and so $CGI::Session::MySQL::TABLE_NAME is never used. That 'unless' has been deleted.
+ # V 4.32 explicitly documents this new situation. Moral: Don't use global variables.
+ # This test was introduced in V 4.00_09.
+
my $obj;
eval {
- # test.sessions will refer to the same 'sessions' table but is a unique name to test with
- $CGI::Session::MySQL::TABLE_NAME = 'test.sessions';
- my $avoid_warning = $CGI::Session::MySQL::TABLE_NAME;
require CGI::Session::Driver::mysql;
$obj = CGI::Session::Driver::mysql->new( {Handle=>$dbh} );
+ $obj -> table_name('my_sessions');
};
is($@,'', 'survived eval');
- is($obj->table_name, 'test.sessions', "setting table name through CGI::Session::MySQL::TABLE_NAME works");
+ is($obj->table_name, 'my_sessions', "setting table name through the table_name() method works");
}
More information about the Pkg-perl-cvs-commits
mailing list