r23023 - in /trunk/libdbd-pg-perl: ./ debian/ lib/Bundle/DBD/ t/

gregoa at users.alioth.debian.org gregoa at users.alioth.debian.org
Fri Jul 11 13:53:01 UTC 2008


Author: gregoa
Date: Fri Jul 11 13:53:01 2008
New Revision: 23023

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=23023
Log:
New upstream release, fixes the perl-critic test failures
(closes: #490321).

Modified:
    trunk/libdbd-pg-perl/.perlcriticrc
    trunk/libdbd-pg-perl/Changes
    trunk/libdbd-pg-perl/META.yml
    trunk/libdbd-pg-perl/Makefile.PL
    trunk/libdbd-pg-perl/Pg.pm
    trunk/libdbd-pg-perl/README
    trunk/libdbd-pg-perl/SIGNATURE
    trunk/libdbd-pg-perl/debian/changelog
    trunk/libdbd-pg-perl/lib/Bundle/DBD/Pg.pm
    trunk/libdbd-pg-perl/t/00-signature.t
    trunk/libdbd-pg-perl/t/00basic.t
    trunk/libdbd-pg-perl/t/01connect.t
    trunk/libdbd-pg-perl/t/01constants.t
    trunk/libdbd-pg-perl/t/02attribs.t
    trunk/libdbd-pg-perl/t/03dbmethod.t
    trunk/libdbd-pg-perl/t/03smethod.t
    trunk/libdbd-pg-perl/t/04misc.t
    trunk/libdbd-pg-perl/t/06bytea.t
    trunk/libdbd-pg-perl/t/07copy.t
    trunk/libdbd-pg-perl/t/08async.t
    trunk/libdbd-pg-perl/t/09arrays.t
    trunk/libdbd-pg-perl/t/12placeholders.t
    trunk/libdbd-pg-perl/t/20savepoints.t
    trunk/libdbd-pg-perl/t/99_perlcritic.t
    trunk/libdbd-pg-perl/t/99_pod.t
    trunk/libdbd-pg-perl/t/99_spellcheck.t
    trunk/libdbd-pg-perl/t/99_yaml.t
    trunk/libdbd-pg-perl/t/99cleanup.t
    trunk/libdbd-pg-perl/t/dbdpg_test_setup.pl

Modified: trunk/libdbd-pg-perl/.perlcriticrc
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/.perlcriticrc?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/.perlcriticrc (original)
+++ trunk/libdbd-pg-perl/.perlcriticrc Fri Jul 11 13:53:01 2008
@@ -2,7 +2,7 @@
 profile-strictness = quiet
 
 [Documentation::PodSpelling]
-stop_words = ActiveKids AutoCommit boolean Bunce CachedKids ChildHandles ChopBlanks CompatMode CursorName DBD DBI Datatype dbdpg ErrCount FetchHashKeyName HandleError HandleSetErr InactiveDestroy LongReadLen LongTruncOk Mergl Momjian Mullane NULLABLE OID PgBouncer pgend pglibpq pglogin pgprefix pgquote pgstart perl Postgres PostgreSQL PrintError PrintWarn README RaiseError RowCache RowCacheSize SQL SQLSTATE SSL STDIN STDERR STDOUT Sabino Savepoints ShowErrorStatement TaintIn TaintOut TraceLevel UTF Username afterwards arrayrefs attr autocommit backend bitmask bytea cancelled datatype dbd dbh errstr fd filename getfd getline hashref largeobject len libpq lseg pgbuiltin pgsql runtime savepoint savepoints schemas sslmode tablename tablespace tablespaces tuple typename username varchar undef Perlish arrayref datatypes bool func PID
+stop_words = ActiveKids AutoCommit boolean Bunce CachedKids ChildHandles ChopBlanks CompatMode CursorName DBD DBI Datatype dbdpg ErrCount FetchHashKeyName HandleError HandleSetErr InactiveDestroy LongReadLen LongTruncOk Mergl Momjian Mullane NULLABLE OID PgBouncer pgend pglibpq pglogin pgprefix pgquote pgstart perl Postgres PostgreSQL PrintError PrintWarn README RaiseError RowCache RowCacheSize SQL SQLSTATE SSL STDIN STDERR STDOUT Sabino Savepoints ShowErrorStatement TaintIn TaintOut TraceLevel UTF Username afterwards arrayrefs attr autocommit backend bitmask bytea cancelled datatype dbd dbh errstr fd filename getfd getline hashref largeobject len libpq lseg pgbuiltin pgsql runtime savepoint savepoints schemas sslmode tablename tablespace tablespaces tuple typename username varchar undef Perlish arrayref datatypes bool func PID dr
 
 [-Bangs::ProhibitCommentedOutCode]
 [-Bangs::ProhibitFlagComments]
@@ -23,6 +23,7 @@
 [-Documentation::RequirePODUseEncodingUTF8]
 [-Editor::RequireEmacsFileVariables]
 [-ErrorHandling::RequireCarping]
+[-ErrorHandling::RequireCheckingReturnValueOfEval]
 [-InputOutput::ProhibitBacktickOperators]
 [-InputOutput::ProhibitOneArgSelect]
 [-InputOutput::RequireCheckedSyscalls]

Modified: trunk/libdbd-pg-perl/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/Changes?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/Changes (original)
+++ trunk/libdbd-pg-perl/Changes Fri Jul 11 13:53:01 2008
@@ -1,6 +1,12 @@
 ('GSM' is Greg Sabino Mullane, greg at turnstep.com)
 
-2.8.3 Released July 6, 2008
+2.8.4 Released July 10, 2008
+
+	- Minor Perl::Critic test adjustments.
+	- Documentation enhancements.
+	- Yet more minor testing tweaks.
+
+2.8.3 Released July 6, 2008 (subversion r11495)
 
 	- Minor testing functionality tweaks, lots of test cleanups, minor doc enhancements.
 

Modified: trunk/libdbd-pg-perl/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/META.yml?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/META.yml (original)
+++ trunk/libdbd-pg-perl/META.yml Fri Jul 11 13:53:01 2008
@@ -1,6 +1,6 @@
 --- #YAML:1.0
 name                        : DBD-Pg
-version                     : 2.8.3
+version                     : 2.8.4
 abstract                    : DBI PostgreSQL interface
 author:              
   - Greg Sabino Mullane <greg at turnstep.com>
@@ -38,10 +38,10 @@
 provides:
   DBD::Pg:
     file                    : Pg.pm
-    version                 : 2.8.3
+    version                 : 2.8.4
   Bundle::DBD::Pg:
     file                    : lib/Bundle/DBD/Pg.pm
-    version                 : 2.8.3
+    version                 : 2.8.4
 
 keywords:
   - Postgres

Modified: trunk/libdbd-pg-perl/Makefile.PL
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/Makefile.PL?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/Makefile.PL (original)
+++ trunk/libdbd-pg-perl/Makefile.PL Fri Jul 11 13:53:01 2008
@@ -1,4 +1,4 @@
-# $Id: Makefile.PL 11486 2008-07-06 02:41:10Z turnstep $
+# $Id: Makefile.PL 11516 2008-07-10 17:15:06Z turnstep $
 
 use ExtUtils::MakeMaker;
 use Config;
@@ -7,7 +7,7 @@
 use 5.006001;
 
 ## No version.pm for this one, as the prereqs are not loaded yet.
-my $VERSION = '2.8.3';
+my $VERSION = '2.8.4';
 
 my $lib;
 BEGIN {

Modified: trunk/libdbd-pg-perl/Pg.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/Pg.pm?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/Pg.pm (original)
+++ trunk/libdbd-pg-perl/Pg.pm Fri Jul 11 13:53:01 2008
@@ -1,5 +1,5 @@
 #  -*-cperl-*-
-#  $Id: Pg.pm 11487 2008-07-06 03:36:45Z turnstep $
+#  $Id: Pg.pm 11516 2008-07-10 17:15:06Z turnstep $
 #
 #  Copyright (c) 2002-2008 Greg Sabino Mullane and others: see the Changes file
 #  Portions Copyright (c) 2002 Jeffrey W. Baker
@@ -17,7 +17,7 @@
 {
 	package DBD::Pg;
 
-	use version; our $VERSION = qv('2.8.3');
+	use version; our $VERSION = qv('2.8.4');
 
 	use DBI ();
 	use DynaLoader ();
@@ -1694,7 +1694,7 @@
 
 =head1 VERSION
 
-This documents version 2.8.3 of the DBD::Pg module
+This documents version 2.8.4 of the DBD::Pg module
 
 =head1 DESCRIPTION
 
@@ -1909,8 +1909,9 @@
   $h->trace_msg($message_text);
   $h->trace_msg($message_text, $min_level);
 
-Implemented by DBI, no driver-specific impact. Writes a message to the current trace output. 
-With a second argument, only writes the message if the minimum level is currently set.
+Writes a message to the current trace output (as set by the L</trace> method). If a second argument 
+is given, the message is only written if the current tracing level is equal to or greater than 
+the min_level.
 
 =item B<parse_trace_flag> and B<parse_trace_flags>
 
@@ -1922,7 +1923,7 @@
 
 The parse_trace_flags method is used to convert one or more named 
 flags to a number which can passed to the L<trace()> method.
-DBD::Pg currently supports the only DBI-specific flag, C<SQL>, 
+DBD::Pg currently supports the DBI-specific flag, C<SQL>, 
 as well as the ones listed below.
 
 Flags can be combined by using the parse_trace_flags method, 
@@ -1943,7 +1944,7 @@
 Output all SQL statements. Note that the output provided will not 
 necessarily be in a form suitable to passing directly to Postgres, 
 as server-side prepared statements are used extensively by DBD::Pg.
-For maximum portability of output (but with a potential small performance 
+For maximum portability of output (but with a potential performance 
 hit), use $dbh->{pg_server_prepare} = 0;
 
 =item pglibpq
@@ -1961,13 +1962,13 @@
 
 =item pgend
 
-Outputs a simple message at the very end of each function. This is also output if the 
-trace level is set to 4 or greater.
+Outputs a simple message at the very end of each internal DBD::Pg function. This is also 
+output if the trace level is set to 4 or greater.
 
 =item pgprefix
 
 Forces each line of trace output to begin with the string "dbdpg: ". This helps to 
-differentiate it from the DBI tracing output.
+differentiate it from the normal DBI trace output.
 
 =item pglogin
 
@@ -2097,8 +2098,8 @@
   $hashref = $dbh->private_attribute_info();
   $hashref = $sth->private_attribute_info();
 
-Supported by this driver as proposed by DBI.
-
+Returns a hash of all private attributes used by DBD::Pg, for either 
+a database or a statement handle. Currently, all the hash values are undef.
 
 =back
 
@@ -2106,78 +2107,86 @@
 
 =over 4
 
+=item B<InactiveDestroy> (boolean)
+
+If set to true, then the disconnect() method will not be automatically called when 
+the database handle goes out of scope. This is required if you are forking, and even 
+then you must tread carefully and ensure that either the parent or the child handles 
+all database calls from that point forwards, so that messages from the Postgres backend 
+are only handled by one of the processes. If you don't set things up properly, you 
+will see messages such as "server closed the connection unexpectedly". A better solution 
+is usually to rewrite your application not to use forking. See the section on 
+L</Asynchronous Queries> for a way to have your script continue to work while the database 
+is working.
+
 =item B<Warn> (boolean, inherited)
 
+Enables warnings. This is on by default, and should only be turned off in a local block for a short a time 
+as is absolutely needed.
+
+=item B<Active> (boolean, read-only)
+
+Indicates if a handle is active or not. For database handles, this indicates if the database has 
+been disconnected or not. For statement handles, it indicates if all the data has been fetched yet 
+or not. Use of this attribute is not encouraged.
+
+=item B<Kids> (integer, read-only)
+
+Returns the number of child processes created for each handle type. For a driver handle, indicates the number 
+of database handles created. For a database handle, indicates the number of statement handles created. For 
+statement handles, it always returns zero, because statement handles do not create kids.
+
+=item B<ActiveKids> (integer, read-only)
+
+Same as L</Kids>, but only returns those that are L</Active>.
+
+=item B<CachedKids> (hash ref)
+
 Implemented by DBI, no driver-specific impact.
 
-=item B<Active> (boolean, read-only)
-
-Supported by this driver as proposed by DBI. A database handle is active while
-it is connected and statement handle is active until it is finished.
-
 =item B<Executed> (boolean, read-only)
 
 Implemented by DBI, no driver-specific impact.
 
-=item B<Kids> (integer, read-only)
+=item B<Type> (scalar)
+
+Returns 'dr' for a driver handle, 'db' for a database handle, and 'st' for a statement handle. 
+Should be rarely needed.
+
+=item B<TraceLevel> (integer, inherited)
+
+Sets the trace level, similar to the L</trace> method. See the sections on 
+L</trace> and L</parse_trace_flag> for more details.
+
+=item B<ChildHandles> (array ref)
 
 Implemented by DBI, no driver-specific impact.
 
-=item B<ActiveKids> (integer, read-only)
+=item B<PrintWarn> (boolean, inherited)
 
 Implemented by DBI, no driver-specific impact.
 
-=item B<CachedKids> (hash ref)
+=item B<PrintError> (boolean, inherited)
 
 Implemented by DBI, no driver-specific impact.
 
-=item B<Type> (scalar)
+=item B<RaiseError> (boolean, inherited)
 
 Implemented by DBI, no driver-specific impact.
 
-=item B<ChildHandles> (array ref)
+=item B<HandleError> (boolean, inherited)
 
 Implemented by DBI, no driver-specific impact.
 
-=item B<CompatMode> (boolean, inherited)
-
-Not used by this driver.
-
-=item B<InactiveDestroy> (boolean)
-
-Implemented by DBI, no driver-specific impact. If set to true, then 
-the disconnect() method will not be automatically called when the 
-database handle goes out of scope (e.g. when exiting after a fork).
-
-=item B<PrintWarn> (boolean, inherited)
+=item B<HandleSetErr> (code ref, inherited)
 
 Implemented by DBI, no driver-specific impact.
 
-=item B<PrintError> (boolean, inherited)
+=item B<ErrCount> (unsigned integer)
 
 Implemented by DBI, no driver-specific impact.
 
-=item B<RaiseError> (boolean, inherited)
-
-Implemented by DBI, no driver-specific impact.
-
-=item B<HandleError> (boolean, inherited)
-
-Implemented by DBI, no driver-specific impact.
-
-=item B<HandleSetErr> (code ref, inherited)
-
-Implemented by DBI, no driver-specific impact.
-
-=item B<ErrCount> (unsigned integer)
-
-Implemented by DBI, no driver-specific impact.
-
 =item B<ShowErrorStatement> (boolean, inherited)
-
-Implemented by DBI, no driver-specific impact.
-
-=item B<TraceLevel> (integer, inherited)
 
 Implemented by DBI, no driver-specific impact.
 
@@ -2190,6 +2199,22 @@
 Supported by this driver as proposed by DBI. This method is similar to the
 SQL function C<RTRIM>.
 
+=item B<Taint> (boolean, inherited)
+
+Implemented by DBI, no driver-specific impact.
+
+=item B<TaintIn> (boolean, inherited)
+
+Implemented by DBI, no driver-specific impact.
+
+=item B<TaintOut> (boolean, inherited)
+
+Implemented by DBI, no driver-specific impact.
+
+=item B<Profile> (inherited)
+
+Implemented by DBI, no driver-specific impact.
+
 =item B<LongReadLen> (integer, inherited)
 
 Not used by this driver.
@@ -2198,21 +2223,9 @@
 
 Not used by this driver.
 
-=item B<Taint> (boolean, inherited)
-
-Implemented by DBI, no driver-specific impact.
-
-=item B<TaintIn> (boolean, inherited)
-
-Implemented by DBI, no driver-specific impact.
-
-=item B<TaintOut> (boolean, inherited)
-
-Implemented by DBI, no driver-specific impact.
-
-=item B<Profile> (inherited)
-
-Implemented by DBI, no driver-specific impact.
+=item B<CompatMode> (boolean, inherited)
+
+Not used by this driver.
 
 =back
 

Modified: trunk/libdbd-pg-perl/README
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/README?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/README (original)
+++ trunk/libdbd-pg-perl/README Fri Jul 11 13:53:01 2008
@@ -1,12 +1,12 @@
 
 DBD::Pg  --  the DBI PostgreSQL interface for Perl
 
-# $Id: README 11486 2008-07-06 02:41:10Z turnstep $
+# $Id: README 11516 2008-07-10 17:15:06Z turnstep $
 
 DESCRIPTION:
 ------------
 
-This is version 2.8.3 of DBD::Pg.  The web site for this interface, and 
+This is version 2.8.4 of DBD::Pg.  The web site for this interface, and 
 the latest version, can be found at:
 
 	http://search.cpan.org/dist/DBD-Pg/

Modified: trunk/libdbd-pg-perl/SIGNATURE
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/SIGNATURE?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/SIGNATURE (original)
+++ trunk/libdbd-pg-perl/SIGNATURE Fri Jul 11 13:53:01 2008
@@ -14,45 +14,45 @@
 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: RIPEMD160
 
-SHA1 f0ec5e26a58bb8848c779560f654d7ff6444bd62 .perlcriticrc
-SHA1 52d06d454d8ed494770bef4d10819db2f673ed00 Changes
+SHA1 3df5dd8bb3a3881f50cb1c2025be8c77580cda1c .perlcriticrc
+SHA1 1a08c60e06b305eeaf25e25977bc9870749a9726 Changes
 SHA1 4d91c71e5dbb19ece1505ab75c36d00a744bb076 MANIFEST
 SHA1 22055b195f5cf15d7909e8a08468e617f46154e7 MANIFEST.SKIP
-SHA1 1ededdc83d4f9006a05f6f7a91e310a0bdbd4639 META.yml
-SHA1 cc62225fbcba989c9de5e0e4f200f7d374ee097a Makefile.PL
+SHA1 2b77565e5b0fe9718fca83ef87d18d980d6c0396 META.yml
+SHA1 210b672ad13c4fa2711b149ee3a74b1211f0ee1d Makefile.PL
 SHA1 c51356c52c139265e20a2ad33bc8d3ee04f6ff48 Pg.h
-SHA1 f1a577d33a16c7dbb61e5d989d8cd8d3caf4c5c1 Pg.pm
+SHA1 d8255a5a7d18ce5bae1c3868ca08b685bf63da51 Pg.pm
 SHA1 06d991c871e5f2b3b900990fc71e6207c94ad8cf Pg.xs
-SHA1 acd2bf5ec696ec3e28a15527bcc67e286fcead5b README
+SHA1 84192b2ae7414f353d77cb437dd528144644eeb4 README
 SHA1 283327a19b823faa386bcc85d5104baca40aaa35 README.dev
 SHA1 968d5fad61bce160b31a9cb1a21dd240b9df930f README.win32
 SHA1 0d189a3149a324fa78227f280d50eadc1377671f TODO
 SHA1 2ee3930895ededd7253a3f9ce3bd9f6ed5bdc224 dbdimp.c
 SHA1 9a5244ebe27af6f18c5dc8713fe8aecaa334134e dbdimp.h
 SHA1 6c33bcf138e577722283bef02fceb8cbce4d100d dbivport.h
-SHA1 7c774c358cdc5d9a4cc8e6e2501781f1aa3ace68 lib/Bundle/DBD/Pg.pm
+SHA1 66bafb5d4988457f8534dfc09c447f50f45da7cf lib/Bundle/DBD/Pg.pm
 SHA1 76a2c65c065a93775ceadf933a5d38bb25c8afa4 quote.c
 SHA1 0a1fdd0406c5c367a9aba366d1d35cfa8d5272ae quote.h
-SHA1 a1325525a95708d9830f9a38bc8686b74dcacbe0 t/00-signature.t
-SHA1 aa173cb6f58fc7ed0fd956a8060508f487f43bc4 t/00basic.t
-SHA1 75611540ff9ce3c7bdaa3b72db86a3b91bc46f43 t/01connect.t
-SHA1 5a3e779b594e1f76dcf517967821919dd20ea386 t/01constants.t
-SHA1 8a2996b9941223bf9b5c5c9f998e0f584c605818 t/02attribs.t
-SHA1 f1becf1316c77de3b633bb86fa71b2a2d54ec5be t/03dbmethod.t
-SHA1 bbf787b50b7c9a229bcb49618e35f5731c2b8749 t/03smethod.t
-SHA1 23e128452b832d7a560173ad1bd694fe532533f3 t/04misc.t
-SHA1 67a221db7e4820085aad45595143c46d4046fe17 t/06bytea.t
-SHA1 538fe466798e0b363f659fb31d6a9f1710baff40 t/07copy.t
-SHA1 328ce6e1ded36646f1183ae79ad3bcef2826caab t/08async.t
-SHA1 46c7bd09f1ca64453e3bbf6d5585d546a0331311 t/09arrays.t
-SHA1 4dfe6c0c5709908f7aa18dd1974dc2bfcf309f2b t/12placeholders.t
-SHA1 6f257eaa67fe8c34a75402f97240c2e2e333dfb9 t/20savepoints.t
-SHA1 4add8b87078148c1d34376e2c6cb44ff3051a53a t/99_perlcritic.t
-SHA1 748e58139d804a862f43547c40da527fda30425f t/99_pod.t
-SHA1 e58283b72a2b812e5fa815c82823de282eb27a99 t/99_spellcheck.t
-SHA1 a1ed49487f7fd0cf0006c74a0a2d1e53b9b5ecd4 t/99_yaml.t
-SHA1 7b8c49055fe11bcb814fb1a751ac4aba774c59cc t/99cleanup.t
-SHA1 f2602a02263e8a23b23544d7d74caabee702a172 t/dbdpg_test_setup.pl
+SHA1 93aa7e8cae0a361d1e6163dea0281ebff41f3c5f t/00-signature.t
+SHA1 073baf503a601ceeb49516d61bd275f0c1e51563 t/00basic.t
+SHA1 8f149f4f4b5e85ef47cfc389784e769f3e976729 t/01connect.t
+SHA1 ec842e6aaf11d6a55809318d69bd11ce8245092f t/01constants.t
+SHA1 9e7a8f54775a6d252ed312f7dea37972c4b3d426 t/02attribs.t
+SHA1 0d0a07674d2c493601a6807d22c2c8f2bdbbcd91 t/03dbmethod.t
+SHA1 7ce47f4163e23b3f3df589487707257f5158001a t/03smethod.t
+SHA1 910d6c2234d77a74a49cf189b6c799e13bf75280 t/04misc.t
+SHA1 ee7ecab04b202d5cd8816fbb8c2703971161dd53 t/06bytea.t
+SHA1 2aac29d06766d0edbf0848c433c2ff837908e6ea t/07copy.t
+SHA1 1413c886eaf1714db1cf8abfb989dabfd86dee87 t/08async.t
+SHA1 bbd13111ba3619b7b35542e56b56707746321ae4 t/09arrays.t
+SHA1 ee401c485a5c6f36844268eac0e95485359790bf t/12placeholders.t
+SHA1 85b5df8ef0c78b1d2d0018d874c62af7ef01a28f t/20savepoints.t
+SHA1 9041f782c66a9248e777e7f9dc1c545cea0996e9 t/99_perlcritic.t
+SHA1 9f94e06ec6b6a27512f1f4c638635e4095ae6be7 t/99_pod.t
+SHA1 1bf0bd67e80e6936aca67244bb5a7a28c6cc6b5a t/99_spellcheck.t
+SHA1 540fb0b335d5af08fcc322f18c4166671b50a89b t/99_yaml.t
+SHA1 09cbe5b43b6692d0779e0503790414b5fe758970 t/99cleanup.t
+SHA1 dcbbbbedd302ee77497b730ced93f1df42cde9c5 t/dbdpg_test_setup.pl
 SHA1 bc4a58bdd5e853139f9e1fc6129f83e50a07a2c6 t/lib/App/Info.pm
 SHA1 58befda00c12b1721875262505112203bf230450 t/lib/App/Info/Handler.pm
 SHA1 b5bf85b12a5fc207c44113a9c028fb7fbd68531f t/lib/App/Info/Handler/Prompt.pm
@@ -65,7 +65,7 @@
 SHA1 f07cd5ecaeb854c81ceb9206364979cf607e6546 win32.mak
 -----BEGIN PGP SIGNATURE-----
 
-iEYEAREDAAYFAkhxd2MACgkQvJuQZxSWSsjqywCfTKzWnd47vtRYZ84t05RKP8Y5
-zFsAoOdIppO84zf1EINMzgJRSZYJpN3o
-=P9vt
+iEYEAREDAAYFAkh2UioACgkQvJuQZxSWSsg7EQCggojHK7g5Y5b/sfDoeff4JNvC
+uYoAn14Dt8s5QKMx6XoQ+KxTuyQc5sRx
+=rBa1
 -----END PGP SIGNATURE-----

Modified: trunk/libdbd-pg-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/debian/changelog?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/debian/changelog (original)
+++ trunk/libdbd-pg-perl/debian/changelog Fri Jul 11 13:53:01 2008
@@ -1,9 +1,7 @@
-libdbd-pg-perl (2.8.3-1) UNRELEASED; urgency=low
-
-  t/99_perlcritic.t fails
-  CPAN#37567 - already fixed; waiting for a new release
-
-  * New upstream release.
+libdbd-pg-perl (2.8.4-1) UNRELEASED; urgency=low
+
+  * New upstream release, fixes the perl-critic test failures
+    (closes: #490321).
 
  -- gregor herrmann <gregoa at debian.org>  Wed, 09 Jul 2008 18:55:01 +0200
 

Modified: trunk/libdbd-pg-perl/lib/Bundle/DBD/Pg.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/lib/Bundle/DBD/Pg.pm?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/lib/Bundle/DBD/Pg.pm (original)
+++ trunk/libdbd-pg-perl/lib/Bundle/DBD/Pg.pm Fri Jul 11 13:53:01 2008
@@ -4,7 +4,7 @@
 use strict;
 use warnings;
 
-$VERSION = '2.8.3';
+$VERSION = '2.8.4';
 
 1;
 

Modified: trunk/libdbd-pg-perl/t/00-signature.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/00-signature.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/00-signature.t (original)
+++ trunk/libdbd-pg-perl/t/00-signature.t Fri Jul 11 13:53:01 2008
@@ -2,6 +2,7 @@
 
 ## Test that our SIGNATURE file is valid - requires TEST_SIGNATURE env
 
+use 5.006;
 use strict;
 use warnings;
 use Test::More;

Modified: trunk/libdbd-pg-perl/t/00basic.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/00basic.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/00basic.t (original)
+++ trunk/libdbd-pg-perl/t/00basic.t Fri Jul 11 13:53:01 2008
@@ -3,6 +3,7 @@
 ## Simply test that we can load the DBI and DBD::Pg modules,
 ## and that the latter gives a good version
 
+use 5.006;
 use strict;
 use warnings;
 use Test::More tests => 3;

Modified: trunk/libdbd-pg-perl/t/01connect.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/01connect.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/01connect.t (original)
+++ trunk/libdbd-pg-perl/t/01connect.t Fri Jul 11 13:53:01 2008
@@ -3,6 +3,7 @@
 ## Make sure we can connect and disconnect cleanly
 ## All tests are stopped if we cannot make the first connect
 
+use 5.006;
 use strict;
 use warnings;
 use DBI;
@@ -141,7 +142,7 @@
 		$connerror =~ s/.+?failed: //;
 		$connerror =~ s{\n at t/dbdpg.*}{}m;
 		if ($connerror =~ /create semaphores/) {
-			$connerror =~ s/.*(FATAL.*?)HINT.*/$1/m;
+			$connerror =~ s/.*(FATAL.*?)HINT.*/$1/sm;
 		}
 		$extra .= "\nError was: $connerror";
 	}

Modified: trunk/libdbd-pg-perl/t/01constants.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/01constants.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/01constants.t (original)
+++ trunk/libdbd-pg-perl/t/01constants.t Fri Jul 11 13:53:01 2008
@@ -1,5 +1,6 @@
 #!perl
 
+use 5.006;
 use strict;
 ## We cannot 'use warnings' here as PG_TSQUERY and others trip it up
 ## no critic (RequireUseWarnings)

Modified: trunk/libdbd-pg-perl/t/02attribs.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/02attribs.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/02attribs.t (original)
+++ trunk/libdbd-pg-perl/t/02attribs.t Fri Jul 11 13:53:01 2008
@@ -2,6 +2,7 @@
 
 ## Test all handle attributes: database, statement, and generic ("any")
 
+use 5.006;
 use strict;
 use warnings;
 use Test::More;

Modified: trunk/libdbd-pg-perl/t/03dbmethod.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/03dbmethod.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/03dbmethod.t (original)
+++ trunk/libdbd-pg-perl/t/03dbmethod.t Fri Jul 11 13:53:01 2008
@@ -10,6 +10,7 @@
 ## "pg_savepoint", "pg_release", "pg_rollback_to" (see 20savepoints.t)
 ## "pg_putline", "pg_getline", "pg_endcopy" (see 07copy.t)
 
+use 5.006;
 use strict;
 use warnings;
 use Data::Dumper;
@@ -1346,7 +1347,7 @@
 $t='DB handle method "pg_notifies" returns the correct values';
 $dbh->do("NOTIFY $notify_name");
 $dbh->commit();
-$info = $dbh->pg_notifies;;
+$info = $dbh->pg_notifies;
 is_deeply ($info, [$notify_name, $pid, ''], $t);
 
 #

Modified: trunk/libdbd-pg-perl/t/03smethod.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/03smethod.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/03smethod.t (original)
+++ trunk/libdbd-pg-perl/t/03smethod.t Fri Jul 11 13:53:01 2008
@@ -6,6 +6,7 @@
 ## "finish"
 ## "dump_results"
 
+use 5.006;
 use strict;
 use warnings;
 use Test::More;

Modified: trunk/libdbd-pg-perl/t/04misc.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/04misc.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/04misc.t (original)
+++ trunk/libdbd-pg-perl/t/04misc.t Fri Jul 11 13:53:01 2008
@@ -2,6 +2,7 @@
 
 ## Various stuff that does not go elsewhere
 
+use 5.006;
 use strict;
 use warnings;
 use Test::More;

Modified: trunk/libdbd-pg-perl/t/06bytea.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/06bytea.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/06bytea.t (original)
+++ trunk/libdbd-pg-perl/t/06bytea.t Fri Jul 11 13:53:01 2008
@@ -2,6 +2,7 @@
 
 ## Test bytea handling
 
+use 5.006;
 use strict;
 use warnings;
 use Test::More;

Modified: trunk/libdbd-pg-perl/t/07copy.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/07copy.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/07copy.t (original)
+++ trunk/libdbd-pg-perl/t/07copy.t Fri Jul 11 13:53:01 2008
@@ -2,6 +2,7 @@
 
 ## Test the COPY functionality
 
+use 5.006;
 use strict;
 use warnings;
 use Data::Dumper;
@@ -336,7 +337,7 @@
 		$dbh->pg_getcopydata($newvar);
 	};
 	is ($@, q{}, $t);
-};
+}
 
 #
 # Make sure rollback and commit reset our internal copystate tracking

Modified: trunk/libdbd-pg-perl/t/08async.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/08async.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/08async.t (original)
+++ trunk/libdbd-pg-perl/t/08async.t Fri Jul 11 13:53:01 2008
@@ -2,6 +2,7 @@
 
 ## Test asynchronous queries
 
+use 5.006;
 use strict;
 use warnings;
 use Test::More;
@@ -271,7 +272,7 @@
 
 	$sth->finish();
 
-}; ## end of pg_sleep skip
+} ## end of pg_sleep skip
 
 
 $t=q{Method execute() works when prepare has PG_ASYNC flag};

Modified: trunk/libdbd-pg-perl/t/09arrays.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/09arrays.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/09arrays.t (original)
+++ trunk/libdbd-pg-perl/t/09arrays.t Fri Jul 11 13:53:01 2008
@@ -2,6 +2,7 @@
 
 ## Test arrays
 
+use 5.006;
 use strict;
 use warnings;
 use Test::More;

Modified: trunk/libdbd-pg-perl/t/12placeholders.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/12placeholders.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/12placeholders.t (original)
+++ trunk/libdbd-pg-perl/t/12placeholders.t Fri Jul 11 13:53:01 2008
@@ -2,6 +2,7 @@
 
 ## Test of placeholders
 
+use 5.006;
 use strict;
 use warnings;
 use Test::More;

Modified: trunk/libdbd-pg-perl/t/20savepoints.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/20savepoints.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/20savepoints.t (original)
+++ trunk/libdbd-pg-perl/t/20savepoints.t Fri Jul 11 13:53:01 2008
@@ -2,6 +2,7 @@
 
 ## Test savepoint functionality
 
+use 5.006;
 use strict;
 use warnings;
 use Test::More;

Modified: trunk/libdbd-pg-perl/t/99_perlcritic.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/99_perlcritic.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/99_perlcritic.t (original)
+++ trunk/libdbd-pg-perl/t/99_perlcritic.t Fri Jul 11 13:53:01 2008
@@ -4,6 +4,7 @@
 ## This is highly customized, so take with a grain of salt
 ## Requires TEST_CRITIC to be set
 
+use 5.006;
 use strict;
 use warnings;
 use Test::More;

Modified: trunk/libdbd-pg-perl/t/99_pod.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/99_pod.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/99_pod.t (original)
+++ trunk/libdbd-pg-perl/t/99_pod.t Fri Jul 11 13:53:01 2008
@@ -3,6 +3,7 @@
 ## Check our Pod, requires Test::Pod
 ## Also done if available: Test::Pod::Coverage
 
+use 5.006;
 use strict;
 use warnings;
 use Test::More;

Modified: trunk/libdbd-pg-perl/t/99_spellcheck.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/99_spellcheck.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/99_spellcheck.t (original)
+++ trunk/libdbd-pg-perl/t/99_spellcheck.t Fri Jul 11 13:53:01 2008
@@ -3,6 +3,7 @@
 ## Spellcheck as much as we can
 ## Requires TEST_SPELL to be set
 
+use 5.006;
 use strict;
 use warnings;
 use Test::More;

Modified: trunk/libdbd-pg-perl/t/99_yaml.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/99_yaml.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/99_yaml.t (original)
+++ trunk/libdbd-pg-perl/t/99_yaml.t Fri Jul 11 13:53:01 2008
@@ -2,6 +2,7 @@
 
 ## Test META.yml for YAMLiciousness, requires Test::YAML::Meta
 
+use 5.006;
 use strict;
 use warnings;
 use Test::More;

Modified: trunk/libdbd-pg-perl/t/99cleanup.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/99cleanup.t?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/99cleanup.t (original)
+++ trunk/libdbd-pg-perl/t/99cleanup.t Fri Jul 11 13:53:01 2008
@@ -3,6 +3,7 @@
 ## Cleanup all database objects we may have created
 ## Shutdown the test database if we created one
 
+use 5.006;
 use strict;
 use warnings;
 use Test::More tests => 1;

Modified: trunk/libdbd-pg-perl/t/dbdpg_test_setup.pl
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/dbdpg_test_setup.pl?rev=23023&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/dbdpg_test_setup.pl (original)
+++ trunk/libdbd-pg-perl/t/dbdpg_test_setup.pl Fri Jul 11 13:53:01 2008
@@ -6,6 +6,7 @@
 use Data::Dumper;
 use DBI;
 use Cwd;
+use 5.006;
 select(($|=1,select(STDERR),$|=1)[1]);
 
 my @schemas =
@@ -85,12 +86,11 @@
 			$testdsn =~ s/$alias\s*=(\w+)/'db="'.lc $2.'"'/e;
 		}
 
-		eval {
+		goto GOTDBH if eval {
 			$dbh = DBI->connect($testdsn, $testuser, '',
 								{RaiseError => 1, PrintError => 0, AutoCommit => 1});
-		};
-
-		goto GOTDBH unless $@;
+			1;
+		};
 
 		if ($@ =~ /invalid connection option/) {
 			return $helpconnect, $@, undef;
@@ -229,7 +229,12 @@
 		last GETHANDLE if $@;
 		if (!defined $info or ($info !~ /\@postgresql\.org/ and $info !~ /run as root/)) {
 			if (defined $info) {
-				$@ = "Bad initdb output: $info";
+				if ($info !~ /\w/) {
+					$@ = 'initdb not found: cannot run full tests without a Postgres database';
+				}
+				else {
+					$@ = "Bad initdb output: $info";
+				}
 			}
 			else {
 				my $msg = 'Failed to run initdb.';




More information about the Pkg-perl-cvs-commits mailing list