r23036 - in /trunk/libwww-facebook-api-perl/debian: REAMDE.source changelog control patches/ patches/perlcritic.patch patches/series rules

gregoa at users.alioth.debian.org gregoa at users.alioth.debian.org
Fri Jul 11 14:55:35 UTC 2008


Author: gregoa
Date: Fri Jul 11 14:55:35 2008
New Revision: 23036

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=23036
Log:
* Add patch perlcritic.patch to fix FBTFS because of failures in
  t/perlcritic.t; add quilt framework and debian/README.source
  (closes: #490325).
* Add /me to Uploaders.

Added:
    trunk/libwww-facebook-api-perl/debian/REAMDE.source
    trunk/libwww-facebook-api-perl/debian/patches/
    trunk/libwww-facebook-api-perl/debian/patches/perlcritic.patch
    trunk/libwww-facebook-api-perl/debian/patches/series
Modified:
    trunk/libwww-facebook-api-perl/debian/changelog
    trunk/libwww-facebook-api-perl/debian/control
    trunk/libwww-facebook-api-perl/debian/rules

Added: trunk/libwww-facebook-api-perl/debian/REAMDE.source
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libwww-facebook-api-perl/debian/REAMDE.source?rev=23036&op=file
==============================================================================
--- trunk/libwww-facebook-api-perl/debian/REAMDE.source (added)
+++ trunk/libwww-facebook-api-perl/debian/REAMDE.source Fri Jul 11 14:55:35 2008
@@ -1,0 +1,4 @@
+This package uses quilt to manage patches against the upstream source.
+
+Please take a look at /usr/share/doc/quilt/README.source for further
+information about using quilt with Debian packages.

Modified: trunk/libwww-facebook-api-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libwww-facebook-api-perl/debian/changelog?rev=23036&op=diff
==============================================================================
--- trunk/libwww-facebook-api-perl/debian/changelog (original)
+++ trunk/libwww-facebook-api-perl/debian/changelog Fri Jul 11 14:55:35 2008
@@ -1,3 +1,12 @@
+libwww-facebook-api-perl (0.4.11-2) UNRELEASED; urgency=low
+
+  * Add patch perlcritic.patch to fix FBTFS because of failures in
+    t/perlcritic.t; add quilt framework and debian/README.source
+    (closes: #490325).
+  * Add /me to Uploaders.
+
+ -- gregor herrmann <gregoa at debian.org>  Fri, 11 Jul 2008 16:45:46 +0200
+
 libwww-facebook-api-perl (0.4.11-1) unstable; urgency=low
 
   * Initial Release. (Closes: #487659)

Modified: trunk/libwww-facebook-api-perl/debian/control
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libwww-facebook-api-perl/debian/control?rev=23036&op=diff
==============================================================================
--- trunk/libwww-facebook-api-perl/debian/control (original)
+++ trunk/libwww-facebook-api-perl/debian/control Fri Jul 11 14:55:35 2008
@@ -1,13 +1,14 @@
 Source: libwww-facebook-api-perl
 Section: perl
 Priority: optional
-Build-Depends: debhelper (>= 7)
+Build-Depends: debhelper (>= 7), quilt (>= 0.40)
 Build-Depends-Indep: perl (>= 5.6.10-12), libwww-perl, libcrypt-ssleay-perl,
  libjson-any-perl, libjson-xs-perl, libtest-pod-perl,
  libtest-pod-coverage-perl, libtest-perl-critic-perl, libtest-mockobject-perl,
  perl-modules (>= 5.10) | libversion-perl, libio-string-perl
 Maintainer: Debian Perl Group <pkg-perl-maintainers at lists.alioth.debian.org>
-Uploaders: AGOSTINI Yves <agostini at univ-metz.fr>
+Uploaders: AGOSTINI Yves <agostini at univ-metz.fr>,
+ gregor herrmann <gregoa at debian.org>
 Standards-Version: 3.8.0
 Homepage: http://search.cpan.org/dist/WWW-Facebook-API/
 Vcs-Svn: svn://svn.debian.org/pkg-perl/trunk/libwww-facebook-api-perl/

Added: trunk/libwww-facebook-api-perl/debian/patches/perlcritic.patch
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libwww-facebook-api-perl/debian/patches/perlcritic.patch?rev=23036&op=file
==============================================================================
--- trunk/libwww-facebook-api-perl/debian/patches/perlcritic.patch (added)
+++ trunk/libwww-facebook-api-perl/debian/patches/perlcritic.patch Fri Jul 11 14:55:35 2008
@@ -1,0 +1,46 @@
+Author: gregor herrmann <gregoa at debian.org>
+Description: fix perl-critic test failures
+Bugs: #490325, CPAN#37617
+
+--- a/lib/WWW/Facebook/API.pm
++++ b/lib/WWW/Facebook/API.pm
+@@ -367,16 +367,15 @@
+     return 0   if $response =~ /\A"?false"?\Z/xms;
+ 
+     my $parser;
+-    eval { $parser = _parser() };
++    eval { $parser = _parser(); 1; } or do {
+ 
+     # Only load JSON::Any if we haven't already.  Lets the developers
+     # pick their choice of JSON modules (JSON::DWIW, for example)
+-    if ($@) {    ## no critic
+         ## no critic
+         eval q{use JSON::Any};
+         croak "Unable to load JSON module for parsing:$@\n" if $@;
+         $parser = _parser();
+-    }
++    };
+     carp 'JSON::Any is parsing with ' . $parser->handlerType if $self->debug;
+ 
+     return $parser->decode($response);
+--- a/lib/WWW/Facebook/API/Auth.pm
++++ b/lib/WWW/Facebook/API/Auth.pm
+@@ -12,6 +12,9 @@
+ 
+ use version; our $VERSION = qv('0.4.11');
+ 
++use Readonly;
++Readonly my $DEFAULT_SLEEP => 15;
++
+ sub create_token {
+     my $self = shift;
+     my $token;
+@@ -87,7 +90,7 @@
+     system qq($browser "$url");
+ 
+     # Give the user time to log in
+-    $args{'sleep'} ||= 15;
++    $args{'sleep'} ||= $DEFAULT_SLEEP;
+     sleep $args{'sleep'};
+ 
+     return $token;

Added: trunk/libwww-facebook-api-perl/debian/patches/series
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libwww-facebook-api-perl/debian/patches/series?rev=23036&op=file
==============================================================================
--- trunk/libwww-facebook-api-perl/debian/patches/series (added)
+++ trunk/libwww-facebook-api-perl/debian/patches/series Fri Jul 11 14:55:35 2008
@@ -1,0 +1,1 @@
+perlcritic.patch

Modified: trunk/libwww-facebook-api-perl/debian/rules
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libwww-facebook-api-perl/debian/rules?rev=23036&op=diff
==============================================================================
--- trunk/libwww-facebook-api-perl/debian/rules (original)
+++ trunk/libwww-facebook-api-perl/debian/rules Fri Jul 11 14:55:35 2008
@@ -1,11 +1,13 @@
 #!/usr/bin/make -f
 
+include /usr/share/quilt/quilt.make
+
 build: build-stamp
-build-stamp:
+build-stamp: $(QUILT_STAMPFN)
 	AUTHOR_TESTS=1 dh build
 	touch $@
 
-clean:
+clean: unpatch
 	dh $@
 
 install: install-stamp




More information about the Pkg-perl-cvs-commits mailing list