r21915 - in /branches/upstream/libcgi-session-perl/current: ./ lib/CGI/ lib/CGI/Session/ lib/CGI/Session/Driver/ lib/CGI/Session/ID/ lib/CGI/Session/Serialize/ lib/CGI/Session/Test/ t/
rmayorga-guest at users.alioth.debian.org
rmayorga-guest at users.alioth.debian.org
Fri Jun 20 01:43:51 UTC 2008
Author: rmayorga-guest
Date: Fri Jun 20 01:43:50 2008
New Revision: 21915
URL: http://svn.debian.org/wsvn/?sc=1&rev=21915
Log:
[svn-upgrade] Integrating new upstream version, libcgi-session-perl (4.32)
Added:
branches/upstream/libcgi-session-perl/current/t/load_with_undef.t
branches/upstream/libcgi-session-perl/current/t/new_with_undef.t
Modified:
branches/upstream/libcgi-session-perl/current/Changes
branches/upstream/libcgi-session-perl/current/MANIFEST
branches/upstream/libcgi-session-perl/current/META.yml
branches/upstream/libcgi-session-perl/current/lib/CGI/Session.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/DBI.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/db_file.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/file.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/mysql.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/postgresql.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/sqlite.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ErrorHandler.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/incr.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/md5.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/static.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/default.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/storable.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Test/Default.pm
branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Tutorial.pm
Modified: branches/upstream/libcgi-session-perl/current/Changes
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/Changes?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/Changes (original)
+++ branches/upstream/libcgi-session-perl/current/Changes Fri Jun 20 01:43:50 2008
@@ -1,5 +1,23 @@
CGI::Session Change Log
=====================================================================
+
+4.32 - Tuesday, June 17, 2008
+ * FIX: Packaging of 4.31 release was botched.
+
+4.31 - Tuesday, June 10, 2008
+ * FIX: Patch CGI::Session::Driver::DBI to check that the DBI handle still
+ exists before trying to ping it. This handles the case where the DBI
+ object is destroyed before the session object. See RT#35925.
+
+ * FIX: Patch CGI::Session::Driver::DBI's remove() which still hard-coded
+ the column name 'id' instead of using the new feature which allows
+ the user to specify the name of the column. See RT#36235.
+
+ * FIX: Patch POD yet again to emphasize that an explicit call to destroy()
+ should be followed by explicit call to flush(), in particular in the
+ case where the program is not exiting and hence auto-flushing is not
+ activated. Sections patched are 'A Warning about Auto-flushing' and
+ the docs for delete(). See RT#34668.
4.30 - Friday, April 25, 2008
@@ -320,4 +338,4 @@
* Bug in POD documentation is fixed (thanks to Graham Barr)
-$Id: Changes 406 2008-04-08 00:56:29Z ron $
+$Id: Changes 413 2008-06-09 02:13:27Z ron $
Modified: branches/upstream/libcgi-session-perl/current/MANIFEST
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/MANIFEST?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/MANIFEST (original)
+++ branches/upstream/libcgi-session-perl/current/MANIFEST Fri Jun 20 01:43:50 2008
@@ -23,6 +23,7 @@
Makefile.PL
MANIFEST This list of files
MANIFEST.SKIP
+META.yml
README
t/api3_db_file.t
t/api3_db_file_freezethaw.t
@@ -64,10 +65,11 @@
t/ip_matches.t
t/is_new.t
t/load.t
+t/load_with_undef.t
t/name.t
+t/new_with_undef.t
t/parse_dsn.t
t/remote_addr.t
t/str2seconds.t
t/symlink_db_file.t
t/symlink_file.t
-META.yml Module meta-data (added by MakeMaker)
Modified: branches/upstream/libcgi-session-perl/current/META.yml
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/META.yml?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/META.yml (original)
+++ branches/upstream/libcgi-session-perl/current/META.yml Fri Jun 20 01:43:50 2008
@@ -1,7 +1,7 @@
# http://module-build.sourceforge.net/META-spec.html
#XXXXXXX This is a prototype!!! It will change in the future!!! XXXXX#
name: CGI-Session
-version: 4.30
+version: 4.32
version_from: lib/CGI/Session.pm
installdirs: site
requires:
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session.pm
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/lib/CGI/Session.pm?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session.pm Fri Jun 20 01:43:50 2008
@@ -1,13 +1,13 @@
package CGI::Session;
-# $Id: Session.pm 407 2008-04-08 00:56:47Z ron $
+# $Id: Session.pm 415 2008-06-16 14:40:45Z markstos $
use strict;
use Carp;
use CGI::Session::ErrorHandler;
@CGI::Session::ISA = qw( CGI::Session::ErrorHandler );
-$CGI::Session::VERSION = '4.30';
+$CGI::Session::VERSION = '4.32';
$CGI::Session::NAME = 'CGISESSID';
$CGI::Session::IP_MATCH = 0;
@@ -447,7 +447,7 @@
return 1;
}
-# $Id: Session.pm 407 2008-04-08 00:56:47Z ron $
+# $Id: Session.pm 415 2008-06-16 14:40:45Z markstos $
=pod
@@ -463,34 +463,38 @@
$CGISESSID = $session->id();
- # send proper HTTP header with cookies:
+ # Send proper HTTP header with cookies:
print $session->header();
- # storing data in the session
+ # Storing data in the session:
$session->param('f_name', 'Sherzod');
# or
$session->param(-name=>'l_name', -value=>'Ruzmetov');
- # flush the data from memory to the storage driver at least before your
- # program finishes since auto-flushing can be unreliable
+ # Flush the data from memory to the storage driver at least before your
+ # program finishes since auto-flushing can be unreliable.
+ # Warning: A bug in your logic whereby the DBI handle has gone
+ # out of scope before flush() is called means flush() won't work
+ # (when the session is a database session), so don't do that.
$session->flush();
- # retrieving data
+ # Retrieving data:
my $f_name = $session->param('f_name');
# or
my $l_name = $session->param(-name=>'l_name');
- # clearing a certain session parameter
+ # Clearing a certain session parameter:
$session->clear(["l_name", "f_name"]);
- # expire '_is_logged_in' flag after 10 idle minutes:
+ # Expire '_is_logged_in' flag after 10 idle minutes:
$session->expire('is_logged_in', '+10m')
- # expire the session itself after 1 idle hour
+ # Expire the session itself after 1 idle hour:
$session->expire('+1h');
- # delete the session for good
+ # Delete the session for good:
$session->delete();
+ $session->flush(); # Recommended practice says use flush() after delete().
=head1 DESCRIPTION
@@ -506,6 +510,20 @@
program exits.
For instance, in a C<CGI::Application>-based program, C<sub teardown()> would be the appropriate place to do this.
+
+This is all part of what might be called "Object life-cycle 'v' Program life-cycle".
+
+In the simplest case the program has one object of type CGI::Session, and that object is destroyed when the
+program exits.
+
+If, however, you wish to delete objects explicitly, then each call to C<delete()> should be followed by a call
+to C<flush()>.
+
+Warning: A bug in your logic whereby the DBI handle has gone out
+out of scope before flush() is called means flush() won't work
+(when the session is a database session), so don't do that.
+
+For more detail, see the discussion of the C<delete()> method, below.
=head1 A Warning about UTF8
@@ -965,6 +983,10 @@
Consequently, always explicitly calling C<flush()> on the session before the program exits
should be regarded as mandatory until this problem is rectified.
+Warning: A bug in your logic whereby the DBI handle has gone out
+out of scope before flush() is called means flush() won't work
+(when the session is a database session), so don't do that.
+
=head2 atime()
Read-only method. Returns the last access time of the session in seconds from epoch. This time is used internally while
@@ -1130,8 +1152,12 @@
The intention is that in due course (of the program's execution) this will trigger L<flush()|/"flush">, and flush() will do the actual removal.
-However: Auto-flushing can be unreliable, and always explicitly calling C<flush()> on the session before the program exits
+However: Auto-flushing can be unreliable, and always explicitly calling C<flush()> on the session after C<delete()>
should be regarded as mandatory until this problem is rectified.
+
+Warning: A bug in your logic whereby the DBI handle has gone out
+out of scope before flush() is called means flush() won't work
+(when the session is a database session), so don't do that.
=head2 find( \&code )
@@ -1409,6 +1435,7 @@
Sherzod Ruzmetov E<lt>sherzodr at cpan.orgE<gt>, http://author.handalak.com/
Mark Stosberg became a co-maintainer during the development of 4.0. C<markstos at cpan.org>.
+Ron Savage became a co-maintainer during the development of 4.30. C<rsavage at cpan.org>.
=head1 SEE ALSO
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver.pm
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver.pm?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver.pm Fri Jun 20 01:43:50 2008
@@ -1,6 +1,6 @@
package CGI::Session::Driver;
-# $Id: Driver.pm 394 2008-03-22 02:35:30Z markstos $
+# $Id: Driver.pm 415 2008-06-16 14:40:45Z markstos $
use strict;
#use diagnostics;
@@ -8,7 +8,7 @@
use Carp;
use CGI::Session::ErrorHandler;
-$CGI::Session::Driver::VERSION = '4.30';
+$CGI::Session::Driver::VERSION = '4.31';
@CGI::Session::Driver::ISA = qw(CGI::Session::ErrorHandler);
sub new {
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/DBI.pm
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/DBI.pm?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/DBI.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/DBI.pm Fri Jun 20 01:43:50 2008
@@ -1,6 +1,6 @@
package CGI::Session::Driver::DBI;
-# $Id: DBI.pm 394 2008-03-22 02:35:30Z markstos $
+# $Id: DBI.pm 415 2008-06-16 14:40:45Z markstos $
use strict;
@@ -9,7 +9,7 @@
use CGI::Session::Driver;
@CGI::Session::Driver::DBI::ISA = ( "CGI::Session::Driver" );
-$CGI::Session::Driver::DBI::VERSION = '4.30';
+$CGI::Session::Driver::DBI::VERSION = '4.31';
sub init {
@@ -123,7 +123,7 @@
my ($sid) = @_;
croak "remove(): usage error" unless $sid;
- my $rc = $self->{Handle}->do( 'DELETE FROM '. $self->table_name .' WHERE id= ?',{},$sid );
+ my $rc = $self->{Handle}->do( 'DELETE FROM ' . $self->table_name . " WHERE $self->{IdColName}= ?", {}, $sid );
unless ( $rc ) {
croak "remove(): \$dbh->do failed!";
}
@@ -135,7 +135,7 @@
sub DESTROY {
my $self = shift;
- unless ( $self->{Handle} -> ping ) {
+ unless ( defined $self->{Handle} && $self->{Handle} -> ping ) {
$self->set_error(__PACKAGE__ . '::DESTROY(). Database handle has gone away');
return;
}
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/db_file.pm
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/db_file.pm?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/db_file.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/db_file.pm Fri Jun 20 01:43:50 2008
@@ -1,6 +1,6 @@
package CGI::Session::Driver::db_file;
-# $Id: db_file.pm 394 2008-03-22 02:35:30Z markstos $
+# $Id: db_file.pm 415 2008-06-16 14:40:45Z markstos $
use strict;
@@ -13,7 +13,7 @@
use vars qw( @ISA $VERSION $FILE_NAME $UMask $NO_FOLLOW );
@ISA = ( "CGI::Session::Driver" );
-$VERSION = '4.30';
+$VERSION = '4.31';
$FILE_NAME = "cgisess.db";
$UMask = 0660;
$NO_FOLLOW = eval { O_NOFOLLOW } || 0;
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/file.pm
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/file.pm?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/file.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/file.pm Fri Jun 20 01:43:50 2008
@@ -1,6 +1,6 @@
package CGI::Session::Driver::file;
-# $Id: file.pm 394 2008-03-22 02:35:30Z markstos $
+# $Id: file.pm 415 2008-06-16 14:40:45Z markstos $
use strict;
@@ -19,7 +19,7 @@
}
@CGI::Session::Driver::file::ISA = ( "CGI::Session::Driver" );
-$CGI::Session::Driver::file::VERSION = '4.30';
+$CGI::Session::Driver::file::VERSION = '4.31';
$FileName = "cgisess_%s";
$NoFlock = 0;
$UMask = 0660;
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/mysql.pm
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/mysql.pm?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/mysql.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/mysql.pm Fri Jun 20 01:43:50 2008
@@ -1,13 +1,13 @@
package CGI::Session::Driver::mysql;
-# $Id: mysql.pm 394 2008-03-22 02:35:30Z markstos $
+# $Id: mysql.pm 415 2008-06-16 14:40:45Z markstos $
use strict;
use Carp;
use CGI::Session::Driver::DBI;
@CGI::Session::Driver::mysql::ISA = qw( CGI::Session::Driver::DBI );
-$CGI::Session::Driver::mysql::VERSION = '4.30';
+$CGI::Session::Driver::mysql::VERSION = '4.31';
sub _mk_dsnstr {
my ($class, $dsn) = @_;
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/postgresql.pm
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/postgresql.pm?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/postgresql.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/postgresql.pm Fri Jun 20 01:43:50 2008
@@ -1,6 +1,6 @@
package CGI::Session::Driver::postgresql;
-# $Id: postgresql.pm 394 2008-03-22 02:35:30Z markstos $
+# $Id: postgresql.pm 415 2008-06-16 14:40:45Z markstos $
# CGI::Session::Driver::postgresql - PostgreSQL driver for CGI::Session
#
@@ -15,7 +15,7 @@
use CGI::Session::Driver::DBI;
use DBD::Pg qw(PG_BYTEA PG_TEXT);
-$CGI::Session::Driver::postgresql::VERSION = '4.30';
+$CGI::Session::Driver::postgresql::VERSION = '4.31';
@CGI::Session::Driver::postgresql::ISA = qw( CGI::Session::Driver::DBI );
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/sqlite.pm
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/sqlite.pm?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/sqlite.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Driver/sqlite.pm Fri Jun 20 01:43:50 2008
@@ -1,6 +1,6 @@
package CGI::Session::Driver::sqlite;
-# $Id: sqlite.pm 394 2008-03-22 02:35:30Z markstos $
+# $Id: sqlite.pm 415 2008-06-16 14:40:45Z markstos $
use strict;
@@ -9,7 +9,7 @@
use DBI qw(SQL_BLOB);
use Fcntl;
-$CGI::Session::Driver::sqlite::VERSION = '4.30';
+$CGI::Session::Driver::sqlite::VERSION = '4.31';
sub init {
my $self = shift;
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ErrorHandler.pm
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ErrorHandler.pm?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ErrorHandler.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ErrorHandler.pm Fri Jun 20 01:43:50 2008
@@ -1,9 +1,9 @@
package CGI::Session::ErrorHandler;
-# $Id: ErrorHandler.pm 394 2008-03-22 02:35:30Z markstos $
+# $Id: ErrorHandler.pm 415 2008-06-16 14:40:45Z markstos $
use strict;
-$CGI::Session::ErrorHandler::VERSION = '4.30';
+$CGI::Session::ErrorHandler::VERSION = '4.31';
=pod
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/incr.pm
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/incr.pm?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/incr.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/incr.pm Fri Jun 20 01:43:50 2008
@@ -1,6 +1,6 @@
package CGI::Session::ID::incr;
-# $Id: incr.pm 394 2008-03-22 02:35:30Z markstos $
+# $Id: incr.pm 415 2008-06-16 14:40:45Z markstos $
use strict;
use File::Spec;
@@ -8,7 +8,7 @@
use Fcntl qw( :DEFAULT :flock );
use CGI::Session::ErrorHandler;
-$CGI::Session::ID::incr::VERSION = '4.30';
+$CGI::Session::ID::incr::VERSION = '4.31';
@CGI::Session::ID::incr::ISA = qw( CGI::Session::ErrorHandler );
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/md5.pm
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/md5.pm?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/md5.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/md5.pm Fri Jun 20 01:43:50 2008
@@ -1,12 +1,12 @@
package CGI::Session::ID::md5;
-# $Id: md5.pm 394 2008-03-22 02:35:30Z markstos $
+# $Id: md5.pm 415 2008-06-16 14:40:45Z markstos $
use strict;
use Digest::MD5;
use CGI::Session::ErrorHandler;
-$CGI::Session::ID::md5::VERSION = '4.30';
+$CGI::Session::ID::md5::VERSION = '4.31';
@CGI::Session::ID::md5::ISA = qw( CGI::Session::ErrorHandler );
*generate = \&generate_id;
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/static.pm
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/static.pm?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/static.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/ID/static.pm Fri Jun 20 01:43:50 2008
@@ -1,12 +1,12 @@
package CGI::Session::ID::static;
-# $Id: static.pm 394 2008-03-22 02:35:30Z markstos $
+# $Id: static.pm 415 2008-06-16 14:40:45Z markstos $
use strict;
use Carp ("croak");
use CGI::Session::ErrorHandler;
-$CGI::Session::ID::static::VERSION = '4.30';
+$CGI::Session::ID::static::VERSION = '4.31';
@::CGI::Session::ID::static::ISA = qw( CGI::Session::ErrorHandler );
sub generate_id {
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/default.pm
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/default.pm?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/default.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/default.pm Fri Jun 20 01:43:50 2008
@@ -1,6 +1,6 @@
package CGI::Session::Serialize::default;
-# $Id: default.pm 394 2008-03-22 02:35:30Z markstos $
+# $Id: default.pm 415 2008-06-16 14:40:45Z markstos $
use strict;
use Safe;
@@ -12,7 +12,7 @@
require overload;
@CGI::Session::Serialize::default::ISA = ( "CGI::Session::ErrorHandler" );
-$CGI::Session::Serialize::default::VERSION = '4.30';
+$CGI::Session::Serialize::default::VERSION = '4.31';
sub freeze {
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/storable.pm
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/storable.pm?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/storable.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Serialize/storable.pm Fri Jun 20 01:43:50 2008
@@ -1,12 +1,12 @@
package CGI::Session::Serialize::storable;
-# $Id: storable.pm 394 2008-03-22 02:35:30Z markstos $
+# $Id: storable.pm 415 2008-06-16 14:40:45Z markstos $
use strict;
use Storable;
require CGI::Session::ErrorHandler;
-$CGI::Session::Serialize::storable::VERSION = '4.30';
+$CGI::Session::Serialize::storable::VERSION = '4.31';
@CGI::Session::Serialize::ISA = ( "CGI::Session::ErrorHandler" );
=pod
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Test/Default.pm
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Test/Default.pm?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Test/Default.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Test/Default.pm Fri Jun 20 01:43:50 2008
@@ -11,7 +11,7 @@
sub ok_later (&;$);
-$CGI::Session::Test::Default::VERSION = '4.30';
+$CGI::Session::Test::Default::VERSION = '4.31';
=head1 CGI::Session::Test::Default
Modified: branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Tutorial.pm
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Tutorial.pm?rev=21915&op=diff
==============================================================================
--- branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Tutorial.pm (original)
+++ branches/upstream/libcgi-session-perl/current/lib/CGI/Session/Tutorial.pm Fri Jun 20 01:43:50 2008
@@ -1,8 +1,8 @@
package CGI::Session::Tutorial;
-# $Id: Tutorial.pm 394 2008-03-22 02:35:30Z markstos $
-
-$CGI::Session::Tutorial::VERSION = '4.30';
+# $Id: Tutorial.pm 415 2008-06-16 14:40:45Z markstos $
+
+$CGI::Session::Tutorial::VERSION = '4.31';
=pod
Added: branches/upstream/libcgi-session-perl/current/t/load_with_undef.t
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/t/load_with_undef.t?rev=21915&op=file
==============================================================================
--- branches/upstream/libcgi-session-perl/current/t/load_with_undef.t (added)
+++ branches/upstream/libcgi-session-perl/current/t/load_with_undef.t Fri Jun 20 01:43:50 2008
@@ -1,0 +1,45 @@
+#!/usr/bin/perl
+
+use strict;
+use warnings;
+
+use CGI;
+use CGI::Session;
+use Test::More tests => 6;
+
+# ---------------
+
+{
+my($session) = CGI::Session -> load(undef);
+
+isa_ok($session, 'CGI::Session', 'load(undef) returns an object which');
+
+my($id) = $session -> id();
+
+is($id, undef, "load(undef)'s session object returns an id which /is/ undef");
+}
+
+{
+my($q) = CGI -> new();
+my($session) = CGI::Session -> load($q);
+
+isa_ok($session, 'CGI::Session', 'load($q without CGISESSID) returns an object which');
+
+my($id) = $session -> id();
+
+is($id, undef, "load(\$q without CGISESSID)'s session object returns an id which /is/ undef");
+}
+
+{
+my($q) = CGI -> new();
+
+$q -> param(CGISESSID => 'Purple cats is weird');
+
+my($session) = CGI::Session -> load($q);
+
+isa_ok($session, 'CGI::Session', 'load($q with fake CGISESSID) returns an object which');
+
+my($id) = $session -> id();
+
+is($id, undef, "load(\$q with fake CGISESSID)'s session object returns an id which /is/ undef");
+}
Added: branches/upstream/libcgi-session-perl/current/t/new_with_undef.t
URL: http://svn.debian.org/wsvn/branches/upstream/libcgi-session-perl/current/t/new_with_undef.t?rev=21915&op=file
==============================================================================
--- branches/upstream/libcgi-session-perl/current/t/new_with_undef.t (added)
+++ branches/upstream/libcgi-session-perl/current/t/new_with_undef.t Fri Jun 20 01:43:50 2008
@@ -1,0 +1,45 @@
+#!/usr/bin/perl
+
+use strict;
+use warnings;
+
+use CGI;
+use CGI::Session;
+use Test::More tests => 6;
+
+# ---------------
+
+{
+my($session) = CGI::Session -> new(undef);
+
+isa_ok($session, 'CGI::Session', 'new(undef) returns an object which');
+
+my($id) = $session -> id();
+
+isnt($id, undef, "new(undef)'s session object returns an id which is /not/ undef");
+}
+
+{
+my($q) = CGI -> new();
+my($session) = CGI::Session -> new($q);
+
+isa_ok($session, 'CGI::Session', 'new($q without CGISESSID) returns an object which');
+
+my($id) = $session -> id();
+
+isnt($id, undef, "new(\$q without CGISESSID)'s session object returns an id which is /not/ undef");
+}
+
+{
+my($q) = CGI -> new();
+
+$q -> param(CGISESSID => 'Purple cats is weird');
+
+my($session) = CGI::Session -> new($q);
+
+isa_ok($session, 'CGI::Session', 'new($q with fake CGISESSID) returns an object which');
+
+my($id) = $session -> id();
+
+isnt($id, undef, "new(\$q with fake CGISESSID)'s session object returns an id which is /not/ undef");
+}
More information about the Pkg-perl-cvs-commits
mailing list