r19986 - in /trunk/libdbd-pg-perl: Changes META.yml Makefile.PL Pg.pm README SIGNATURE dbdimp.c debian/changelog lib/Bundle/DBD/Pg.pm t/09arrays.t t/99_spellcheck.t t/dbdpg_test_setup.pl

gregoa at users.alioth.debian.org gregoa at users.alioth.debian.org
Thu May 15 20:37:53 UTC 2008


Author: gregoa
Date: Thu May 15 20:37:53 2008
New Revision: 19986

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=19986
Log:
New upstream release.

Modified:
    trunk/libdbd-pg-perl/Changes
    trunk/libdbd-pg-perl/META.yml
    trunk/libdbd-pg-perl/Makefile.PL
    trunk/libdbd-pg-perl/Pg.pm
    trunk/libdbd-pg-perl/README
    trunk/libdbd-pg-perl/SIGNATURE
    trunk/libdbd-pg-perl/dbdimp.c
    trunk/libdbd-pg-perl/debian/changelog
    trunk/libdbd-pg-perl/lib/Bundle/DBD/Pg.pm
    trunk/libdbd-pg-perl/t/09arrays.t
    trunk/libdbd-pg-perl/t/99_spellcheck.t
    trunk/libdbd-pg-perl/t/dbdpg_test_setup.pl

Modified: trunk/libdbd-pg-perl/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/Changes?rev=19986&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/Changes (original)
+++ trunk/libdbd-pg-perl/Changes Thu May 15 20:37:53 2008
@@ -1,6 +1,13 @@
 ('GSM' is Greg Sabino Mullane, greg at turnstep.com)
 
-2.7.1 Released May 11, 2008
+2.7.2 Released May 14, 2008
+
+	- Handle embedded commas in quotes properly when destringifying 
+		arrays.(CPAN bug #35862) [GSM]
+	- Fix typo in docs with trace_parser_flags() (Martin J. Evans)
+	- More testing tweaks [GSM]
+
+2.7.1 Released May 11, 2008 (subversion r11250)
 
 	- Yet more minor testing tweaks. [GSM]
 

Modified: trunk/libdbd-pg-perl/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/META.yml?rev=19986&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/META.yml (original)
+++ trunk/libdbd-pg-perl/META.yml Thu May 15 20:37:53 2008
@@ -1,6 +1,6 @@
 --- #YAML:1.0
 name                  : DBD-Pg
-version               : 2.7.1
+version               : 2.7.2
 abstract              : DBI PostgreSQL interface
 author:              
   - Greg Sabino Mullane <greg at turnstep.com>
@@ -34,10 +34,10 @@
 provides:
   DBD::Pg:
     file              : Pg.pm
-    version           : 2.7.1
+    version           : 2.7.2
   Bundle::DBD::Pg:
     file              : lib/Bundle/DBD/Pg.pm
-    version           : 2.7.1
+    version           : 2.7.2
 
 keywords:
   - Postgres

Modified: trunk/libdbd-pg-perl/Makefile.PL
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/Makefile.PL?rev=19986&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/Makefile.PL (original)
+++ trunk/libdbd-pg-perl/Makefile.PL Thu May 15 20:37:53 2008
@@ -1,4 +1,4 @@
-# $Id: Makefile.PL 11249 2008-05-11 20:53:53Z turnstep $
+# $Id: Makefile.PL 11267 2008-05-14 13:09:18Z turnstep $
 
 use ExtUtils::MakeMaker;
 use Config;
@@ -7,7 +7,7 @@
 use 5.006001;
 
 ## No version.pm for this one, as the prereqs are not loaded yet.
-my $VERSION = '2.7.1';
+my $VERSION = '2.7.2';
 
 my $lib;
 BEGIN {

Modified: trunk/libdbd-pg-perl/Pg.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/Pg.pm?rev=19986&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/Pg.pm (original)
+++ trunk/libdbd-pg-perl/Pg.pm Thu May 15 20:37:53 2008
@@ -1,5 +1,5 @@
 # -*-cperl-*-
-#  $Id: Pg.pm 11249 2008-05-11 20:53:53Z turnstep $
+#  $Id: Pg.pm 11267 2008-05-14 13:09:18Z turnstep $
 #
 #  Copyright (c) 2002-2008 Greg Sabino Mullane and others: see the Changes file
 #  Portions Copyright (c) 2002 Jeffrey W. Baker
@@ -17,7 +17,7 @@
 {
 	package DBD::Pg;
 
-	use version; our $VERSION = qv('2.7.1');
+	use version; our $VERSION = qv('2.7.2');
 
 	use DBI ();
 	use DynaLoader ();
@@ -86,7 +86,7 @@
 		return 0x08000000 if $flag eq 'pgprefix';
 		return 0x10000000 if $flag eq 'pglogin';
 		return 0x20000000 if $flag eq 'pgquote';
-		return DBI::parse_trace_flag($dbh, $flag);
+		return DBI::parse_trace_flag($class, $flag);
 	}
 	sub parse_trace_flags {
 		my ($class, $flags) = @_;
@@ -1679,7 +1679,7 @@
 
 =head1 VERSION
 
-This documents version 2.7.1 of the DBD::Pg module
+This documents version 2.7.2 of the DBD::Pg module
 
 =head1 DESCRIPTION
 
@@ -1898,10 +1898,10 @@
 
 =item B<parse_trace_flag> and B<parse_trace_flags>
 
-  $h->trace($h->parse_trace_flag('SQL|pglibpq'));
-  $h->trace($h->parse_trace_flag('1|pgstart'));
-
-  my $value = DBD::Pg->parse_trace_flags('pglibpq');
+  $h->trace($h->parse_trace_flags('SQL|pglibpq'));
+  $h->trace($h->parse_trace_flags('1|pgstart'));
+
+  my $value = DBD::Pg->parse_trace_flag('pglibpq');
   DBI->trace($value);
 
 The parse_trace_flags method is used to convert one or more named 

Modified: trunk/libdbd-pg-perl/README
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/README?rev=19986&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/README (original)
+++ trunk/libdbd-pg-perl/README Thu May 15 20:37:53 2008
@@ -1,12 +1,12 @@
 
 DBD::Pg  --  the DBI PostgreSQL interface for Perl
 
-# $Id: README 11249 2008-05-11 20:53:53Z turnstep $
+# $Id: README 11267 2008-05-14 13:09:18Z turnstep $
 
 DESCRIPTION:
 ------------
 
-This is version 2.7.1 of DBD-Pg.  The web site for this interface, and 
+This is version 2.7.2 of DBD-Pg.  The web site for this interface, and 
 the latest version, can be found at:
 
 	http://search.cpan.org/dist/DBD-Pg/

Modified: trunk/libdbd-pg-perl/SIGNATURE
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/SIGNATURE?rev=19986&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/SIGNATURE (original)
+++ trunk/libdbd-pg-perl/SIGNATURE Thu May 15 20:37:53 2008
@@ -15,22 +15,22 @@
 Hash: RIPEMD160
 
 SHA1 27aa74b5186533f3b263b2f9136db596ab6fb43c .perlcriticrc
-SHA1 7230ac3981ee93247c479b7675fec0abaedf6e0b Changes
+SHA1 0ee681a2c90be55dcacc521386fa7879898407d9 Changes
 SHA1 4d91c71e5dbb19ece1505ab75c36d00a744bb076 MANIFEST
 SHA1 22055b195f5cf15d7909e8a08468e617f46154e7 MANIFEST.SKIP
-SHA1 76e11bcad3d315a62762f6bea2f6d7972170f1f0 META.yml
-SHA1 29a4d31b65e92bc3c8900d7ccefb3ab6f80ec00d Makefile.PL
+SHA1 262a7b53a5c8b4856cb274d918b7afda96e9cc1c META.yml
+SHA1 9add5bb45dd70c44dd5ca7d41d89818c2b8c3c29 Makefile.PL
 SHA1 c51356c52c139265e20a2ad33bc8d3ee04f6ff48 Pg.h
-SHA1 bdf311f4b4418453b80afe42a0bcf3ffe452d8ea Pg.pm
+SHA1 22611fb28cfb97b89eb0a985e1ce476e4e149fed Pg.pm
 SHA1 9b5ac205a323be2ffdcb7864cbe7ae313a26430e Pg.xs
-SHA1 9e04982547e284bb431f758c3dde6520446f6423 README
+SHA1 c7439aad4be0731a08eb875d4f77b4e1f846947d README
 SHA1 283327a19b823faa386bcc85d5104baca40aaa35 README.dev
 SHA1 968d5fad61bce160b31a9cb1a21dd240b9df930f README.win32
 SHA1 d36ab11031bc39b91f8602c30e508c31cfd5b762 TODO
-SHA1 d643f3c6c2721afc49917aadf0a3b8ebc3e76f79 dbdimp.c
+SHA1 ca3c35730ca91ea8edfc3ba0b12b78f71b0a2309 dbdimp.c
 SHA1 f0d44a5742f8956b4b3dc9fffcf2109fecd0dabb dbdimp.h
 SHA1 6c33bcf138e577722283bef02fceb8cbce4d100d dbivport.h
-SHA1 7d3dc670c2b7656733c7509cea3c9cdfa3ed4d6b lib/Bundle/DBD/Pg.pm
+SHA1 041dfd3cf9d766843ecd6f453363fdf124e3244b lib/Bundle/DBD/Pg.pm
 SHA1 76a2c65c065a93775ceadf933a5d38bb25c8afa4 quote.c
 SHA1 0a1fdd0406c5c367a9aba366d1d35cfa8d5272ae quote.h
 SHA1 4da4f8074e8f46d4e787906fa6de3ebbadef29ed t/00-signature.t
@@ -44,15 +44,15 @@
 SHA1 33876b8ffa5ca7080b7d09cb999aa4705f3b8161 t/06bytea.t
 SHA1 1002b952950258a004a5485e8acd6032d38533b7 t/07copy.t
 SHA1 5ee1eabc257b4ca68dc057b526514def24740383 t/08async.t
-SHA1 5d2c9e298a275163bda994b5fa64cd309a3ed4a1 t/09arrays.t
+SHA1 98bbf45b2e2e5f299b0859fb08623ffa10bfc3d0 t/09arrays.t
 SHA1 e1ee17778109fb43cd60328844b184b2bdcfc263 t/12placeholders.t
 SHA1 6bdf8e55f3ea98f33af91e8f6af628901e66cd34 t/20savepoints.t
 SHA1 addf7fcdcf836fac6b97a9bcadd3daaf2854ae11 t/99_perlcritic.t
 SHA1 74f4e54a0e8e9e8501ef1c13c05efb757d271bd4 t/99_pod.t
-SHA1 f333534e367b6239ea2a64ccc6a4822a15958f08 t/99_spellcheck.t
+SHA1 aab582d5333210dc2a15219759609c429401ca4e t/99_spellcheck.t
 SHA1 e9e984b3c3366d5cee873f1dc59e2b7c26e744ee t/99_yaml.t
 SHA1 3d504299158dadf6a4e187680109a14dbd1bc6ad t/99cleanup.t
-SHA1 d9f444f7778a48bc2443bdc51dd66550b537b670 t/dbdpg_test_setup.pl
+SHA1 e94a6321410bcba894f3eb4886785aa85844061f t/dbdpg_test_setup.pl
 SHA1 bc4a58bdd5e853139f9e1fc6129f83e50a07a2c6 t/lib/App/Info.pm
 SHA1 58befda00c12b1721875262505112203bf230450 t/lib/App/Info/Handler.pm
 SHA1 b5bf85b12a5fc207c44113a9c028fb7fbd68531f t/lib/App/Info/Handler/Prompt.pm
@@ -65,7 +65,7 @@
 SHA1 f07cd5ecaeb854c81ceb9206364979cf607e6546 win32.mak
 -----BEGIN PGP SIGNATURE-----
 
-iEYEAREDAAYFAkgnXUcACgkQvJuQZxSWSsh05QCeMq8muURYliApUZycQ41jtT96
-X78AoM9fatXyITe1NZdNTXU8SzC66HHq
-=ppxQ
+iEYEAREDAAYFAkgq5cMACgkQvJuQZxSWSsi9nACg59L56P18l2BIrtXLxr9u/8ZW
+XmkAn2UKv69OwgHQnIznfmpSy+h94HK2
+=pwsb
 -----END PGP SIGNATURE-----

Modified: trunk/libdbd-pg-perl/dbdimp.c
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/dbdimp.c?rev=19986&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/dbdimp.c (original)
+++ trunk/libdbd-pg-perl/dbdimp.c Thu May 15 20:37:53 2008
@@ -1,6 +1,6 @@
 /*
 
-  $Id: dbdimp.c 11237 2008-05-10 20:21:00Z turnstep $
+  $Id: dbdimp.c 11266 2008-05-14 13:08:45Z turnstep $
 
   Copyright (c) 2002-2008 Greg Sabino Mullane and others: see the Changes file
   Portions Copyright (c) 2002 Jeffrey W. Baker
@@ -604,7 +604,7 @@
 	char * key = SvPV(keysv,kl);
 	SV *   retsv = Nullsv;
 	
-	if (TSTART) TRC(DBILOGFP, "%sBegin dbd_db_FETCH (key: %s dbh: %d)\n", THEADER, key, (int)dbh);
+	if (TSTART) TRC(DBILOGFP, "%sBegin dbd_db_FETCH (key: %s)\n", THEADER, dbh ? key : key);
 	
 	switch (kl) {
 
@@ -851,7 +851,7 @@
 	SV *              retsv = Nullsv;
 	int               fields, x;
 
-	if (TSTART) TRC(DBILOGFP, "%sBegin dbd_st_FETCH (key: %s sth: %d)\n", THEADER, key, (int)sth);
+	if (TSTART) TRC(DBILOGFP, "%sBegin dbd_st_FETCH (key: %s)\n", THEADER, key);
 	
 	/* Some can be done before we have a result: */
 	switch (kl) {
@@ -1186,8 +1186,8 @@
 	char * value = SvPV(valuesv,vl);
 	int    retval = 0;
 
-	if (TSTART) TRC(DBILOGFP, "%sBegin dbd_st_STORE (key: %s value: %s sth: %d)\n",
-					THEADER, key, value, (int)sth);
+	if (TSTART) TRC(DBILOGFP, "%sBegin dbd_st_STORE (key: %s value: %s)\n",
+					THEADER, key, value);
 	
 	switch (kl) {
 
@@ -1246,7 +1246,7 @@
 {
 	dTHX;
 
-	if (TSTART) TRC(DBILOGFP, "%sBegin dbd_discon_all (drh: %d)\n", THEADER, (int)drh);
+	if (TSTART) TRC(DBILOGFP, "%sBegin dbd_discon_all\n", THEADER);
 
 	/* The disconnect_all concept is flawed and needs more work */
 	if (!PL_dirty && !SvTRUE(perl_get_sv("DBI::PERL_ENDING",0))) {
@@ -1266,7 +1266,7 @@
 {
 	dTHX;
 
-	if (TSTART) TRC(DBILOGFP, "%sBegin pg_db_getfd (dbh: %d)\n", THEADER, (int)dbh);
+	if (TSTART) TRC(DBILOGFP, "%sBegin pg_db_getfd\n", THEADER);
 
 	TRACE_PQSOCKET;
 	return PQsocket(imp_dbh->conn);
@@ -2474,7 +2474,8 @@
 			if ('\\' == *input) { /* Eat backslashes */
 				input++;
 			}
-			string[section_size++] = *input;
+			string[section_size++] = *input++;
+			continue;
 		}
 		else if ('{' == *input) {
 			AV * const newav = newAV();
@@ -3336,7 +3337,7 @@
 {
 	dTHX;
 
-	if (TSTART) TRC(DBILOGFP, "%sBegin dbd_st_rows (sth: %d)\n", THEADER, (int)sth);
+	if (TSTART) TRC(DBILOGFP, "%sBegin dbd_st_rows\n", THEADER);
 
 	return imp_sth->rows;
 

Modified: trunk/libdbd-pg-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/debian/changelog?rev=19986&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/debian/changelog (original)
+++ trunk/libdbd-pg-perl/debian/changelog Thu May 15 20:37:53 2008
@@ -1,8 +1,5 @@
-libdbd-pg-perl (2.7.1-1) UNRELEASED; urgency=low
-
-  NOTE: no need to torture buildds, this release only fixes minor issues in
-  test that are not used
-  
+libdbd-pg-perl (2.7.2-1) UNRELEASED; urgency=low
+
   * New upstream release.
 
  -- gregor herrmann <gregoa at debian.org>  Mon, 12 May 2008 16:03:47 +0200

Modified: trunk/libdbd-pg-perl/lib/Bundle/DBD/Pg.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/lib/Bundle/DBD/Pg.pm?rev=19986&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/lib/Bundle/DBD/Pg.pm (original)
+++ trunk/libdbd-pg-perl/lib/Bundle/DBD/Pg.pm Thu May 15 20:37:53 2008
@@ -4,7 +4,7 @@
 use strict;
 use warnings;
 
-$VERSION = '2.7.1';
+$VERSION = '2.7.2';
 
 1;
 

Modified: trunk/libdbd-pg-perl/t/09arrays.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/09arrays.t?rev=19986&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/09arrays.t (original)
+++ trunk/libdbd-pg-perl/t/09arrays.t Thu May 15 20:37:53 2008
@@ -17,7 +17,7 @@
 if (! defined $dbh) {
 	plan skip_all => 'Connection to database failed, cannot continue testing';
 }
-plan tests => 227;
+plan tests => 245;
 
 isnt( $dbh, undef, 'Connect to database for array testing');
 
@@ -104,6 +104,18 @@
 ['abc']
 {abc} quote: {"abc"}
 Simple 1-D text array
+
+['a','b,c']
+{a,"b,c"} quote: {"a","b,c"}
+Text array with commas and quotes
+
+['a','b,}']
+{a,"b,}"} quote: {"a","b,}"}
+Text array with commas, escaped closing brace
+
+['a','b,]']
+{a,"b,]"} quote: {"a","b,]"}
+Text array with commas, escaped closing bracket
 
 [1,2]
 {1,2} quote: {"1","2"}
@@ -256,8 +268,19 @@
 		$qexpected =~ s/\\\\n/\\n/g;
 		$qexpected =~ s/\\\\"/\\"/g;
 		$qexpected =~ s/\\\\i/\\i/g;
+		if ($msg =~ /closing brace/) {
+			$qexpected =~ s/]"/}"/;
+		}
 		$expected = eval $qexpected;
 		is_deeply( $result, $expected, "Correct array inserted: $msg : $input");
+	}
+
+	if ($msg =~ /STOP/) {
+		warn "Exiting for DEBUGGING. Result is:\n";
+		warn Dumper $result;
+		cleanup_database($dbh,'test');
+		$dbh->disconnect;
+		exit;
 	}
 
 }

Modified: trunk/libdbd-pg-perl/t/99_spellcheck.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/99_spellcheck.t?rev=19986&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/99_spellcheck.t (original)
+++ trunk/libdbd-pg-perl/t/99_spellcheck.t Thu May 15 20:37:53 2008
@@ -586,6 +586,7 @@
 turnstep
 
 ## Changes:
+destringifying
 spellcheck
 gborg
 n's

Modified: trunk/libdbd-pg-perl/t/dbdpg_test_setup.pl
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libdbd-pg-perl/t/dbdpg_test_setup.pl?rev=19986&op=diff
==============================================================================
--- trunk/libdbd-pg-perl/t/dbdpg_test_setup.pl (original)
+++ trunk/libdbd-pg-perl/t/dbdpg_test_setup.pl Thu May 15 20:37:53 2008
@@ -199,7 +199,7 @@
 		};
 		last GETHANDLE if $@;
 		if (!defined $info or $info !~ /\@postgresql\.org/) {
-			$@ = defined $initdb ? "Bad initdb output: $info" : 'Bad initdb output';
+			$@ = defined $info ? "Bad initdb output: $info" : 'Bad initdb output';
 			last GETHANDLE;
 		}
 
@@ -323,7 +323,9 @@
 			$@ = qq{Could not open "$conf": $!};
 			last GETHANDLE;
 		}
-		print $cfh "\n\n## DBD::Pg testing parameters\nport=$testport\nmax_connections=3\n\n";
+		print $cfh "\n\n## DBD::Pg testing parameters\nport=$testport\nmax_connections=3\n";
+		print $cfh "listen_addresses='localhost'\n" if $^O =~ /Win32/;
+		print $cfh "\n";
 		close $cfh or die qq{Could not close "$conf": $!\n};
 
 		## Attempt to start up the test server




More information about the Pkg-perl-cvs-commits mailing list