r26179 - in /trunk/libflickr-upload-perl/debian: changelog patches/failupload.patch patches/series

[alexm-guest at users.alioth.debian.org]

Author: alexm-guest
Date: Sun Oct 19 14:38:08 2008
New Revision: 26179

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=26179
Log:
Patched dubious error on failupload.t when network is unavailable.

Added:
    trunk/libflickr-upload-perl/debian/patches/failupload.patch
Modified:
    trunk/libflickr-upload-perl/debian/changelog
    trunk/libflickr-upload-perl/debian/patches/series

Modified: trunk/libflickr-upload-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libflickr-upload-perl/debian/changelog?rev=26179&op=diff
==============================================================================
--- trunk/libflickr-upload-perl/debian/changelog (original)
+++ trunk/libflickr-upload-perl/debian/changelog Sun Oct 19 14:38:08 2008
@@ -1,16 +1,5 @@
 libflickr-upload-perl (1.32-1) UNRELEASED; urgency=low
 
-  PROBLEM:
-  one test fails without internet connection:
-  
-  t/failupload..........junk '500 Can't connect to api.flickr.com:80 (Bad hostname 'api.flickr.com')
-  ' before XML element
-  # Looks like your test died just after 2.
-  dubious
-          Test returned status 255 (wstat 65280, 0xff00)
-          after all the subtests completed successfully
-  
-  
   * Initial Release. Closes: #500622 -- ITP
 
  -- Alex Muntada <alexm at alexm.org>  Sun, 19 Oct 2008 02:59:35 +0200

Added: trunk/libflickr-upload-perl/debian/patches/failupload.patch
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libflickr-upload-perl/debian/patches/failupload.patch?rev=26179&op=file
==============================================================================
--- trunk/libflickr-upload-perl/debian/patches/failupload.patch (added)
+++ trunk/libflickr-upload-perl/debian/patches/failupload.patch Sun Oct 19 14:38:08 2008
@@ -1,0 +1,14 @@
+Author: Alex Muntada <alexm at alexm.org>
+Description: Fixes dubious test when network is unavailable
+
+--- a/Upload.pm
++++ b/Upload.pm
+@@ -270,6 +270,8 @@
+ 
+ 	my $res = $self->request( $req );
+ 
++    return () unless defined $res && $res->is_success;
++
+ 	my $tree = XML::Parser::Lite::Tree::instance()->parse($res->decoded_content());
+ 	return () unless defined $tree;
+ 

Modified: trunk/libflickr-upload-perl/debian/patches/series
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libflickr-upload-perl/debian/patches/series?rev=26179&op=diff
==============================================================================
--- trunk/libflickr-upload-perl/debian/patches/series (original)
+++ trunk/libflickr-upload-perl/debian/patches/series Sun Oct 19 14:38:08 2008
@@ -1,1 +1,2 @@
+failupload.patch
 manpage-has-errors-from-pod2man.patch