r24946 - in /trunk/libspreadsheet-writeexcel-perl: Changes META.yml debian/changelog doc/WriteExcel.html lib/Spreadsheet/WriteExcel.pm lib/Spreadsheet/WriteExcel/Properties.pm t/40_property_types.t t/41_properties.t t/42_set_properties.t

gregoa at users.alioth.debian.org gregoa at users.alioth.debian.org
Tue Sep 9 15:41:43 UTC 2008


Author: gregoa
Date: Tue Sep  9 15:41:40 2008
New Revision: 24946

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=24946
Log:
New upstream release.

Modified:
    trunk/libspreadsheet-writeexcel-perl/Changes
    trunk/libspreadsheet-writeexcel-perl/META.yml
    trunk/libspreadsheet-writeexcel-perl/debian/changelog
    trunk/libspreadsheet-writeexcel-perl/doc/WriteExcel.html
    trunk/libspreadsheet-writeexcel-perl/lib/Spreadsheet/WriteExcel.pm
    trunk/libspreadsheet-writeexcel-perl/lib/Spreadsheet/WriteExcel/Properties.pm
    trunk/libspreadsheet-writeexcel-perl/t/40_property_types.t
    trunk/libspreadsheet-writeexcel-perl/t/41_properties.t
    trunk/libspreadsheet-writeexcel-perl/t/42_set_properties.t

Modified: trunk/libspreadsheet-writeexcel-perl/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libspreadsheet-writeexcel-perl/Changes?rev=24946&op=diff
==============================================================================
--- trunk/libspreadsheet-writeexcel-perl/Changes (original)
+++ trunk/libspreadsheet-writeexcel-perl/Changes Tue Sep  9 15:41:40 2008
@@ -1,4 +1,10 @@
 Revision history for Perl module Spreadsheet::WriteExcel.
+
+2.25 September 9 - Minor
+
+    + Fix for set_properties() bug due to 5.10/5.8 UTF-8 differences.
+    + Fix for failing tests due to localtime() issues.
+
 
 2.24 September 6 - Minor
 

Modified: trunk/libspreadsheet-writeexcel-perl/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libspreadsheet-writeexcel-perl/META.yml?rev=24946&op=diff
==============================================================================
--- trunk/libspreadsheet-writeexcel-perl/META.yml (original)
+++ trunk/libspreadsheet-writeexcel-perl/META.yml Tue Sep  9 15:41:40 2008
@@ -1,16 +1,13 @@
-name:               Spreadsheet-WriteExcel
-abstract:           Write to a cross platform Excel binary file
-version:            2.24
-version_from:       lib/Spreadsheet/WriteExcel.pm
-installdirs:        site
+# http://module-build.sourceforge.net/META-spec.html
+#XXXXXXX This is a prototype!!!  It will change in the future!!! XXXXX#
+name:         Spreadsheet-WriteExcel
+version:      2.25
+version_from: lib/Spreadsheet/WriteExcel.pm
+installdirs:  site
 requires:
     File::Temp:                    0
     OLE::Storage_Lite:             0.14
     Parse::RecDescent:             0
 
-distribution_type:  module
-license:            perl
-generated_by:       hand
-resources:
-    CPANForum: http://groups.google.com/group/spreadsheet-writeexcel
-    GoogleGroup: http://groups.google.com/group/spreadsheet-writeexcel
+distribution_type: module
+generated_by: ExtUtils::MakeMaker version 6.30

Modified: trunk/libspreadsheet-writeexcel-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libspreadsheet-writeexcel-perl/debian/changelog?rev=24946&op=diff
==============================================================================
--- trunk/libspreadsheet-writeexcel-perl/debian/changelog (original)
+++ trunk/libspreadsheet-writeexcel-perl/debian/changelog Tue Sep  9 15:41:40 2008
@@ -1,4 +1,4 @@
-libspreadsheet-writeexcel-perl (2.24-1) UNRELEASED; urgency=low
+libspreadsheet-writeexcel-perl (2.25-1) UNRELEASED; urgency=low
 
   PROBLEM: test with new 'properties' fails
   

Modified: trunk/libspreadsheet-writeexcel-perl/doc/WriteExcel.html
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libspreadsheet-writeexcel-perl/doc/WriteExcel.html?rev=24946&op=diff
==============================================================================
--- trunk/libspreadsheet-writeexcel-perl/doc/WriteExcel.html (original)
+++ trunk/libspreadsheet-writeexcel-perl/doc/WriteExcel.html Tue Sep  9 15:41:40 2008
@@ -7,7 +7,7 @@
 <!--
   generated by Pod::Simple::HTML v3.01,
   using Pod::Simple::PullParser v2.02,
-  under Perl v5.00503 at Sat Sep  6 00:30:18 2008 GMT.
+  under Perl v5.00503 at Tue Sep  9 00:24:13 2008 GMT.
 
  If you want to change this HTML document, you probably shouldn't do that
    by changing it directly.  Instead, see about changing the calling options
@@ -223,8 +223,8 @@
 name="VERSION"
 >VERSION</a></h1>
 
-<p>This document refers to version 2.24 of Spreadsheet::WriteExcel,
-released September 4,
+<p>This document refers to version 2.25 of Spreadsheet::WriteExcel,
+released September 9,
 2008.</p>
 
 <h1><a class='u' href='#___top' title='click to go to top of document'
@@ -5311,7 +5311,7 @@
     If I wanted to
     But I don&#39;t want to get over you
 
-        -- The Magnetic Fields</pre>
+        -- Stephin Merritt</pre>
 
 <h1><a class='u' href='#___top' title='click to go to top of document'
 name="COPYRIGHT"

Modified: trunk/libspreadsheet-writeexcel-perl/lib/Spreadsheet/WriteExcel.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libspreadsheet-writeexcel-perl/lib/Spreadsheet/WriteExcel.pm?rev=24946&op=diff
==============================================================================
--- trunk/libspreadsheet-writeexcel-perl/lib/Spreadsheet/WriteExcel.pm (original)
+++ trunk/libspreadsheet-writeexcel-perl/lib/Spreadsheet/WriteExcel.pm Tue Sep  9 15:41:40 2008
@@ -21,7 +21,7 @@
 use vars qw($VERSION @ISA);
 @ISA = qw(Spreadsheet::WriteExcel::Workbook Exporter);
 
-$VERSION = '2.24'; # La piccola alla scuola.
+$VERSION = '2.25'; # La piccola alla scuola un'altra settimana.
 
 
 
@@ -64,7 +64,7 @@
 
 =head1 VERSION
 
-This document refers to version 2.24 of Spreadsheet::WriteExcel, released September 4, 2008.
+This document refers to version 2.25 of Spreadsheet::WriteExcel, released September 9, 2008.
 
 
 

Modified: trunk/libspreadsheet-writeexcel-perl/lib/Spreadsheet/WriteExcel/Properties.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libspreadsheet-writeexcel-perl/lib/Spreadsheet/WriteExcel/Properties.pm?rev=24946&op=diff
==============================================================================
--- trunk/libspreadsheet-writeexcel-perl/lib/Spreadsheet/WriteExcel/Properties.pm (original)
+++ trunk/libspreadsheet-writeexcel-perl/lib/Spreadsheet/WriteExcel/Properties.pm Tue Sep  9 15:41:40 2008
@@ -24,7 +24,7 @@
 
 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
 @ISA        = qw(Exporter);
-$VERSION    = '0.01';
+$VERSION    = '0.02';
 
 # Set up the exports.
 my @all_functions = qw(
@@ -261,8 +261,20 @@
     }
     elsif ($codepage == 0xFDE9) {
         # UTF-8
-        $byte_string = pack 'C*', unpack 'C*', $string;
-        $length      = length $byte_string;
+        if ( $] > 5.008 ) {
+            require Encode;
+            if (Encode::is_utf8($string)) {
+                $byte_string = Encode::encode_utf8($string);
+            }
+            else {
+                $byte_string = $string;
+            }
+        }
+        else {
+            $byte_string = $string;
+        }
+
+        $length = length $byte_string;
     }
     else {
         croak "Unknown codepage: $codepage\n";

Modified: trunk/libspreadsheet-writeexcel-perl/t/40_property_types.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libspreadsheet-writeexcel-perl/t/40_property_types.t?rev=24946&op=diff
==============================================================================
--- trunk/libspreadsheet-writeexcel-perl/t/40_property_types.t (original)
+++ trunk/libspreadsheet-writeexcel-perl/t/40_property_types.t Tue Sep  9 15:41:40 2008
@@ -14,6 +14,7 @@
 use Carp;
 
 use Spreadsheet::WriteExcel::Properties ':testing';
+use Time::Local 'timegm';
 use Test::More tests => 13;
 
 
@@ -251,7 +252,9 @@
 
 # Wed Aug 13 01:40:00 2008
 # $sec,$min,$hour,$mday,$mon,$year
-$filetime   = [0, 40, 1, 13, 7, 108];
+# We normalise the time using timegm() so that the tests don't fail due to
+# different timezones.
+$filetime   = [localtime(timegm(0, 40, 0, 13, 7, 108))];
 
 $caption    = " \tDoc properties: _pack_VT_FILETIME()";
 $target     = join " ",  qw(

Modified: trunk/libspreadsheet-writeexcel-perl/t/41_properties.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libspreadsheet-writeexcel-perl/t/41_properties.t?rev=24946&op=diff
==============================================================================
--- trunk/libspreadsheet-writeexcel-perl/t/41_properties.t (original)
+++ trunk/libspreadsheet-writeexcel-perl/t/41_properties.t Tue Sep  9 15:41:40 2008
@@ -14,6 +14,7 @@
 use Carp;
 
 use Spreadsheet::WriteExcel::Properties ':testing';
+use Time::Local 'timegm';
 use Test::More tests => 8;
 
 
@@ -236,7 +237,9 @@
 
 # Wed Aug 20 00:20:13 2008
 # $sec,$min,$hour,$mday,$mon,$year
-$filetime   = [13, 20, 0, 20, 7, 108];
+# We normalise the time using timegm() so that the tests don't fail due to
+# different timezones.
+$filetime   = [localtime(timegm(13, 20, 23, 19, 7, 108))];
 
 @properties =  (
                 [0x0001, 'VT_I2',       0x04E4    ],

Modified: trunk/libspreadsheet-writeexcel-perl/t/42_set_properties.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libspreadsheet-writeexcel-perl/t/42_set_properties.t?rev=24946&op=diff
==============================================================================
--- trunk/libspreadsheet-writeexcel-perl/t/42_set_properties.t (original)
+++ trunk/libspreadsheet-writeexcel-perl/t/42_set_properties.t Tue Sep  9 15:41:40 2008
@@ -15,6 +15,7 @@
 
 use Spreadsheet::WriteExcel;
 use Spreadsheet::WriteExcel::Properties ':testing';
+use Time::Local 'timegm';
 use Test::More tests => 17;
 
 
@@ -335,7 +336,9 @@
 
 # Wed Aug 20 00:20:13 2008
 # $sec,$min,$hour,$mday,$mon,$year
-$filetime   = [13, 20, 0, 20, 7, 108];
+# We normalise the time using timegm() so that the tests don't fail due to
+# different timezones.
+$filetime   = [localtime(timegm(13, 20, 23, 19, 7, 108))];
 
 $workbook->set_properties(
                             title       => 'Title',
@@ -378,7 +381,9 @@
 
 # Wed Aug 20 00:20:13 2008
 # $sec,$min,$hour,$mday,$mon,$year
-$workbook->{_localtime}  = [13, 20, 0, 20, 7, 108];
+# We normalise the time using timegm() so that the tests don't fail due to
+# different timezones.
+$workbook->{_localtime}  = [localtime(timegm(13, 20, 23, 19, 7, 108))];
 
 $workbook->set_properties(
                             title       => 'Title',
@@ -420,7 +425,9 @@
 
 # Wed Aug 20 00:20:13 2008
 # $sec,$min,$hour,$mday,$mon,$year
-$filetime   = [13, 20, 0, 20, 7, 108];
+# We normalise the time using timegm() so that the tests don't fail due to
+# different timezones.
+$filetime   = [localtime(timegm(13, 20, 23, 19, 7, 108))];
 
 $workbook->set_properties({
                             title       => 'Title',
@@ -485,13 +492,11 @@
 is($result, $target, $caption);
 }
 
+
 ###############################################################################
 #
 # Test 15. Manual UTF-8 string used..
 #
-TODO: {
-
-local $TODO = 'Fails on 5.8.0 but not 5.8.8. Need to investigate.';
 
 my $smiley_manual = pack 'H*', 'E298BA';
 
@@ -516,7 +521,6 @@
 
 $result     = unpack_record( $workbook->{summary} );
 is($result, $target, $caption);
-}
 
 
 ###############################################################################




More information about the Pkg-perl-cvs-commits mailing list