r32927 - in /branches/upstream/libdbd-sqlite3-perl/current: Changes MANIFEST META.yml dbdimp.c lib/DBD/SQLite.pm t/32_inactive_error.t t/lib/Test.pm t/rt_25371_asymmetric_unicode.t

gregoa at users.alioth.debian.org gregoa at users.alioth.debian.org
Thu Apr 9 18:39:01 UTC 2009 

Author: gregoa
Date: Thu Apr  9 18:38:55 2009
New Revision: 32927

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=32927
Log:
[svn-upgrade] Integrating new upstream version, libdbd-sqlite3-perl (1.21)

Added:
    branches/upstream/libdbd-sqlite3-perl/current/t/32_inactive_error.t
Modified:
    branches/upstream/libdbd-sqlite3-perl/current/Changes
    branches/upstream/libdbd-sqlite3-perl/current/MANIFEST
    branches/upstream/libdbd-sqlite3-perl/current/META.yml
    branches/upstream/libdbd-sqlite3-perl/current/dbdimp.c
    branches/upstream/libdbd-sqlite3-perl/current/lib/DBD/SQLite.pm
    branches/upstream/libdbd-sqlite3-perl/current/t/lib/Test.pm
    branches/upstream/libdbd-sqlite3-perl/current/t/rt_25371_asymmetric_unicode.t

Modified: branches/upstream/libdbd-sqlite3-perl/current/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/Changes?rev=32927&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/Changes (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/Changes Thu Apr  9 18:38:55 2009
@@ -1,6 +1,10 @@
 Changes for Perl extension DBD-SQLite.
 
-1.20 to be released
+1.21 Wed  9 Apr 2009
+    - Fixed the issue that execute on inactive handles returned
+      0 instead of undef, which made a DBIC test broken (ISHIGAKI)
+
+1.20 Mon  7 Apr 2009
     - Moving to the first production release of the new era.
     - Check DBI version in Makefile.PL (CHORNY)
     - Bundling Test::NoWarings into /inc to remove a dependency (ADAMK)

Modified: branches/upstream/libdbd-sqlite3-perl/current/MANIFEST
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/MANIFEST?rev=32927&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/MANIFEST (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/MANIFEST Thu Apr  9 18:38:55 2009
@@ -123,6 +123,7 @@
 t/29_cppcomments.t
 t/30_auto_rollback.t
 t/31_bind_weird_number_param.t
+t/32_inactive_error.t
 t/97_meta.t
 t/98_pod.t
 t/99_pmv.t

Modified: branches/upstream/libdbd-sqlite3-perl/current/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/META.yml?rev=32927&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/META.yml (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/META.yml Thu Apr  9 18:38:55 2009
@@ -1,6 +1,6 @@
 --- #YAML:1.0
 name:               DBD-SQLite
-version:            1.20
+version:            1.21
 abstract:           Self Contained SQLite RDBMS in a DBI Driver
 author:
     - Adam Kennedy <adamk at cpan.org>

Modified: branches/upstream/libdbd-sqlite3-perl/current/dbdimp.c
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/dbdimp.c?rev=32927&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/dbdimp.c (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/dbdimp.c Thu Apr  9 18:38:55 2009
@@ -351,7 +351,7 @@
 
     if (!DBIc_ACTIVE(imp_dbh)) {
         sqlite_error(sth, (imp_xxh_t*)imp_sth, retval, "attempt to execute on inactive database handle");
-        return FALSE;
+        return -2;
     }
 
     if (DBIc_ACTIVE(imp_sth)) {

Modified: branches/upstream/libdbd-sqlite3-perl/current/lib/DBD/SQLite.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/lib/DBD/SQLite.pm?rev=32927&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/lib/DBD/SQLite.pm (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/lib/DBD/SQLite.pm Thu Apr  9 18:38:55 2009
@@ -8,7 +8,7 @@
 use vars qw($VERSION @ISA);
 use vars qw{$err $errstr $drh $sqlite_version};
 BEGIN {
-    $VERSION = '1.20';
+    $VERSION = '1.21';
     @ISA     = ('DynaLoader');
 
     # Driver singleton

Added: branches/upstream/libdbd-sqlite3-perl/current/t/32_inactive_error.t
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/t/32_inactive_error.t?rev=32927&op=file
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/t/32_inactive_error.t (added)
+++ branches/upstream/libdbd-sqlite3-perl/current/t/32_inactive_error.t Thu Apr  9 18:38:55 2009
@@ -1,0 +1,31 @@
+#!/usr/bin/perl
+
+use strict;
+BEGIN {
+	$|  = 1;
+	$^W = 1;
+}
+
+use Test::More tests => 4;
+use t::lib::Test;
+
+my $dbh = connect_ok( PrintError => 0, RaiseError => 1 );
+
+my $sth = $dbh->prepare('CREATE TABLE foo (f)');
+
+$dbh->disconnect;
+
+# attempt to execute on inactive database handle
+my @warning = ();
+SCOPE: {
+	local $SIG{__WARN__} = sub { push @warning, @_; return };
+	my $ret = eval { $sth->execute; };
+	ok ! defined $ret;
+}
+
+is( scalar(@warning), 1, 'Got 1 warning' );
+like(
+	$warning[0],
+	qr/attempt to execute on inactive database handle/,
+	'Got the expected warning',
+);

Modified: branches/upstream/libdbd-sqlite3-perl/current/t/lib/Test.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/t/lib/Test.pm?rev=32927&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/t/lib/Test.pm (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/t/lib/Test.pm Thu Apr  9 18:38:55 2009
@@ -9,7 +9,7 @@
 
 use vars qw{$VERSION @ISA @EXPORT};
 BEGIN {
-	$VERSION = '1.20';
+	$VERSION = '1.21';
 	@ISA     = qw{ Exporter };
 	@EXPORT  = qw{ connect_ok };
 

Modified: branches/upstream/libdbd-sqlite3-perl/current/t/rt_25371_asymmetric_unicode.t
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/t/rt_25371_asymmetric_unicode.t?rev=32927&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/t/rt_25371_asymmetric_unicode.t (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/t/rt_25371_asymmetric_unicode.t Thu Apr  9 18:38:55 2009
@@ -7,7 +7,7 @@
 }
 
 use t::lib::Test;
-# use Test::More tests => 15;
+# use Test::More tests => 22;
 use Test::More skip_all => 'Temporarily disabling known-bad test';
 use Test::NoWarnings;
 
@@ -24,5 +24,9 @@
     ok( $dbh->do("INSERT INTO foo VALUES ( ? )", {}, $_), 'INSERT' );
     my $foo = $dbh->selectall_arrayref("SELECT bar FROM foo");
     is_deeply( $foo, [ [ $_ ] ], 'Value round-tripped ok' );
+    my $len = $dbh->selectall_arrayref("SELECT length(bar) FROM foo");
+    is $len->[0][0], 1 unless $_ eq "\0";
+    my $match = $dbh->selectall_arrayref("SELECT bar FROM foo WHERE bar = ?", {}, $_);
+    is $match->[0][0], $_;
     ok( $dbh->do("DELETE FROM foo"), 'DELETE ok' );
 }

More information about the Pkg-perl-cvs-commits mailing list