r34179 - in /trunk/libcgi-uploader-perl: Changes Makefile.PL debian/changelog lib/CGI/Uploader.pm lib/CGI/Uploader/Cookbook.pod lib/CGI/Uploader/Transform/ImageMagick.pm
jeremiah-guest at users.alioth.debian.org
jeremiah-guest at users.alioth.debian.org
Sun Apr 26 19:33:16 UTC 2009
Author: jeremiah-guest
Date: Sun Apr 26 19:33:04 2009
New Revision: 34179
URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=34179
Log:
Updating to a new upstream release
Modified:
trunk/libcgi-uploader-perl/Changes
trunk/libcgi-uploader-perl/Makefile.PL
trunk/libcgi-uploader-perl/debian/changelog
trunk/libcgi-uploader-perl/lib/CGI/Uploader.pm
trunk/libcgi-uploader-perl/lib/CGI/Uploader/Cookbook.pod
trunk/libcgi-uploader-perl/lib/CGI/Uploader/Transform/ImageMagick.pm
Modified: trunk/libcgi-uploader-perl/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-uploader-perl/Changes?rev=34179&op=diff
==============================================================================
--- trunk/libcgi-uploader-perl/Changes (original)
+++ trunk/libcgi-uploader-perl/Changes Sun Apr 26 19:33:04 2009
@@ -1,4 +1,24 @@
Revision history for Perl extension CGI::Uploader.
+
+2.17 Thu Apr 2 11:43:50 EDT 2009
+ [BUG FIXES]
+ - Small but fatal typo fix from 2.16 release cycle.
+
+2.16 Thu Apr 2 11:36:40 EDT 2009
+
+ [BUG FIXES]
+ - Using 'transform_method' to tranform an upload in place was broken.
+ - Now use File::Spec instead of hardcoding "/" as a path separator. (Ron Savage)
+ - Use binmode() on the right file handle (Ron Savage)
+ - upload_id was hardcoded in one place instead of using up_table_map (Ron Savage)
+
+ [DOCUMENTATION]
+ - Quit recommending SQL::Abstract in the Cookbook (but we use it internally)
+
+ [INTERNAL]
+ - Mark "Image::Size" as a requirement, if only to get tests to stop failing.
+ It's only really required if you use the Image::Magick transformations.
+
2.15 Sun Jul 15 07:21:24 EDT 2007
- no functionality changes
Modified: trunk/libcgi-uploader-perl/Makefile.PL
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-uploader-perl/Makefile.PL?rev=34179&op=diff
==============================================================================
--- trunk/libcgi-uploader-perl/Makefile.PL (original)
+++ trunk/libcgi-uploader-perl/Makefile.PL Sun Apr 26 19:33:04 2009
@@ -12,6 +12,10 @@
# Graphics::Magick is recommended over Image::Magick, but isn't on CPAN
recommends
'Image::Magick' => 0;
+
+ # This could probably become a "test_requires"
+ requires 'Image::Size' => 0;
+
}
Modified: trunk/libcgi-uploader-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-uploader-perl/debian/changelog?rev=34179&op=diff
==============================================================================
--- trunk/libcgi-uploader-perl/debian/changelog (original)
+++ trunk/libcgi-uploader-perl/debian/changelog Sun Apr 26 19:33:04 2009
@@ -1,9 +1,16 @@
-libcgi-uploader-perl (2.15-3) UNRELEASED; urgency=low
+libcgi-uploader-perl (2.17-1) unstable; urgency=low
+ * New upstream release
+
+ -- Jeremiah C. Foster <jeremiah at jeremiahfoster.com> Sun, 26 Apr 2009 21:30:23 +0200
+
+libcgi-uploader-perl (2.15-3) unstable; urgency=low
+
+ [ gregor herrmann ]
* debian/control: Changed: Switched Vcs-Browser field to ViewSVN
(source stanza).
- -- gregor herrmann <gregoa at debian.org> Sun, 16 Nov 2008 20:40:23 +0100
+ -- Jeremiah C. Foster <jeremiah at jeremiahfoster.com> Sun, 26 Apr 2009 21:26:46 +0200
libcgi-uploader-perl (2.15-2) unstable; urgency=low
Modified: trunk/libcgi-uploader-perl/lib/CGI/Uploader.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-uploader-perl/lib/CGI/Uploader.pm?rev=34179&op=diff
==============================================================================
--- trunk/libcgi-uploader-perl/lib/CGI/Uploader.pm (original)
+++ trunk/libcgi-uploader-perl/lib/CGI/Uploader.pm Sun Apr 26 19:33:04 2009
@@ -12,7 +12,7 @@
require Exporter;
use vars '$VERSION';
-$VERSION = '2.15';
+$VERSION = '2.17';
=head1 NAME
@@ -20,7 +20,7 @@
=head1 Synopsis
- use CGI::Uploader::Transform::ImageMagick (qw/gen_thumb/);
+ use CGI::Uploader::Transform::ImageMagick 'gen_thumb';
my $u = CGI::Uploader->new(
spec => {
@@ -647,11 +647,7 @@
my ($tmp_fh, $tmp_filename) = tempfile('CGIuploaderXXXXX', UNLINK => 1, DIR => $self->{'temp_dir'} );
- # Determine whether binary mode is required in the handling of uploaded
- # files -
- # Binary mode is deemed to be required when we (the server) are running one one
- # of these platforms: for Windows, OS/2 and VMS
- binmode($tmp_fh) if ($^O =~ /OS2|VMS|Win|DOS|Cygwin/i);
+ binmode($fh);
require File::Copy;
import File::Copy;
@@ -707,7 +703,7 @@
# Transform file if needed
if (my $meth = $self->{spec}{$file_field}{transform_method}) {
$tmp_filename = $meth->( $self,
- $file_name,
+ $tmp_filename,
$self->{spec}{$file_field}{params},
);
}
@@ -1040,7 +1036,7 @@
if (!$is_update && $self->{db_driver} eq 'Pg') {
$id = $DBH->selectrow_array("SELECT NEXTVAL('".$self->{up_seq}."')");
- $copy{upload_id} = $id;
+ $copy{$map->{upload_id} } = $id;
}
my @orig_keys = keys %copy;
@@ -1304,7 +1300,8 @@
mkpath($full_path);
}
- $loc = "$md5_path/$id$ext";
+
+ $loc = File::Spec->catdir($md5_path,"$id$ext");
}
}
Modified: trunk/libcgi-uploader-perl/lib/CGI/Uploader/Cookbook.pod
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-uploader-perl/lib/CGI/Uploader/Cookbook.pod?rev=34179&op=diff
==============================================================================
--- trunk/libcgi-uploader-perl/lib/CGI/Uploader/Cookbook.pod (original)
+++ trunk/libcgi-uploader-perl/lib/CGI/Uploader/Cookbook.pod Sun Apr 26 19:33:04 2009
@@ -1,5 +1,3 @@
-#arch-tag: Mark_Stosberg_<mark at summersault.com>--2004-04-02_19:00:27
-# Don't edit the above line. Thanks.
=head1 NAME
@@ -210,11 +208,10 @@
# photo_thumbnail_id => 4,
# }
- # I like to use SQL::Abstract for easy inserts.
- use SQL::Abstract;
- my $sql = SQL::Abstract->new;
- my($stmt, @bind) = $sql->insert('address_book',$friend);
- $dbh->do($stmt,{}, at bind);
+ # I like to use SQL::Interp for easy inserts.
+ # See DBIx::Simple for an even more friendly wrapper.
+ use SQL::Interp 'sql_interp';
+ $dbh->do(sql_interp "INSERT INTO address_book",$friend);
=head2 Database Result of Adding
Modified: trunk/libcgi-uploader-perl/lib/CGI/Uploader/Transform/ImageMagick.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-uploader-perl/lib/CGI/Uploader/Transform/ImageMagick.pm?rev=34179&op=diff
==============================================================================
--- trunk/libcgi-uploader-perl/lib/CGI/Uploader/Transform/ImageMagick.pm (original)
+++ trunk/libcgi-uploader-perl/lib/CGI/Uploader/Transform/ImageMagick.pm Sun Apr 26 19:33:04 2009
@@ -1,14 +1,14 @@
package CGI::Uploader::Transform::ImageMagick;
use base 'Exporter';
-use File::Temp qw/tempfile/;
-use Params::Validate (qw/:all/);
+use File::Temp 'tempfile';
+use Params::Validate ':all';
use Carp::Assert;
-use vars (qw/@EXPORT $VERSION/);
-
-$VERSION = 2.13;
-
- at EXPORT = (qw/&gen_thumb/);
+use vars qw(@EXPORT $VERSION);
+
+$VERSION = 2.17;
+
+ at EXPORT = qw(&gen_thumb);
=head2 gen_thumb()
More information about the Pkg-perl-cvs-commits
mailing list