r48193 - in /trunk/libipc-system-simple-perl: Changes debian/changelog lib/IPC/System/Simple.pm t/win32.t

[jawnsy-guest at users.alioth.debian.org]

Author: jawnsy-guest
Date: Fri Dec  4 14:16:06 2009
New Revision: 48193

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=48193
Log:
Fixes only affecting Win32
IGNORE-VERSION: 1.19-1
* New upstream release

Modified:
    trunk/libipc-system-simple-perl/Changes
    trunk/libipc-system-simple-perl/debian/changelog
    trunk/libipc-system-simple-perl/lib/IPC/System/Simple.pm
    trunk/libipc-system-simple-perl/t/win32.t

Modified: trunk/libipc-system-simple-perl/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-system-simple-perl/Changes?rev=48193&op=diff
==============================================================================
--- trunk/libipc-system-simple-perl/Changes (original)
+++ trunk/libipc-system-simple-perl/Changes Fri Dec  4 14:16:06 2009
@@ -1,4 +1,14 @@
 Revision history for Perl extension IPC::System::Simple.
+
+1.19  Fri Dec  4 14:14:25 EST 2009
+
+        * TEST: Added tests to ensure correct behaviour when
+          calling commands in Windows which are contained in directories
+          that contain spaces. (These tests are currently skiped,
+          as they're testing for a known bug.)
+
+        * BUGFIX: Spurious warnings about redefining POSIX macros
+          no longer plague Windows systems.
 
 1.18  Sun Feb  8 19:09:15 AUSEDT 2009
 

Modified: trunk/libipc-system-simple-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-system-simple-perl/debian/changelog?rev=48193&op=diff
==============================================================================
--- trunk/libipc-system-simple-perl/debian/changelog (original)
+++ trunk/libipc-system-simple-perl/debian/changelog Fri Dec  4 14:16:06 2009
@@ -1,4 +1,10 @@
-libipc-system-simple-perl (1.18-2) UNRELEASED; urgency=low
+libipc-system-simple-perl (1.19-1) UNRELEASED; urgency=low
+
+  Fixes only affecting Win32
+  IGNORE-VERSION: 1.19-1
+
+  [ Jonathan Yu ]
+  * New upstream release
 
   [ gregor herrmann ]
   * debian/control: improve long description, thanks to Rhonda for the bug
@@ -12,7 +18,7 @@
     perl (>= 5.6.0-{12,16}) with an unversioned dependency on perl (as
     permitted by Debian Policy 3.8.3).
 
- -- gregor herrmann <gregoa at debian.org>  Thu, 26 Feb 2009 17:26:52 +0100
+ -- Jonathan Yu <jawnsy at cpan.org>  Fri, 04 Dec 2009 06:02:51 -0500
 
 libipc-system-simple-perl (1.18-1) unstable; urgency=low
 

Modified: trunk/libipc-system-simple-perl/lib/IPC/System/Simple.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-system-simple-perl/lib/IPC/System/Simple.pm?rev=48193&op=diff
==============================================================================
--- trunk/libipc-system-simple-perl/lib/IPC/System/Simple.pm (original)
+++ trunk/libipc-system-simple-perl/lib/IPC/System/Simple.pm Fri Dec  4 14:16:06 2009
@@ -84,7 +84,7 @@
     $EXITVAL EXIT_ANY
 );
 
-our $VERSION = '1.18';
+our $VERSION = '1.19';
 our $EXITVAL = -1;
 
 my @Signal_from_number = split(' ', $Config{sig_name});
@@ -106,6 +106,7 @@
 eval { WIFEXITED(0); };
 
 if ($@ =~ UNDEFINED_POSIX_RE) {
+        no warnings 'redefine';  ## no critic
 	*WIFEXITED   = sub { not $_[0] & 0xff };
 	*WEXITSTATUS = sub { $_[0] >> 8  };
 	*WIFSIGNALED = sub { $_[0] & 127 };

Modified: trunk/libipc-system-simple-perl/t/win32.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-system-simple-perl/t/win32.t?rev=48193&op=diff
==============================================================================
--- trunk/libipc-system-simple-perl/t/win32.t (original)
+++ trunk/libipc-system-simple-perl/t/win32.t Fri Dec  4 14:16:06 2009
@@ -2,7 +2,7 @@
 use strict;
 use Test::More;
 use File::Basename qw(fileparse);
-use IPC::System::Simple qw(run capture $EXITVAL);
+use IPC::System::Simple qw(run capture $EXITVAL capturex);
 use Config;
 
 BEGIN {
@@ -23,7 +23,11 @@
 # This command should allow us to exit with a specific value.
 use constant EXIT_CMD => [ @{ &IPC::System::Simple::WINDOWS_SHELL }, 'exit'];
 
-plan tests => 28;
+# These are used in the testing of commands in paths which contain spaces.
+use constant CMD_WITH_SPACES        => 'dir with spaces\hello.exe';
+use constant CMD_WITH_SPACES_OUTPUT => "Hello World\n";
+
+plan tests => 32;
 
 my $perl_path = $Config{perlpath};
 $perl_path .= $Config{_exe} unless $perl_path =~ m/$Config{_exe}$/i;
@@ -112,3 +116,24 @@
 
 run($raw_perl,"-e1");
 ok(1,"raw perl found in multi-part path");
+
+# Check to ensure we can run commands that include spaces.
+
+SKIP: {
+
+    # CMD_WITH_SPACES is not currently distributed with IPC::System::Simple,
+    # effectively making this an author test for now. -- PJF, Dec 4, 2009
+
+    skip(CMD_WITH_SPACES." not available", 2) unless -x CMD_WITH_SPACES;
+
+    my $output = eval { capturex(CMD_WITH_SPACES); };
+
+    is($@, "", "command with spaces should not error (capturex)");
+    is($output, CMD_WITH_SPACES_OUTPUT, "...and give correct output");
+
+    my $output = eval { capture(CMD_WITH_SPACES); };
+
+    is($@, "", "command with spaces should not error (capture)");
+    is($output, CMD_WITH_SPACES_OUTPUT, "...and give correct output");
+
+}