r48976 - in /trunk/libpar-packer-perl: ChangeLog META.yml debian/changelog lib/PAR/Packer.pm myldr/mktmpdir.c

[jawnsy-guest at users.alioth.debian.org]

Author: jawnsy-guest
Date: Sat Dec 19 00:22:04 2009
New Revision: 48976

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=48976
Log:
New upstream release

Modified:
    trunk/libpar-packer-perl/ChangeLog
    trunk/libpar-packer-perl/META.yml
    trunk/libpar-packer-perl/debian/changelog
    trunk/libpar-packer-perl/lib/PAR/Packer.pm
    trunk/libpar-packer-perl/myldr/mktmpdir.c

Modified: trunk/libpar-packer-perl/ChangeLog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpar-packer-perl/ChangeLog?rev=48976&op=diff
==============================================================================
--- trunk/libpar-packer-perl/ChangeLog (original)
+++ trunk/libpar-packer-perl/ChangeLog Sat Dec 19 00:22:04 2009
@@ -1,3 +1,9 @@
+[Changes for 1.002 - Dec 17, 2009]
+* Bug fixes, etc.
+    - RT #52407: fix calls of sprintf in myldr/mktmpdir.c that rely on
+      unspecified behaviour (output buffer is also among the input
+      parameters). (Roderich)
+
 [Changes for 1.001 - Nov 24, 2009]
 * Bug fixes, etc.
     - Fix to the rejection of "main.pl" as input scripts. Previously,

Modified: trunk/libpar-packer-perl/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpar-packer-perl/META.yml?rev=48976&op=diff
==============================================================================
--- trunk/libpar-packer-perl/META.yml (original)
+++ trunk/libpar-packer-perl/META.yml Sat Dec 19 00:22:04 2009
@@ -37,7 +37,7 @@
     file: lib/PAR/Filter/PodStrip.pm
   PAR::Packer:
     file: lib/PAR/Packer.pm
-    version: 1.001
+    version: 1.002
   PAR::StrippedPARL::Base:
     file: lib/PAR/StrippedPARL/Base.pm
     version: 0.975
@@ -63,4 +63,4 @@
   perl: 5.6.0
 resources:
   license: http://dev.perl.org/licenses/
-version: 1.001
+version: 1.002

Modified: trunk/libpar-packer-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpar-packer-perl/debian/changelog?rev=48976&op=diff
==============================================================================
--- trunk/libpar-packer-perl/debian/changelog (original)
+++ trunk/libpar-packer-perl/debian/changelog Sat Dec 19 00:22:04 2009
@@ -1,3 +1,9 @@
+libpar-packer-perl (1.002-1) UNRELEASED; urgency=low
+
+  * New upstream release
+
+ -- Jonathan Yu <jawnsy at cpan.org>  Fri, 18 Dec 2009 16:14:45 -0500
+
 libpar-packer-perl (1.001-1) unstable; urgency=low
 
   [ Jonathan Yu ]

Modified: trunk/libpar-packer-perl/lib/PAR/Packer.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpar-packer-perl/lib/PAR/Packer.pm?rev=48976&op=diff
==============================================================================
--- trunk/libpar-packer-perl/lib/PAR/Packer.pm (original)
+++ trunk/libpar-packer-perl/lib/PAR/Packer.pm Sat Dec 19 00:22:04 2009
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-our $VERSION = '1.001';
+our $VERSION = '1.002';
 
 =head1 NAME
 

Modified: trunk/libpar-packer-perl/myldr/mktmpdir.c
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpar-packer-perl/myldr/mktmpdir.c?rev=48976&op=diff
==============================================================================
--- trunk/libpar-packer-perl/myldr/mktmpdir.c (original)
+++ trunk/libpar-packer-perl/myldr/mktmpdir.c Sat Dec 19 00:22:04 2009
@@ -65,7 +65,7 @@
     const char *subdirbuf_suffix = "";
 
     char *progname = NULL, *username = NULL;
-    char *stmpdir = NULL;
+    char *stmpdir = NULL, *stmpdir2 = NULL;
     int f, j, k, stmp_len = 0;
     char sha1[41];
     SHA_INFO sha_info;
@@ -150,8 +150,9 @@
        need 2 buffers because snprintf() can't write to a buffer it's
        reading from. */
     stmpdir = malloc( stmp_len );
-    sprintf(stmpdir, "%s%s%s%s", tmpdir, dir_sep, subdirbuf_prefix, username);
-    my_mkdir(stmpdir, 0755);
+    stmpdir2 = malloc( stmp_len );
+    sprintf(stmpdir2, "%s%s%s%s", tmpdir, dir_sep, subdirbuf_prefix, username);
+    my_mkdir(stmpdir2, 0755);
 
     /* Doesn't really work - XXX */
     val = (char *)par_getenv( "PATH" );
@@ -194,7 +195,7 @@
             sprintf(
                 stmpdir,
                 "%s%scache-%s%s",
-                stmpdir, dir_sep, buf, subdirbuf_suffix
+                stmpdir2, dir_sep, buf, subdirbuf_suffix
             );
         }
         else {
@@ -215,13 +216,12 @@
             sprintf(
                 stmpdir,
                 "%s%scache-%s%s",
-                stmpdir, dir_sep, sha1, subdirbuf_suffix
+                stmpdir2, dir_sep, sha1, subdirbuf_suffix
             );
         }
     }
     else {
         int i = 0;
-        size_t len = strlen(stmpdir);
 
         /* "$TEMP/par-$USER/temp-$PID" */
 
@@ -229,7 +229,7 @@
         sprintf(
             stmpdir,
             "%s%stemp-%u%s",
-            stmpdir, dir_sep, getpid(), subdirbuf_suffix
+            stmpdir2, dir_sep, getpid(), subdirbuf_suffix
         );
 
         /* Ensure we pick an unused directory each time.  If the directory
@@ -239,14 +239,15 @@
            might interfere. */
 
         while (my_mkdir(stmpdir, 0755) == -1 && errno == EEXIST) {
-            stmpdir[len] = 0;
             sprintf(
                 stmpdir,
                 "%s%stemp-%u-%u%s",
-                stmpdir, dir_sep, getpid(), ++i, subdirbuf_suffix
+                stmpdir2, dir_sep, getpid(), ++i, subdirbuf_suffix
                 );
         }
     }
+
+    free(stmpdir2);
 
     /* set dynamic loading path */
     par_setenv(PAR_TEMP, stmpdir);