r39374 - in /trunk/libhtml-formfu-model-dbic-perl: Changes META.yml Makefile.PL debian/changelog lib/HTML/FormFu/Model/DBIC.pm

gregoa at users.alioth.debian.org gregoa at users.alioth.debian.org
Sun Jul 5 14:03:45 UTC 2009


Author: gregoa
Date: Sun Jul  5 14:03:38 2009
New Revision: 39374

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=39374
Log:
New upstream release.

Modified:
    trunk/libhtml-formfu-model-dbic-perl/Changes
    trunk/libhtml-formfu-model-dbic-perl/META.yml
    trunk/libhtml-formfu-model-dbic-perl/Makefile.PL
    trunk/libhtml-formfu-model-dbic-perl/debian/changelog
    trunk/libhtml-formfu-model-dbic-perl/lib/HTML/FormFu/Model/DBIC.pm

Modified: trunk/libhtml-formfu-model-dbic-perl/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libhtml-formfu-model-dbic-perl/Changes?rev=39374&op=diff
==============================================================================
--- trunk/libhtml-formfu-model-dbic-perl/Changes (original)
+++ trunk/libhtml-formfu-model-dbic-perl/Changes Sun Jul  5 14:03:38 2009
@@ -1,3 +1,15 @@
+0.05001 2009-07-03
+
+    - Fix delete_if_true to work inside a surrounding block.
+    
+    - Made DBIC deletes conditional on row being in_storage.
+    
+    - Bump DBIx::Class prerequisite to 0.08106, when it switched from using
+      DateTime::Format::MySQL to DateTime::Format::SQLite.
+    
+    - Remove prerequisite Test::MockObject - it uses UNIVERSAL::isa which
+      was causing test failures.
+
 0.05000 2009-05-26
 
     - Fix update() "primary key and the foreign key may not be the same column"

Modified: trunk/libhtml-formfu-model-dbic-perl/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libhtml-formfu-model-dbic-perl/META.yml?rev=39374&op=diff
==============================================================================
--- trunk/libhtml-formfu-model-dbic-perl/META.yml (original)
+++ trunk/libhtml-formfu-model-dbic-perl/META.yml Sun Jul  5 14:03:38 2009
@@ -3,6 +3,7 @@
 author:
   - 'Carl Franks'
 build_requires:
+  DateTime::Format::SQLite: 0
   ExtUtils::MakeMaker: 6.42
   Test::MockObject: 0
 configure_requires:
@@ -20,12 +21,11 @@
     - t
 requires:
   DBD::SQLite: 0
-  DBIx::Class: 0.08002
-  DateTime::Format::MySQL: 0
+  DBIx::Class: 0.08106
   HTML::FormFu: 0.05000
   List::MoreUtils: 0
   Task::Weaken: 0
   perl: 5.8.1
 resources:
   license: http://dev.perl.org/licenses/
-version: 0.05000
+version: 0.05001

Modified: trunk/libhtml-formfu-model-dbic-perl/Makefile.PL
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libhtml-formfu-model-dbic-perl/Makefile.PL?rev=39374&op=diff
==============================================================================
--- trunk/libhtml-formfu-model-dbic-perl/Makefile.PL (original)
+++ trunk/libhtml-formfu-model-dbic-perl/Makefile.PL Sun Jul  5 14:03:38 2009
@@ -4,13 +4,17 @@
 perl_version '5.008001';
 all_from 'lib/HTML/FormFu/Model/DBIC.pm';
 
-requires 'DateTime::Format::MySQL';
 requires 'DBD::SQLite';
-requires 'DBIx::Class' => '0.08002';
+requires 'DBIx::Class' => '0.08106';
+# DBIx::Class 0.08106 switched from DateTime::Format::MySQL to ::SQLite
+# Rather than changing our prereqs depending on the installed version
+# of DBIx::Class, just bump the required version
+
 requires 'HTML::FormFu' => '0.05000';
 requires 'List::MoreUtils';
 requires 'Task::Weaken'; # to ensure Scalar::Util was built with weaken()
 
+test_requires 'DateTime::Format::SQLite';
 test_requires 'Test::MockObject';
 
 tests_recursive;

Modified: trunk/libhtml-formfu-model-dbic-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libhtml-formfu-model-dbic-perl/debian/changelog?rev=39374&op=diff
==============================================================================
--- trunk/libhtml-formfu-model-dbic-perl/debian/changelog (original)
+++ trunk/libhtml-formfu-model-dbic-perl/debian/changelog Sun Jul  5 14:03:38 2009
@@ -1,3 +1,9 @@
+libhtml-formfu-model-dbic-perl (0.05001-1) UNRELEASED; urgency=low
+
+  * New upstream release.
+
+ -- gregor herrmann <gregoa at debian.org>  Sun, 05 Jul 2009 15:57:11 +0200
+
 libhtml-formfu-model-dbic-perl (0.05000-2) unstable; urgency=low
 
   [ Nathan Handler ]

Modified: trunk/libhtml-formfu-model-dbic-perl/lib/HTML/FormFu/Model/DBIC.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libhtml-formfu-model-dbic-perl/lib/HTML/FormFu/Model/DBIC.pm?rev=39374&op=diff
==============================================================================
--- trunk/libhtml-formfu-model-dbic-perl/lib/HTML/FormFu/Model/DBIC.pm (original)
+++ trunk/libhtml-formfu-model-dbic-perl/lib/HTML/FormFu/Model/DBIC.pm Sun Jul  5 14:03:38 2009
@@ -9,7 +9,7 @@
 use Storable qw( dclone );
 use Carp qw( croak );
 
-our $VERSION = '0.05000';
+our $VERSION = '0.05001';
 $VERSION = eval $VERSION;
 
 # sub _compatible_config() is only required as long as we support deprecated
@@ -108,7 +108,7 @@
     }
     else {
         my $has_column = $source->has_column($label_col);
-        
+
         @defaults = map {
             [
                 $_->get_column($id_col),
@@ -350,7 +350,7 @@
                         @{ $rep->get_fields };
 
                     if ( defined $del_field ) {
-                        $rep->remove_element($del_field);
+                        $del_field->parent->remove_element($del_field);
                     }
                 }
             }
@@ -500,11 +500,11 @@
 
             my @fpkey = $dbic->related_resultset($rel)->result_source->primary_columns;
 
-            my @cond = (%{$info->{cond}}); 
-             
+            my @cond = (%{$info->{cond}});
+
             # make sure $rel is a has_one or might_have rel
             # stolen from SQL/Translator/Parser/DBIx/Class
-                
+
             my $fk_constraint;
 
             # Get the key information, mapping off the foreign/self markers
@@ -739,7 +739,7 @@
         unless $form->valid($nested_name)
             && $form->param_value($nested_name);
 
-    $row->delete;
+    $row->delete if ($row->in_storage);
 
     return 1;
 }
@@ -805,7 +805,7 @@
             && ( !defined $value || !length $value ) )
         {
             $dbic->discard_changes if $dbic->is_changed;
-            $dbic->delete;
+            $dbic->delete if $dbic->in_storage;
             return;
         }
         if ( $dbic->result_source->has_column($accessor) ) {
@@ -1104,7 +1104,7 @@
 
 Return Value: $form
 
-    $form->model->default_values( $row );
+    $form->model->default_values( $dbic_row );
 
 Set a form's default values from the database, to allow a user to edit them.
 
@@ -1114,7 +1114,7 @@
 
 Return Value: $dbic_row
 
-    $form->model->update( $row );
+    $form->model->update( $dbic_row );
 
 Update the database with the submitted form values.
 
@@ -1124,7 +1124,7 @@
 
 Return Value: $dbic_row
 
-    $form->model->create( $row );
+    my $dbic_row = $form->model->create( {resultset => 'Book'} );
 
 Like L</update>, but doesn't require a C<$dbic_row> argument.
 




More information about the Pkg-perl-cvs-commits mailing list